kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[PD] avoid a single-letter variable

Browse Source 
(single letter variables make it hard to read and understand code quickly and are error-prone for typos)
This commit is contained in:
Uwe
2022-01-05 03:16:00 +01:00
parent a0746a0c02
commit dfa62af40f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/PartDesign/App/FeatureTransformed.cpp
View File

@@ -265,19 +265,19 @@ App::DocumentObjectExecReturn *Transformed::execute(void)
std::vector<TopoDS_Shape> shapes;
bool overlapping = false;
std::vector<gp_Trsf>::const_iterator t = transformations.begin();
std::vector<gp_Trsf>::const_iterator transformIter = transformations.begin();
// First transformation is skipped since it should not be part of the toolShape.
t++;
transformIter++;
for (; t != transformations.end(); ++t) {
for (; transformIter != transformations.end(); ++transformIter) {
// Make an explicit copy of the shape because the "true" parameter to BRepBuilderAPI_Transform
// seems to be pretty broken
BRepBuilderAPI_Copy copy(origShape);
shape = copy.Shape();
BRepBuilderAPI_Transform mkTrf(shape, *t, false); // No need to copy, now
BRepBuilderAPI_Transform mkTrf(shape, *transformIter, false); // No need to copy, now
if (!mkTrf.IsDone())
return new App::DocumentObjectExecReturn("Transformation failed", (*o));
shape = mkTrf.Shape();