kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions Packages Projects 9 Releases 2 Wiki Activity
29,613 Commits 40 Branches 6 Tags
0eee9221f00595213c83993048315eba098f204e
Commit Graph

28 Commits

Author SHA1 Message Date
Uwe
0eee9221f0 [PD] improve face selection for Pad/Pocket 
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
 2022-07-17 18:35:34 +02:00
Uwe
a37ca0e175 [skip CI] [PD] fix typo 2022-06-10 03:39:04 +02:00
wmayer
d1d4b996e7 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
wmayer
7acdcbd031 PD: Fix several coverity issues: 
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
 2022-03-13 16:32:19 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Uwe
a68e017f19 [PD] Gui: Boolean to Groove: remove unused includes 2022-02-21 01:33:04 +01:00
0penBrain
73f2c1434a Modernize signal/slot connection for real :) 2022-02-08 17:51:36 +01:00
Uwe
91b2b7ce6e [PD] Extrude: modernize SignalSlot connection 
as suggested recently by @chennes
 2022-02-04 22:20:31 -06:00
Uwe
5d51871373 [PD] Extrude: handle angle edit visibility 
- adds missing code to handle the edits for the taper angle
 2022-02-05 02:11:14 +01:00
Uwe
12b0e0dd92 [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
Uwe
874767171a [PD] correct copyright year 
both files were created in 2021
 2022-01-23 04:45:12 +01:00
0penBrain
68e1fc46b6 Display Midplane checkbox with Pocket/ThroughAll 
Was enabled but not visible.
Hopefully last time I fix it. :)
 2022-01-22 10:34:14 +01:00
Chris Hennes
5e87b15782 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
1e9ddc5302 [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
Uwe
26a36f6b75 [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Uwe
74e36f3e0c [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
c1d3cb5fee [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
b40ab916bc [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
Uwe
5f59b5e37f [PD] correct copyright 
these files were added by Werner in 2020
 2022-01-06 21:56:53 +01:00
wmayer
a6838cf58f Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
8424c9323b PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
wmayer
90db4c885b PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
b165947625 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
wmayer
0711f6003b PD: use button group to make mid-plane and reversed option mutual exclusive 2021-12-03 00:01:49 +01:00
Ajinkya Dahale
5e3ad45ef4 [PD] Use compare to compare strings instead of substr 
Used when finding subelements of a feature. Many of the comparisons used to also
check for string lengths, but as far as I can tell they are not strictly
necessary (see https://www.cplusplus.com/reference/string/string/substr/) and
just `substr` can be used without them. However, `compare` explicitly is for
comparing, and does not make a new object that `substr` does.
 2021-11-28 22:05:46 +01:00
wmayer
dd92764eb5 PD: fix bug in TaskExtrudeParameters 
When switching from Custom direction to Select reference mode do not jump back to Custom direction mode after selecting an edge
 2021-11-27 02:22:37 +01:00
wmayer
c20cfd5db6 PD: code-refactoring of TaskExtrudeParameters 2021-11-27 01:45:08 +01:00
wmayer
a58846c460 PD: create a common base class of TaskPocketParameters and TaskPocketParameters to reduce code duplications 2021-11-26 16:23:45 +01:00