Commit Graph

2813 Commits

Author SHA1 Message Date
Russell Johnson
1ce0389e45 Path: Fix connected multi-face clearing bug
Identified by MLampert.  If multiple faces are selected at varying Z-heights, the `combineConnectedShapes()` method fails to connect them due to offset Z-heights.  This fix places all input faces for that method into the same working plane.
2021-03-13 11:34:35 -06:00
sliptonic
15d23af9f8 [PATH] Fix bug with spindle not restarting
if output is split by operation spindle should restart when next file is loaded
2021-03-12 13:12:09 -06:00
sliptonic
5141e28535 Update 45degree_chamfer.fctb 2021-03-12 10:16:26 -06:00
Benjamin Nauck
8441f0f690 [Path] Use std::shared_ptr instead of boost::shared_ptr
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
David Osterberg
c1b3fba031 Beautify xml step 1: These changes do not affect the uic output 2021-03-02 16:29:11 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
sliptonic
81a3b9693b Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
53bd6a2d77 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
90ec044cb4 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
3d83e73549 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
8ab39462b7 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
5c984dff6a fix string formatting 2021-02-23 18:59:04 -06:00
sliptonic
afee9d3c36 Merge pull request #4484 from Russ4262/fix_profile_feature_filter
[Path] Fixes for Profile operation [0.19]
2021-02-20 17:27:00 -06:00
sliptonic
be2462d7ec Merge pull request #4498 from sliptonic/bug/slotexperimental
[PATH] move slot op to experimental status
2021-02-20 17:16:22 -06:00
sliptonic
e7200193bd Merge pull request #4497 from sliptonic/bug/adaptiveuseoutlineprop
[PATH]  Small fixes to Adaptive op and Heidenhain post processor
2021-02-20 17:15:45 -06:00
Russell Johnson
929405e745 Path: LGTM cleanup 2021-02-20 12:32:25 -06:00
Russell Johnson
6ea5b2c69c Path: Remove unnecessary line return 2021-02-20 12:32:25 -06:00
Russell Johnson
2ff909b993 Path: Add error for incorrect open-edge usage
When profiling open edges, the user must currently select a top edge and then set the Final Depth manually to a value below the selected edge(s).
This fix provides the user with feedback for the empty path generated.
2021-02-20 12:32:25 -06:00
Russell Johnson
a1d3f8e490 Path: Catch error if ofstShape has no Area attribute 2021-02-20 12:32:25 -06:00
Russell Johnson
05b2b9e28e Path: Fix incorrect empty data type return 2021-02-20 12:32:25 -06:00
Russell Johnson
d90d176a86 Path: Catch openEdges error if None 2021-02-20 12:32:25 -06:00
Russell Johnson
a33a287475 Path: Fix spacing typo 2021-02-20 12:32:25 -06:00
Russell Johnson
b3cfb29038 Path: Fix range() input type per gcc-7 build 2021-02-20 12:32:25 -06:00
Russell Johnson
0718afa5e1 Path: Fix feature selection and handling
Fix error when working with selections containing edges and faces.  This fix effectively processes edges and only passes faces on to next processing step.  This simplifies the code a bit and changes some `obj.Base` references to `otherBase` to improve readability.
Path: Improve `obj.Base` reading and processing

`obj.Base` is first read in `self._processEdges()`.  All edges are identified and processed there.  Remaining features are saved in `remainingObjBaseFeatures` to be processed in the next section of the Profile code.
Path: Change `if` to `elif`
2021-02-20 12:32:25 -06:00
Russell Johnson
b86104b01e Path: Fix error for undefined profileshape variable 2021-02-20 12:32:25 -06:00
Russell Johnson
cda4d12ad2 Path: Fix open-edge profiling for micro bit usage 2021-02-20 12:32:25 -06:00
Russell Johnson
f1f584af2d Path: Change HandleMultipleFeatures default value to Collectively
This fixes error when attempting to profile loop of vertical faces, thus maintaining original Profile Faces behavior by default for vertical looped face set.
2021-02-20 12:32:25 -06:00
Russell Johnson
edab3c6ecc Path: Apply LazyLoader for DraftGeomUtils module 2021-02-20 12:32:25 -06:00
sliptonic
ce3249d0a8 move slot op to experimental status 2021-02-20 12:10:49 -06:00
sliptonic
7d4ca77f1a Merge pull request #4454 from lag-linaro/master
PathToolBitLibraryGui: Fix LinuxCNC tool table format
2021-02-20 11:54:51 -06:00
Stefano Chiaro
947dc038db Update src/Mod/Path/PathScripts/post/heidenhain_post.py
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2021-02-20 11:37:08 -06:00
Stefano Chiaro
f7de07a522 Update heidenhain_post.py
fixed pol_Angle
2021-02-20 11:37:08 -06:00
sliptonic
615573580d Pep8 cleanup 2021-02-20 11:37:08 -06:00
sliptonic
c40bce0597 Add useoutline property to op if doesn't exist 2021-02-20 11:37:08 -06:00
sliptonic
586b2e6aa7 add back translation string 2021-02-19 17:50:56 -06:00
sliptonic
63f0e7aad4 Fix unit test with property name sanitize. 2021-02-17 18:39:15 -06:00
sliptonic
9ab32df926 Fixes #4555 2021-02-17 17:21:50 -06:00
sliptonic
257159fc1b fix lgtm error 2021-02-17 17:21:50 -06:00
sliptonic
0dfa611503 fix typos 2021-02-17 17:20:19 -06:00
sliptonic
42c769d635 fix #4572 2021-02-17 17:20:19 -06:00
sliptonic
29e714da02 remove deprecated preference setting 2021-02-17 17:20:19 -06:00
sliptonic
90b970ab4f Merge pull request #4440 from mlampert/bugfix/path-invalid-base-geometry-robustness
[Path]: bugfix/invalid base geometry robustness
2021-02-16 09:27:06 -06:00
sliptonic
900612ce2b Update PathOp.py
fix typo
2021-02-16 09:25:59 -06:00
sliptonic
8388a7e730 Merge pull request #4467 from mlampert/bugfix/cleanup-redundant-check
[Path]: bugfix PVS detected redundant check
2021-02-16 09:02:09 -06:00
Markus Lampert
5def0433cd Fixed angle detection 2021-02-15 23:23:16 -08:00
mlampert
11bfb431d2 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 16:03:28 -08:00
mlampert
500f470220 Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-15 16:01:48 -08:00
Markus Lampert
b3c11f5cd2 Fixed TC creation from templates if legacy tools are enabled. 2021-02-15 22:15:17 +01:00
Markus Lampert
0342e6360d Removed obsolete preference api 2021-02-15 22:15:17 +01:00