kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,129 Commits 40 Branches 6 Tags
2661e0ea4769fd669c3b9c6510bb1efe76bdff70
Commit Graph

243 Commits

Author SHA1 Message Date
wmayer
2661e0ea47 PartDesign: [skip ci] make base object visible again if initial additive helix fails to recompute 2021-02-17 13:33:02 +01:00
donovaly
2834075d6a [PD] rename icons to match Wiki files 
For the What#s this feature we need to have a uniform naming of the features and its icons. For some PD icons this is not the case and since we are in feature freeze, this is the right time to address this.
(I see the same is already done for Mesh.)
 2021-02-11 12:47:25 +01:00
David Osterberg
59ec3cb141 PartDesign: New features AdditiveHelix and SubtractiveHelix 
These features, based on the code for the Pipe class, allow the user
to simply create a helical sweep within PartDesign workbench.

Sample application is threads, springs, coils, augers, etc.

Also, remove needless requirement for positive cone angle on helixes.

Thanks to @bitacovir for helping with the icons
Thanks to @chennes for review
Thanks to @vosk for review
Thanks to @wwmayer for review

Enforce that links stay within scope for ProfileBased features
This also ensures that the Body itself is not used for creating features within
the body, causing a "Graph not a DAG" error.
 2021-02-04 13:01:12 +01:00
Pierre LeMoine
7999536858 Transform patterns can be created from multiple base features 
The infrastructure/piping seems to have been in place for a long while.
Not tested for all variations of pattern transforms.
The major enabler was removing the `break`.
Some extra piping added to let the code at call-site decide if to select multiple features or not.
 2021-02-04 11:58:47 +01:00
luz paz
faa8688ee5 PartDesign: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the PartDesign Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
wmayer
42d643c8f7 PD: whitespace improvements 2020-09-15 14:20:24 +02:00
mwganson
74e4a3e976 [Part Design] allow for preselecting loft sections and pipe spines prior to invoking command 2020-09-15 10:48:09 +02:00
donovaly
c5e2aba15e [PD] allow multiselection on creation of pattern 
- Since realthunder's contributions some months ago, the 4 pattern features (mirror, linear, polar, mulitransform) can handle several features at once.
This PR allows to select multiple features when creating a pattern.
(This speeds up the workflow because at the moment one has to create the pattern with one feature and subsequently add more.)

- fix dialog issue that Add and Remove button could be active the same time

- use the keyboardTracking feature to avoid unnecessary recomputes (e.g. currently 3 recomputes when inserting "12.5" to the length field of linear pattern)

- fix wrong <extends> statement in .ui files (automatically spotted and fixed by Qt's Designer)
 2020-07-30 10:56:24 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter 
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
 2020-07-27 10:57:34 +02:00
luz paz
f20ab1765f Fix Crowdin typos + trim superfluous whitespace [skip-ci] 
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
 2020-07-23 13:52:44 +02:00
wmayer
f32248997e Coverity: [skip ci] Dereference before null check 
Remove logically dead code because 'pcActiveBody' cannot be null at this stage
 2020-07-21 14:33:54 +02:00
wmayer
1a16cde1f5 Coverity: Structurally/Logically dead code 2020-07-20 17:34:28 +02:00
Zheng, Lei
5666598a6b PartDesign: change SubShapeBinder make command 
Allows making binder to another binder.
 2020-07-12 19:43:23 +02:00
Zheng, Lei
18054d95f3 PartDesign: fix SubShapeBinder make command 2020-03-21 22:12:27 +01:00
Zheng, Lei
509cbfa53c PartDesign: allow making new ProfileBased feature using multiple faces 2020-03-20 16:38:00 +01:00
Zheng, Lei
3366a245f5 PartDesign: improve SubShapeBinder make command 2020-03-20 15:02:20 +01:00
wmayer
dce426bf8f PartDesign: [skip ci] New sketch function doesn't try any more to edit a selected sketch 2020-03-11 15:14:18 +01:00
luz.paz
7b7797f4f3 Fix various (doxy) typos and whitespace issues 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
 2019-10-03 07:57:13 +02:00
wmayer
d0d92b0801 force strict ISO C++ (-Wpedantic) 
for Fem, Import, PartDesign, Robot, Sketcher, TechDraw
 2019-09-18 14:18:07 +02:00
DeepSOIC
588fc8df77 PartDesign: change view sizing on new sketch 2019-09-11 21:39:16 +02:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
6d02fa5409 automatically redirect to tip object in case body display mode is set to Tip and a face was selected to create a new sketch 2019-07-08 11:46:09 +02:00
luz.paz
7c1490c046 Misc. typo and whitespace fixes 
Found via `codespell`
 2019-05-30 19:56:12 +02:00
Abdullah Tahiri
e82c154d1d PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
wmayer
2bb5797568 PVS: V595 The pointer was utilized before it was verified against nullptr 2019-02-17 20:55:52 +01:00
wmayer
f581d5c8cb PVS: V560 A part of conditional expression is always true 2019-02-17 13:56:48 +01:00
wmayer
e9434d5023 in selection dialog also offer planar shape binders 2019-02-15 18:45:45 +01:00
wmayer
55a4f78adf Add command to create coordinate system as datum item 2019-01-08 12:48:37 +01:00
wmayer
1a8d3a7030 make handling more user-friendly if Sketch is outside of Body object 2019-01-06 22:43:14 +01:00
wmayer
9a7f97c827 Fix usage of Reference dialog: 
+ fix memory leak by using QDialog on the stack
+ open a transaction where needed when making a copy to avoid mess with undo/redo
+ set proper title and use main window as parent
+ replace class name Dialog with PartDesignGui::DlgReference
 2018-12-03 17:54:05 +01:00
wmayer
20298c45d2 set the cloned shape the tip of the created body 2018-10-16 19:39:07 +02:00
wmayer
39d072bf82 fixes 0003621: Additive and subtractive loft preview not showing during creation 2018-10-03 12:40:43 +02:00
wmayer
caf78bbabf fixes 0003509: Create MultiTransform Feature from existing Transform Feature forces document migration 2018-09-30 18:14:22 +02:00
wmayer
3c048904ff fixes 0003447: False PartDesign migration request 2018-09-22 13:59:34 +02:00
ageeye
8faf50ec04 PartDesign::Clone maintain the colors of the original 2018-06-12 10:30:07 -03:00
wmayer
597dbf6094 don't allow to set empty list of bodies for boolean operations 
don't update the body feature if boolean body list is empty
 2018-03-15 12:05:13 +01:00
wmayer
3fd549ec71 fixes #0003376: PartDesign Boolean produces exception with wrong selection of active Body 2018-03-15 11:13:45 +01:00
wmayer
707bbee6ae fix warning: lambda capture 'this' is not used [-Wunused-lambda-capture] 2018-02-10 12:42:41 +01:00
Markus Lampert
322598decf Fixed whitespace inconsistency. 2017-10-22 11:24:58 -07:00
wmayer
7c4dc0d669 allow the user to proceed if default settings for revolution/groove raises an exception 2017-10-18 12:52:04 +02:00
wmayer
16d4105a05 automatically set the tip after creating transform features to avoid messing up the history 2017-10-06 10:20:26 +02:00
wmayer
98c6e0e2b0 implement clone command for part design 2017-10-01 18:25:55 +02:00
wmayer
5a1a88568a harmonize creation of linear pattern inside a multi transform to direction creation of linear pattern 2017-09-29 23:57:31 +02:00
wmayer
2611f072b7 allow to attach a sketch to any kind of planar surfaces, not only planes 2017-09-23 22:46:54 +02:00
wmayer
c1ac53b61f fix cyclic dependency if body is selected when creating a datum entity 2017-09-22 11:21:20 +02:00
Stefan Tröger
f1c307dc28 PartDesign: Boolean must show the operation result, not the children. fixes #0003184 2017-09-21 10:48:38 +02:00
wmayer
f663a754c8 fix cyclic dependency if body is created when creating a shape binder 2017-09-13 12:20:16 +02:00
Stefan Tröger
034219771f PartDesign: Prevent problems with link scopes during feature creation 2017-09-09 16:55:55 +02:00
Stefan Tröger
972b89d0a0 Make PartDesign::Boolean work with new Link structure 
This is the first feature that used GeoFeatureGroupExtension and required links to the groups inside as well as to things on the same level. Hence a few modifications to link scopes have been nesseccary.
 2017-09-09 16:55:55 +02:00
triplus
bab75bbcb7 PDN - what's this and command names improvements 2017-08-06 20:47:09 +02:00