Commit Graph

18917 Commits

Author SHA1 Message Date
donovaly
26d7902303 [FEM] correct sorting order
all other menu items are sorted and we also keep the sorting in the Wiki
2021-02-20 16:40:04 +01:00
wmayer
cdae5049ed Import: [skip ci] fixes #0003988: the function Import.readDXF doesn't import Bsplines 2021-02-20 16:37:02 +01:00
wmayer
13ed4bc6e8 PD: [skip ci] fixes #0004540: When manual size of DatumPlane is selected its Length property is not saved to the file and consequently not restored on opening 2021-02-20 13:33:54 +01:00
wmayer
eb240c219c PD: [skip ci] do not pop-up dialog when creating a body while another body is selected 2021-02-19 21:44:48 +01:00
David Osterberg
0d97fb6f5a PartDesign: Fix helix for OCC versions < 7.5.0 2021-02-19 20:02:11 +01:00
vosk
542bf23cb0 [TD] - Fix geometry object leaking on every exec 2021-02-19 16:50:56 +01:00
bitacovir
27042216c9 [UI] Add tools to Mesh WB toolbar 2021-02-19 16:28:42 +01:00
Benjamin Nauck
f5b7f645d8 Spreadsheet: Don't autocomplete when writing strings
After pull request https://github.com/FreeCAD/FreeCAD/pull/4215 it
doesn't make much sense helping the user to write expressions without
leading '=', as that content will be parsed as a string.

This change adjusts the behaviour in SpreadsheetGui's LineEdit to avoid
popping up the ExpressionCompleter when no leading equal sign is used.
2021-02-19 16:22:41 +01:00
Benjamin Nauck
dc444b1f09 Spreadsheet: Fix coverity warning
There are no reason to check the return values for these functions
as the string passed as an argument will be set to an empty string
if it false. An empty string is a valid option in these instances.

Coverity warnings fixed:

CID 316520 (1 of 1): Unchecked return value (CHECKED_RETURN)
3. check_return: Calling getAlias without checking return value (as is done elsewhere 8 out of 10 times).

CID 316557 (1 of 1): Unchecked return value (CHECKED_RETURN)
8. check_return: Calling getAlias without checking return value (as is done elsewhere 8 out of 10 times).
2021-02-19 15:47:27 +01:00
donovaly
e0d07257b7 [PD] fix dressup feature display when broken
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
2021-02-19 14:51:52 +01:00
David Osterberg
c107ca3100 PartDesign: Check closedness in AddSub refine function 2021-02-19 14:33:56 +01:00
bitacovir
857ba06219 [UI] 0.19 Replace FEM WB icons 2021-02-19 14:25:01 +01:00
wmayer
ed02d1bbdd PD: [skip ci] recompute document when canceling task dialog, fix also possible crash 2021-02-19 11:33:58 +01:00
wmayer
98f9397939 PD: [skip ci] drop some superfluous static_cast 2021-02-18 22:51:15 +01:00
Chris Hennes
30c24ae0bc [PD] Fix isFeatureMovable() to check null status of property
As reported by @donovaly, if you try to move a pipe that does not have
an auxilliary spine, the code segfaults. This commit adds a check to ensure
that not only does the property exist (which in this case it always does), but
also that it does not contain a null. That is a valid value for the property
to have, but cannot be itself interrogated for moveability by the isFeatureMovable
recursive call. This fix is also applied to the other similar conditions in that
function to ensure they never yield the same segmentation fault.

Forums topic: https://forum.freecadweb.org/viewtopic.php?p=479388#p479388
2021-02-18 22:44:13 +01:00
David Osterberg
6bcd37093c PartDesign: Mild code cleanup of Helix 2021-02-18 21:51:44 +01:00
Abdullah Tahiri
f93b376cd5 Sketcher: Improved ViewProvider visualisation for non-rational Bsplines with non-unitary weight constraints
===========================================================================================================

OCCT forces weights of non-rationa Bsplines to be 1.0

In the presence of non-unitary weight constraints, the weight representation (constraint) has a different radius
than the circle.

This commit fixes this behaviour, by forcing the circle to match the weight constraint.

The information layer still reports OCCT weights being 1.0, but the visual artifact is fixed.
2021-02-18 17:28:38 +01:00
Abdullah Tahiri
324f6d3e26 Part: Geometry - BSpline - fix weight assignment
================================================

If during assignment of weights (during the for loop iteratively setting the poles) all weights
become (temporarily) equal even though weights does not have equal values
OCCT will convert all the weights (the already assigned and those not yet assigned)
to 1.0 (nonrational b-splines have 1.0 weights). This may lead to the assignment of wrong
of weight values.

The work-around is to temporarily set the last weight to be assigned to a value different from
the current value and the to-be-assigned value for the weight at position last-to-be-assign but one.

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=478701#p478702
2021-02-18 17:28:38 +01:00
Yorik van Havre
08e226df25 Merge pull request #4456 from donovaly/TD-balloon-drag
[0.19] [TD] fix dragging of balloons
2021-02-18 15:48:58 +01:00
Yorik van Havre
a399312750 Merge pull request #4470 from mnesarco/master
Icons for Marz, ExtMan, MnesarcoUtils Workbenches
2021-02-18 15:47:47 +01:00
Yorik van Havre
7c3911f61b Merge pull request #4479 from Roy-043/ArchRoof-compatibility-fix-2
[Arch] ArchRoof: Improved compatibility fix
2021-02-18 15:46:52 +01:00
donovaly
190ddd941e QGIViewBalloon.cpp: a fix as suggested 2021-02-18 01:41:23 +01:00
Roy-043
9a444671b7 [Arch] ArchStructure.py wrongly used Part.Line (endless line) to close a wire. 2021-02-17 23:29:01 +01:00
Roy-043
30c4c58f0b [Arch] ArchRoof: Improved compatibility fix
The check if a relative profile in turn references a relative profile has been improved. Added: run or angle of profilRel must be zero.
2021-02-17 21:35:51 +01:00
davidmubernal
da990fd51d Addon Manager: Add MakerWorkbench icon 2021-02-17 17:12:08 +01:00
Chris Hennes
dc0d4e4a02 [TD] Fix error in editable status of DOCUMENT_TYPE
All of the TechDraw ISO7200_Pep templates so that the DOCUMENT_TYPE area is
fully editable, allowing the user to overwrite the default contents entirely
instead of just adding to it.
2021-02-17 16:01:44 +01:00
wmayer
313fc6294f PD: [skip ci] fix typo in comment 2021-02-17 15:55:47 +01:00
marioalexis
8b8b12b646 FEM: Fix typo in filter function tooltip 2021-02-17 15:54:17 +01:00
wmayer
2661e0ea47 PartDesign: [skip ci] make base object visible again if initial additive helix fails to recompute 2021-02-17 13:33:02 +01:00
David Osterberg
8e16225b03 PartDesign: Helix: fix preview 2021-02-17 13:19:06 +01:00
Frank D. Martinez M
c5ebb6dd58 AddonManager: Added icons for Marz, ExtMan, MnesarcoUtils workbenches 2021-02-16 14:50:12 -05:00
sliptonic
87b6a42f13 Merge pull request #4440 from mlampert/bugfix/path-invalid-base-geometry-robustness
[Path]: bugfix/invalid base geometry robustness
2021-02-16 09:27:06 -06:00
sliptonic
61824e80f3 Update PathOp.py
fix typo
2021-02-16 09:25:59 -06:00
Bernd Hahnebach
a62b5b314b FEM: code formatting, revert parts of commit f4a65dcbb6 2021-02-16 16:17:47 +01:00
sliptonic
fc1f611a18 Merge pull request #4467 from mlampert/bugfix/cleanup-redundant-check
[Path]: bugfix PVS detected redundant check
2021-02-16 09:02:09 -06:00
Markus Lampert
cff02d85de Fixed angle detection 2021-02-15 23:23:16 -08:00
donovaly
da4f6cecc8 QGIViewBalloon.cpp: code simplification 2021-02-16 01:51:43 +01:00
mlampert
eae5826d93 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 16:03:28 -08:00
mlampert
04fb966d69 Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-15 16:01:48 -08:00
donovaly
1061c0ed85 [TD] fix dragging of balloons
as reported in https://forum.freecadweb.org/viewtopic.php?f=10&t=55109&start=30#p478147
dragging a balloon pollutes the undo steps destroying working with undo and drawings.
2021-02-15 22:28:13 +01:00
Markus Lampert
35c1a005f1 Fixed TC creation from templates if legacy tools are enabled. 2021-02-15 22:15:17 +01:00
Markus Lampert
522734eb3c Removed obsolete preference api 2021-02-15 22:15:17 +01:00
mlampert
ec89caacd1 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 12:22:13 -08:00
Markus Lampert
41de35c456 Only use IconViewProvider in PathStock when required. 2021-02-15 12:21:33 -08:00
Syres916
4d3ecdab68 Added missing </a> as per review 2021-02-15 20:12:39 +01:00
Syres916
baf5e5398e [Start] Enable hyperlink for installed Addons
as per discussion https://forum.freecadweb.org/viewtopic.php?f=8&t=55623
2021-02-15 20:12:39 +01:00
David Osterberg
7803740edd PartDesign: Subtractive Loft. Raise error when base is null.
Previously Subtractive loft would create a shape if there is no base
object. This is because the code is shared with Additive Loft, where
that is the right thing to do. Now we check for this, and return error
if there is nothing to subtract from.
2021-02-15 19:50:51 +01:00
sliptonic
48dc4063f8 Merge pull request #4387 from mlampert/feature/add-experimental-features-to-preferences
[Path]: Expose experimental feature flag in preferences - with warning.
2021-02-15 10:09:53 -06:00
sliptonic
ab186aa05a Merge pull request #4433 from J-Dunn/master
[PATH] fix conecutter core dumps #4561
2021-02-15 10:03:09 -06:00
David Osterberg
1d0466d6f2 PartDesign: Improve Helix parameter proposals
The previous initial proposed parameters could cause self intersection
when the user switches axis
2021-02-15 16:48:42 +01:00