sliptonic
f0f8907f29
Merge pull request #6659 from sliptonic/bug/profile
...
[Path] Fixes #6658
2022-03-27 10:58:41 -05:00
sliptonic
c9f60aadb4
[Path] Make tool controller set default spindle direction from tool attributes if it exists
2022-03-26 12:17:22 -05:00
sliptonic
b977079fd6
[Path] Make 'forward' the default for spindle direction
2022-03-26 11:27:33 -05:00
sliptonic
b9caead132
[Path] Fixes #6658
2022-03-24 15:36:35 -05:00
wmayer
32c46fa98a
Path: suppress warnings caused by boost
2022-03-24 21:09:28 +01:00
sliptonic
22d23f0d6c
Merge pull request #6651 from sliptonic/bug/5956
...
[Path] Fix # 5956.
2022-03-24 09:05:39 -05:00
sliptonic
35bac7cf96
Merge pull request #6649 from sliptonic/bug/5832
...
[Path] Fixes #5832
2022-03-23 18:51:20 -05:00
wmayer
d21a60b294
All: modernize C++11
...
* replace deprecated headers
2022-03-23 22:44:18 +01:00
sliptonic
e0f5e2837f
Expose PocketLastStepOver property
...
Property can be useful to fine tune the last stepover for some shapes
2022-03-23 15:10:34 -05:00
wmayer
6a69efc4a6
Path: modernize C++11
...
* use nullptr
2022-03-23 19:26:15 +01:00
Uwe
56dd1f1ff0
[Path] Fixes #5832
...
Remove unused and confusing spiral and triangle patterns
2022-03-23 10:35:58 -05:00
Yorik van Havre
1563822763
Translations: Merged crowdin strings
2022-03-23 10:37:50 +01:00
Yorik van Havre
d12a201d89
Translations: updated ts files
2022-03-23 10:24:55 +01:00
Russell Johnson
d8a8084c29
Path: Fix Face Region with no Base
...
This fix addresses an incorrect shape variable passed when Boundary Shape is set to Face Region and there is no Base geometry - indicating entire model to be milled.
2022-03-22 18:16:31 -05:00
sliptonic
837589ef4f
Merge pull request #6612 from mlampert/bugfix/bag-of-minor-isssues
...
PATH: Bugfix/bag of minor isssues
2022-03-21 08:34:23 -05:00
sliptonic
31e327a0cb
Merge pull request #6592 from Russ4262/fix/depth_params_twin_depths
...
Path: Fix roughly equal depth entries
2022-03-21 08:33:59 -05:00
Uwe
0b50af794c
[Path] remove Python.h and Xerces
...
they are not needed anymore
2022-03-21 13:18:42 +01:00
Markus Lampert
115fbd68bb
Blanket black formatting for Path python files
2022-03-20 13:23:48 -07:00
Markus Lampert
75e5dc95d5
Fixed read-only state of quantity spin box when expression is 'clear'ed
2022-03-20 13:23:48 -07:00
markus
6751212dd0
Fixed setting a face's normal as the axis for model alignment
2022-03-20 13:23:48 -07:00
Russell Johnson
50117a57de
Path: Simplify changes per developer conversations
...
Also update TestPathDepthParams.py to reflect simplification of changes.
Remove some comments.
Employ `sorted()` function per MLampert suggestion
2022-03-20 14:25:17 -05:00
sliptonic
cf64b06c89
simpler way to filter roughly equal depth values
2022-03-20 14:25:16 -05:00
Russell Johnson
6b9312c567
Path: Renumber unit tests per triple-digit schema
...
per request of Sliptonic
2022-03-20 14:25:15 -05:00
Russell Johnson
0c63eb2d94
Path: Add additional roughly-equal depths unit tests
2022-03-20 14:25:15 -05:00
Russell Johnson
abdb4eea86
Path: Fix roughly equal depth entries
...
Add code block to remove first of any two consecutive, roughly equal depth values (twin values).
Add two unit tests to support new code block and use cases.
2022-03-20 14:25:14 -05:00
wmayer
ae9acd6a78
Path: fix assignment operator of CLine
...
* Assignment operator in class CLine should have return type CLine&. Otherwise a copy is created at each call.
2022-03-20 19:32:32 +01:00
luz paz
773bd041e9
Path: remove superfluous 'pass' per LGTM
...
ref: https://lgtm.com/rules/910088/
2022-03-19 20:06:48 -04:00
sliptonic
b25eaec2e5
Merge pull request #6575 from Russ4262/fix/rebuild_empty_job_with_gui
...
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
2022-03-19 15:44:28 -05:00
sliptonic
892891f0c4
Merge pull request #6590 from sliptonic/feature/warnlegacy
...
[Path] Warn user if enabling legacy tools
2022-03-18 10:46:42 -05:00
wmayer
e4d1ed8366
Base: rename BaseExceptionFreeCADError to PyExc_FC_GeneralError
2022-03-17 14:45:48 +01:00
wmayer
1f12dca2b4
Py: replace BaseExceptionFreeCADError with more suitable exception types
2022-03-17 13:54:23 +01:00
Russell Johnson
61888959e2
Path: Change action to warning with option for action.
2022-03-16 11:47:51 -05:00
Russell Johnson
b2ab3d7c48
Path: Correct comment spelling
2022-03-16 11:40:24 -05:00
Russell Johnson
4e8d93ee72
Path: Extend Job integrity check to GUI side, issue #6207 [Bug]
...
This commit adds a simple `_jobIntegrityCheck()` method to verify that a model and tool exists within the Job object, when interacting with the Task Panel. If either is missing, the appropriate tab is activated in the task window, and the appropriate edit window is opened for the user, with messages printed in the report view window.
Add check for existence of `SetupSheet` property of empty Job object.
These changes improve upon fixes in PR #5008 and related bug fixes.
2022-03-16 11:40:23 -05:00
sliptonic
6309575591
[Path] Warn user if enabling legacy tools
...
Warn user if opening job that contains legacy tools
2022-03-15 11:05:20 -05:00
sliptonic
4b49c87650
Merge pull request #6577 from Russ4262/fix/millface_removalshapes
...
Path: Fix `self.removalshapes` declaration [Bug]
2022-03-15 09:26:39 -05:00
sliptonic
da2b77d611
Merge pull request #6576 from Russ4262/fix/cancel_new_dressup_cleanup
...
Path: Fix automatic `commitTransaction()` calls, issue #6149 [Bug]
2022-03-15 09:25:43 -05:00
sliptonic
86539bf6db
Merge pull request #6571 from Russ4262/fix/tag_dressup_radius_value
...
Path: Fix inconsistent float type usage, issue #6170 [Bug]
2022-03-14 09:26:24 -05:00
Yorik van Havre
a55ee61840
Merged crowdin translations
2022-03-14 12:21:01 +01:00
Yorik van Havre
cfdd2af62d
Updated master ts files
2022-03-14 12:13:40 +01:00
wmayer
0f9768fb33
Fix coverity issue:
...
* CID 332682: Resource leak
* CID 350607: Resource leak
* CID 332677: Resource leak
2022-03-14 11:35:04 +01:00
Russell Johnson
4e9f7b0b62
Path: Fix self.removalshapes declaration [Bug]
...
Prior to this fix, the `self.removalshapes` variable is not declared if `obj.Base` does not exist, or is empty. This moves the declaration up in scope to the method level.
2022-03-12 22:34:03 -06:00
Russell Johnson
2bc14f84aa
Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]
...
This commit removes the automatic committal of transactions when activated with GUI command. The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
2022-03-12 22:05:04 -06:00
Russell Johnson
68d20e7e90
Path: Improve value assignment syntax for radius
2022-03-12 20:00:40 -06:00
sliptonic
73e995a0f7
Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
...
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Russell Johnson
ba4611a260
Path: Fix radius type inconsistency, issue #6170 [Bug]
...
Make `self.radius` a float type throughout since other methods and functions treat it as such.
2022-03-12 18:29:21 -06:00
Matti Eiden
34ed7bc123
PathArray: Support applying PathArray on Dressups
2022-03-12 22:31:16 +02:00
Russell Johnson
4ae4e7be1a
Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
...
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate. This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
5d798e26cf
[Path] fix a typo
2022-03-12 02:24:44 +01:00
Uwe
5dba742beb
[Path] 2nd part of the Git fix attempt
...
renaming it back
2022-03-12 02:01:29 +01:00