kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
31,030 Commits 39 Branches 6 Tags
308cf4ffb061be5de5c8defdcff0f5f5d7001ecc
Commit Graph

31030 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
wmayer
308cf4ffb0 Gui: code-refactoring 
Split selection handling from View3DInventorViewer and move to View3DInventorSelection
 2022-11-16 20:27:14 +01:00
Ajinkya Dahale
e1485388d4 [Sketcher][planegcs] Make changes as per comments on #7484 
Comments by @abdullahtahiriyo.

Remove default values and smaller constructor for `CenterOfGravity` and
`WeightedLinearCombination` constraints.

Clarify comments.

Improve readability of `CenterOfGravity` and `WeightedLinearCombination`
constraints.
 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
473a380b49 [Sketcher][planegcs] Set knot constraint as internal alignment 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
f75bd1eed7 [Sketcher] Do not make knots construction points 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
e1d72a3023 [Sketcher] Stop treating knots as fixed in GUI commands 
This stops constraints from becoming non-driving when not set.

Follow 0penbrain's comments

typo
 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
ba4f2bf128 [Sketcher] Constrain B-spline knots as linear combination of poles 
Also squashes:

[Sketcher] Create center of gravity constraint in planegcs

[Sketcher] typo

[Sketcher] Use accurate "weights" for knots

By weights we mean the linear combination factor B_i(x) such that
spline(x) = sum(pole_i * B_i(x)) for _non-rational_ splines.

[Sketcher] Use more appropriate weights for knots

These are relevant for knots _away_ from any ends (and possibly other high
multiplicity knots).

[Sketcher] Make COG constraint weights user-definable

[Sketcher] Make `flattenedknots` for periodic B-Splines

[Sketcher] Fix incorrect setup of `flattenedknots`

Without ensuring enough space, iterators become invalid. These iterators are
needed because for periodic B-splines we need to pad flattenedknots with offset
values within flattenedknots.

Apparently there is still some iterator issues even after the reserve. Just use
fresh vectors instead.

[Sketcher] Apply knot constraints by parameter

Hopefully this will allow directly applying constraints on knots.

[Sketcher] Disable some knot updating

[Sketcher] Use center of gravity constraint on knots

[Sketcher] Fix knot COG constraint for periodic splines

[Sketcher] Add start/end point of periodic spline to solver

This removes the trouble of transferring constraints to the underlying knot.

[Sketcher] Support knot constraints on rational B-splines

[Sketcher] Remove virtual from overridden methods in planegcs

Follow 0penbrain's comments

[Sketcher][planegcs] Use `unsigned int` in signatures

Also `size_t` at places

Suggestions by @abdullahtahiriyo
 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
bad4406387 [Sketcher] Reformat some if-else for readability 
Weren't folding right in spacemacs.
This commit can be omitted if undesired.
 2022-11-16 15:35:37 +01:00
wandererfan
59e2aa9189 [TD]fix alignment of section line marks on rotated base view 2022-11-16 08:56:00 -05:00
0penBrain
44c77e5542 [Typo]Sketcher: 'Clone' is the first command of CompCopy, match the tooltip 2022-11-16 14:48:39 +01:00
wmayer
5166ca54c0 Gui: MSVC requires a user-defined destructor of RecentFilesAction 
otherwise the class declaration of Private is needed in the header file
 2022-11-16 12:46:47 +01:00
Yorik van Havre
eb217f7e66 Merge pull request #7526 from paullee0/ArchWall_15_UseAndCreate-ArchSketch-If-Present 
[ArchWall]  Use and Create ArchSketch if add-on is present
 2022-11-16 11:08:11 +01:00
Yorik van Havre
27eb4fdf80 Merge pull request #7786 from Roy-043/Draft-housekeeping-rename-snap-icons 
Draft: housekeeping: rename snap icons
 2022-11-16 09:58:47 +01:00
wmayer
77bae9c9a0 TD: fix memory leaks with raw pointers of GeometryObject 
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
 2022-11-15 16:16:08 -05:00
luz paz
48b8869b42 [skip ci] Add commits to .git-blame-ignore-revs 
Added:  
f02978c1b43bd0201a458ebab2ade8682ef6cc6d  
48365a1df5286c7a5608cd3a5cce0def5e4d5380
 2022-11-15 14:30:28 -06:00
luz paz
2f1ff7928b Part: remove trailing whitespace 2022-11-15 14:19:30 -06:00
luz paz
52af260eb8 [skip ci] Add commits to .git-blame-ignore-revs 
Added: 
5033d112f024d9d535932507e31430e99c30c420  
c1a05eb4618b3293c48577d65a96c3151dfd605f
 2022-11-15 16:17:47 +01:00
luz paz
2d94a99740 TechDraw: remove trailing whitespace 2022-11-15 16:17:22 +01:00
luz paz
be783892bb MeshPart: remove trailing whitespace 2022-11-15 12:45:52 +01:00
wmayer
c5522245fa App: fix memory leak and consistently use Py::asObject() in DocumentObserverPython 2022-11-15 11:04:41 +01:00
wmayer
ea1d29230e Gui: [skip ci] consistently use Py::asObject() in DocumentObserverPython 2022-11-15 11:04:07 +01:00
luz paz
c174e063f3 Mesh: remove trailing whitespace 2022-11-14 21:37:03 -06:00
wandererfan
356faf94da [TD]prevent Complex Section with no Base View 2022-11-14 19:41:12 -05:00
wandererfan
33bee19d81 [TD]add section line marks for simple section 2022-11-14 19:41:12 -05:00
marioalexis
232b27517c TechDraw: Improve and clean up code in some Python classes 2022-11-14 16:40:07 -05:00
wandererfan
1349a7120a [TD]fix handling of multiple pages 
- the routines for retrieving a view's parent page
  did not correctly deal with duplicate page entries
 2022-11-14 16:38:27 -05:00
wandererfan
694aefc197 [Measurement]apply globalPlacement to geometry 2022-11-14 16:38:06 -05:00
wmayer
ecd9b0136d Test: [skip ci] add method clear() to document observers 2022-11-14 19:53:35 +01:00
wmayer
3f2fe95308 App: [skip ci] fix memory leak 2022-11-14 19:42:33 +01:00
Paddle
d6934c0ecd Sketcher: Coincidence constraint: fix error introduced by concentric capability. 2022-11-14 17:39:09 +01:00
wmayer
45bb0289b0 App: implement option to set config key 2022-11-13 19:54:30 +01:00
wmayer
aa0465e162 Gui: fix some clang-tidy warnings: 
* modernize-return-braced-init-list
* modernize-use-equals-default
* modernize-loop-convert
* readability-implicit-bool-conversion
* readability-named-parameter
 2022-11-13 18:43:39 +01:00
wmayer
90ddd187f5 Gui: fix some clang-tidy warnings: 
* readability-braces-around-statements
 2022-11-13 17:42:08 +01:00
wmayer
25ee791786 Gui: [skip ci] fix some clang-tidy warnings: 
* cppcoreguidelines-non-private-member-variables-in-classes
 2022-11-13 17:16:03 +01:00
wmayer
e9017bdf4a clang-tidy: disable 'readability-redundant-access-specifiers' because clang-tidy fails to distinguish between 'public' vs. 'public Q_SLOTS' 2022-11-13 16:50:15 +01:00
wmayer
e0bf6d48d5 Gui: [skip ci] fix some clang-tidy warnings: 
* cppcoreguidelines-special-member-functions
* cppcoreguidelines-explicit-virtual-functions
* readability-inconsistent-declaration-parameter-name
 2022-11-13 16:35:11 +01:00
wmayer
b2f784f1f5 Gui: fix clazy warnings: 
* Wclazy-connect-by-name
* Wclazy-connect-3arg-lambda
 2022-11-13 16:08:46 +01:00
wmayer
3335f03f3b Sketcher: fix clazy warnings: 
* Wclazy-connect-by-name
* Wclazy-unused-non-trivial-variable
* Wclazy-detaching-temporary
 2022-11-13 15:39:27 +01:00
Paddle
cf383d709d Sketcher: Fix element widget repaint delay bug 
Related to https://github.com/FreeCAD/FreeCAD/pull/7567#issuecomment-1304724547
 2022-11-13 07:13:06 +01:00
wmayer
7f104b077b Gui: fix readability-identifier-length 2022-11-12 23:57:14 +01:00
wmayer
e470bdc018 Gui: replace old-style with new-style connect 2022-11-12 21:57:26 +01:00
wmayer
a2a285b7c9 Gui: improve usability of QuantitySpinBox when used as menu item 2022-11-12 18:24:27 +01:00
wandererfan
4774c432c5 [TD]apply review comments from @chennes 
- also delete empty execute method
 2022-11-12 11:35:22 -05:00
wandererfan
edf7d93188 [TD]simplify section hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
ecac894248 [TD]simplify embedded image handling 2022-11-12 11:35:22 -05:00
wandererfan
7e59f3ea30 [TD]simplify embedded file handling 2022-11-12 11:35:22 -05:00
wandererfan
a2976bcfbc [TD]simplify embedded hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
1cf51ec1c3 [TD]fix embedded template file handling 2022-11-12 11:35:22 -05:00
Chris Hennes
74d85eeeaa Addon Manager: Refactor to extract metadata checker 2022-11-11 21:50:16 -06:00
wandererfan
0bf5d67906 [TD]fix vertical alignment of section pieces 2022-11-11 19:37:42 -05:00
wmayer
3eaad09ed1 Gui: implement WorkbenchSwitcher class to encapsulate the parameter details 2022-11-11 22:53:02 +01:00