kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
43,047 Commits 40 Branches 6 Tags
3129bc9a1ef1996a67b093034b41addfa68c121f
Commit Graph

80 Commits

Author SHA1 Message Date
Kacper Donat
f539a38389 PartDesign: Add preview TaskBox to all feature task dialogs 2025-08-07 00:37:46 +02:00
Max Wilfinger
be0c0e7a74 PartDesign: Update UI strings for consistency and correct for new fuctions and typos 
Closes: #22128
 2025-08-04 20:15:04 +02:00
Benjamin Bræstrup Sayoc
e2f018ceeb PartDesign: Use QStringLiteral 2025-02-10 18:34:57 +01:00
wmayer
010a36df30 PD: Add template helper functions to safely access feature or view provider 
In subclasses of TaskFeatureParameters use the new helper functions and check for null pointer. This fixes #15453
 2024-07-18 13:40:08 +02:00
Kacper Donat
988d31bed8 GUI: Add UI for Up To Shape feature 
Add UI for Up To Shape feature and overall refactor of Pad / Pocket.
 2024-06-10 18:05:21 +02:00
wmayer
622e46771e PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
Uwe
f79c66dc33 [PD] Pad/pocket: fix wrong error message 
- the error can also occur when the mode it not UpToFace (ToFirst or ToLast)
- also add note when Reversed checkbox is enabled since this is no obvious (as discussed in the forum)
- also some whitespace unification and include sorting
 2022-12-04 05:37:11 +01:00
Uwe
04e6414458 [PD] TaskExtrudeParameters: simplify code 
to avoid several time the same translatable string
 2022-07-20 03:16:56 +02:00
adrianinsaval
76f5c32574 [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode (#7216) 
* [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode
 2022-07-20 03:13:01 +02:00
Uwe
0eee9221f0 [PD] improve face selection for Pad/Pocket 
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
 2022-07-17 18:35:34 +02:00
Uwe
86f9b4ec1f [PD] fix Pad/Pocket logic issue 
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
 2022-07-17 02:03:35 +02:00
Uwe
34ea32928b [PD] Pad and Pocket: remove unused includes 2022-02-19 17:57:11 +01:00
Uwe
12b0e0dd92 [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
wmayer
62734ca415 PD: PrefQuantitySpinBox now requires an explicit entry name for the parameter group 2022-01-31 16:47:08 +01:00
Uwe
1e9ddc5302 [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
Uwe
26a36f6b75 [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Uwe
c1d3cb5fee [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
b40ab916bc [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
wmayer
c20cfd5db6 PD: code-refactoring of TaskExtrudeParameters 2021-11-27 01:45:08 +01:00
wmayer
87c3b522d0 PD: add enum class to TaskPadParameters to avoid to work with magic numbers 2021-11-26 16:58:59 +01:00
wmayer
26dd3ddeb3 PD: add enum class to TaskPocketParameters to avoid to work with magic numbers 2021-11-26 16:46:58 +01:00
wmayer
a58846c460 PD: create a common base class of TaskPocketParameters and TaskPocketParameters to reduce code duplications 2021-11-26 16:23:45 +01:00
Uwe
a09e18b3bb [PD] better solution for reversed pad/pocket handling 
- let FeatureExtrude set the right direction
- use the UI as once intended: custom vector values are always taken as they are, so reversing a custom direction will not lead to a negation of the custom vector in the UI. The logic is: "take the vector as it is, and when Reversed is on, negate it additionally"
 2021-11-23 04:22:37 +01:00
Uwe
165a09b3ed [PD] fix pad/pocket UI issues 
- update the preview when the direction is changed in the dialog
- don't uncheck the direction viewbox without any reason
- only recompute once
- update the direction information on reversion
- only pocket: add missing code we have in pad (proper code merging will follow the next days)
 2021-11-23 02:48:25 +01:00
wmayer
039422572a PD: [skip ci] fix warning -Wunused-variable 2021-11-17 19:06:35 +01:00
Uwe
cf9e5a3f33 [PD] fix issue 0004785 
- then the profile of a pad/pocket was a face, the direction handling was completely broken
 2021-11-15 15:44:28 +01:00
Uwe
e27270e615 [PD] fix pad/pocket direction issue 
- the info if a custom direction is used, was incorrectly determined by checking a checkbox that only displays the vector value, no matter if it is a custom vector or not
 2021-11-13 04:03:04 +01:00
Uwe
3eed892880 [PD] add feature to set direction for pockets 
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
 2021-11-11 15:55:42 -06:00
Uwe
e6837f8ef2 [PD] fix a typo 
- also some sorting
 2021-11-10 03:26:23 +01:00
0penBrain
9fe6b11d57 [PartDesign] Enable reverse ability for Pocket/UpToFace mode as it makes sense for curved faces 2021-08-17 12:07:02 +02:00
0penBrain
781867b9c2 [PartDesign] Restore 'Reversed' ability into Pocket/2dims mode 2021-08-17 12:07:02 +02:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
donovaly
5978435a27 [PD] allow expression for pocket offset 
- also disable KeyboardTracking for some fields to avoid unnecessary and often time consuming recomputes while typing in
 2020-08-10 13:39:50 +02:00
Zheng, Lei
cd2b7e297c PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
Abdullah Tahiri
fd7d75b309 PartDesign: Extension of Pocket Feature to have two dimensions 
fixes #2915
 2018-01-20 16:15:38 +01:00
wmayer
e68021029d improve UpToFace option of pad/pocket for datum planes 2018-01-06 17:36:14 +01:00
luzpaz
8200c97ed2 Fix Techdraw UI typo found via crowdin + misc. typos 
Ref: https://crowdin.com/translate/freecad/27911/en-eu#6503377
 2017-11-26 15:48:20 +01:00
Kunda
9410e751e9 source typo fixes pt4 (only on py3 merged code) 2017-03-02 13:47:21 +01:00
wmayer
9d52b05888 fix Coverity issues 2016-08-19 22:51:33 +02:00
Mateusz Skowroński
a8d37dabbe QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Alexander Golubev
e8b323ba20 PartDesignGui: small rework to sketch-based task parameters 
This done mostly for thurther unification them with other task
parameters/dialogs.
 2016-04-12 18:12:21 +02:00
Alexander Golubev
9347f66a9e PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Alexander Golubev
5239f3447c PartDesign/Gui: start to unify view providers code 
- Moved all common code for part design features view providers to a base
   class.
 - Move shared code for Sketch based features to newly created
   ViewProviderSketchBased class
 - Add ViewProviderSketchBased to initialization
 - Make Pad and Pocket ViewProviders to use the shared code
 - Minor fixes to TaskFeatureParameters and some derived classes
 2016-04-12 18:12:15 +02:00
Alexander Golubev
984b0dd715 PartDesign/Task{Pad,Pocket}Parameters: massive refactoring 
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
 2016-04-12 18:12:15 +02:00
Alexander Golubev
595f1e19f4 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev
180985cec0 PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
Alexander Golubev
b9983d5d2d PartDesign/Gui/TaskDlgSketchBasedParameters: emhance object hiding/unhiding on reject() 2016-04-12 18:12:14 +02:00
DeepSOIC
220c88edb6 PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
jrheinlaender
12bf1d58f6 Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00
jrheinlaender
dfd27740a9 Some code unification for sketchbased features 2016-04-12 18:11:51 +02:00