Commit Graph

4007 Commits

Author SHA1 Message Date
wmayer
3293f54a50 Gui: help clazy checker with export macro 2022-07-27 01:19:43 +02:00
wmayer
7a4d29e87a Gui: Use new-style syntax of connect()
When fixing clazy issues -Wclazy-fully-qualified-moc-types then old-style syntax of connect() may fail. Thus, replace it with the new-style syntax
2022-07-26 16:32:18 +02:00
0penBrain
b3cbedcc4e Make image scaling command aware of user units (#7222)
* Image: image scaling command is user unit aware ; fixes #6118

- if unitless value entered, InputField uses user choosen base unit
 Before change, always used FC core base unit
 Only applies to GUI user entered values, value changed programmatically still ...
 ... considered in core base unit if applied unitless
2022-07-25 21:17:02 +02:00
wmayer
5782a9429a Fix several clazy issues:
* Returning data of temporary QByteArray [-Wclazy-returning-data-from-temporary]
2022-07-25 00:19:41 +02:00
wmayer
76c993baae Fix several clazy issues:
* Don't call ... on temporary [-Wclazy-detaching-temporary]
2022-07-25 00:18:42 +02:00
wmayer
923ebef729 Fix several clazy issues:
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
2022-07-25 00:04:04 +02:00
wmayer
85bd6b5c6b Fix several clazy issues:
* C++11 range-loop might detach Qt container [-Wclazy-range-loop-detach]
2022-07-24 23:48:37 +02:00
wmayer
25483b78be Fix several clazy issue:
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
2022-07-24 22:29:06 +02:00
wmayer
916c814219 Fix several clazy issue:
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use an empty QLatin1String instead of an empty QStringLiteral [-Wclazy-empty-qstringliteral]
* getter Gui::ProgressBar::canAbort possibly mismarked as a slot [-Wclazy-const-signal-or-slot]
* Missing emit keyword on signal call [-Wclazy-incorrect-emit]
2022-07-24 20:07:04 +02:00
wmayer
fd5558f295 Fix several clazy issue:
* Using copy-ctor but class SbMatrix/SbViewportRegion has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
2022-07-24 19:38:59 +02:00
wmayer
3fddaf4a2f Fix several clazy issues:
* Q_PROPERTY should have either NOTIFY or CONSTANT [-Wclazy-qproperty-without-notify]
* Use Q_ENUM instead of Q_ENUMS [-Wclazy-qenums]
* Add missing a Q_OBJECT macro [-Wclazy-missing-qobject-macro]
* Signal/Slot arguments need to be fully-qualified [-Wclazy-fully-qualified-moc-types]
2022-07-24 19:03:30 +02:00
Uwe
0a67a39065 [Gui] [skip CI] Selection: a formatting style fix 2022-07-22 02:09:25 +02:00
Chrismettal
404b481625 [Stylesheets] Remove whitespace and add "checked" icon style 2022-07-22 02:05:49 +02:00
wmayer
108c64dc46 Gui: fix crash in ViewProviderLink::currentDraggingPlacement() if there is no active dragger 2022-07-19 10:40:32 +02:00
Uwe
c40e476a5b [Gui] remove some more superfluous nullptr checks 2022-07-18 13:15:38 +02:00
Uwe
d2ccbc75c4 [Part] cleanup new preferences Feature
- correct preferences location
- handle preferences packs
- remove unused code
2022-07-18 12:42:26 +02:00
Uwe
d5b227e6a6 [Gui] remove more superfluous nullptr checks 2022-07-18 03:34:22 +02:00
Uwe
bb2b49fb1f [Gui] remove superfluous nullptr checks 2022-07-18 03:17:42 +02:00
wmayer
07ccb73fe7 Partially revert "Remove unused code into GUI" 2022-07-17 12:32:03 +02:00
andrea
7886d3cbf4 Remove unused code into GUI 2022-07-17 03:53:11 +02:00
wmayer
654de93621 Gui: implement mechanism to set a custom icon name or tooltip of a preferences group 2022-07-16 19:27:22 +02:00
wmayer
6d4f22a970 Gui: fix crash in ExpressionCompleter::slotUpdate
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=69931
2022-07-16 18:23:42 +02:00
Uwe
0c5407b63d [Gui] preferences: clarify Part/PD page
- users are confused that we have a preferences page named "Part design" that also defines things for the Part WB. The Wiki is clear that the preferences page is for both, Part and PD, however the UI is not.
This PR makes this clear.
2022-07-16 16:20:36 +02:00
Uwe
b0065c5827 [Gui] preferences: add button to switch gradient colors
- when finding a suitable background color gradient, it is annoying that there is no button to switch the begin/end color of the gradient. With the button one can quickly see the the changes and find a suitable gradient much quicker
2022-07-16 16:05:54 +02:00
wmayer
ab6c75fad9 Core: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 14:04:05 +02:00
wmayer
a8ac45b090 Replace std::ignore with boost::ignore_unused()
According to https://isocpp.org/blog/2016/09/quick-q-stdignore-for-ignoring-unused-variable std::ignore is not supposed to be used for this
2022-07-15 13:15:47 +02:00
wmayer
0140ca6efc Gui: [skip ci] print debug information in GuiNativeEvent::tdx_drv_handler 2022-07-14 16:00:02 +02:00
wmayer
c697f3c159 Gui: [skip ci] improve whitespaces in GuiNativeEvent::tdx_drv_handler 2022-07-14 15:49:36 +02:00
wmayer
b1147c047a Gui: move QuiLoader for MinGW to global namespace 2022-07-14 14:44:56 +02:00
Uwe
0cc0de67b2 [Gui] ViewProviderGeometryObject: fix color and transparency
- fixes the issue reported in
https://forum.freecadweb.org/viewtopic.php?p=609353#p609353
the color and transparency are childs of the material and have to be set as such.

- also some code style fixes done automatically by MSVC
2022-07-13 05:42:21 +02:00
Uwe
f3a986de23 Revert "[Gui] preferences: add button to switch gradient colors"
This reverts commit 535e49f1c16311feed63097934a6175a45498f43.
2022-07-10 02:20:58 +02:00
Uwe
918f1e562a [Gui] preferences: add button to switch gradient colors
- when finding a suitable background color gradient, it is annoying that there is no button to switch the begin/end color of the gradient. With the button one can quickly see the the changes and find a suitable gradient much quicker
2022-07-10 02:19:01 +02:00
Uwe
06157e3e3d [Gui] [skip CI] DlgPreferencesImp: a code style improvement 2022-07-10 00:14:34 +02:00
Uwe
030aba9b92 [Part] [PD] add preferences setting for transparency
- allow to specify the default transparency for new shapes
2022-07-09 23:24:17 +02:00
0penBrain
43772e985c Gui: implement temporary blocker for console observer 2022-07-05 13:35:18 +02:00
0penBrain
077114163a [BUGFIX] Gui: correctly restore message type enabling in report view 2022-07-05 13:35:18 +02:00
0penBrain
1f1551bb5e [BUGFIX] Gui: correctly save and restore warning type enabling in report view 2022-07-05 13:35:18 +02:00
wmayer
b3eca1447d Gui: show thumbnails in file dialog 2022-07-04 14:49:53 +02:00
wmayer
ac2e215119 Gui: make sure to use FileIconProvider in FileDialog and delete it after closing the dialog 2022-07-04 13:17:11 +02:00
wmayer
55828c22c0 Py: make FreeCAD to compile with Py3.11 2022-07-01 17:54:50 +02:00
Uwe
122f5a358a [Gui] [skip CI] update for DlgProjectInformation.ui
- done automatically by Qt Designer
2022-07-01 03:09:50 +02:00
wmayer
0f5725b34a modernize C++: replace boost::function with std::function 2022-06-30 20:31:55 +02:00
wmayer
97f9320bb3 Core: fix minor issues:
+ fix issues found by clang's clazy tool
+ fix cppcoreguidelines-pro-type-member-init
  * Make sure that all class members are initialized in the constructor
2022-06-30 16:31:16 +02:00
wmayer
82a6241fc5 fix (Qt) issues found by clang's clazy tool:
+ -Wclazy-incorrect-emit
+ -Wclazy-strict-iterators
+ -Wclazy-overloaded-signal
+ -Wclazy-qstring-arg
+ -Wclazy-unused-non-trivial-variable
+ -Wclazy-container-anti-pattern
+ -Wclazy-range-loop-reference
+ -Wclazy-const-signal-or-slot
+ -Wclazy-detaching-temporary
+ -Wclazy-qfileinfo-exists
2022-06-29 21:00:54 +02:00
wmayer
8ed913f217 Gui: remove workaround for spnav 0.23 due to build failure with musl libc 2022-06-29 15:19:18 +02:00
wmayer
299c20e918 Gui: get rid of some const_cast 2022-06-28 15:26:02 +02:00
wmayer
2628fb0350 App: fix memory leaks in Enumeration class and simplify code 2022-06-25 18:18:57 +02:00
wmayer
1459fd61a4 cppcoreguidelines-special-member-functions
* disable move constructor and move assignment for several core classes
2022-06-25 17:46:48 +02:00
wmayer
223de8f60f cppcoreguidelines-pro-type-union-access
According to https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ru-pun using union for type-punning is undefined behaviour.
  See also https://en.wikipedia.org/wiki/Type_punning#Use_of_union. Replace it with std::memcpy.
2022-06-25 17:17:04 +02:00
wmayer
d5340a82ab Gui/Mod: replace several reinterpret_cast with static_cast 2022-06-25 11:36:55 +02:00