kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Fix several clazy issues:

Browse Source 
* Returning data of temporary QByteArray [-Wclazy-returning-data-from-temporary]
This commit is contained in:
wmayer
2022-07-25 00:19:41 +02:00
parent 76c993baae
commit 5782a9429a
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Gui/DlgPropertyLink.cpp
View File

@@ -672,8 +672,8 @@ void DlgPropertyLink::accept()
static QTreeWidgetItem *_getLinkFromItem(std::ostringstream &ss, QTreeWidgetItem *item, const char *objName) {
auto parent = item->parent();
assert(parent);
const char *nextName = parent->data(0, Qt::UserRole).toByteArray().constData();
if(!nextName[0])
QByteArray nextName = parent->data(0, Qt::UserRole).toByteArray();
if (nextName.isEmpty())
return item;
item = _getLinkFromItem(ss, parent, nextName);
@@ -1016,13 +1016,13 @@ void DlgPropertyLink::onItemExpanded(QTreeWidgetItem * item) {
if(item->childCount())
return;
const char *docName = item->data(0, Qt::UserRole+1).toByteArray().constData();
QByteArray docName = item->data(0, Qt::UserRole+1).toByteArray();
auto doc = App::GetApplication().getDocument(docName);
if(!doc)
if (!doc)
return;
const char *objName = item->data(0, Qt::UserRole).toByteArray().constData();
if(!objName[0]) {
QByteArray objName = item->data(0, Qt::UserRole).toByteArray();
if (objName.isEmpty()) {
for(auto obj : doc->getObjects()) {
auto newItem = createItem(obj,item);
if(newItem)