André Althaus
3936f49ee2
Fix linter hints
2024-02-28 17:29:59 +01:00
André Althaus
0c70b0bd1e
Refactor the apply function to be virtual public
2024-02-21 15:04:38 +01:00
André Althaus
a89d450a93
Fix crash when canceling the MultiTransform panel while a newly cretated subfeature is edited
...
Before calling the closeSubTask() function from the dialog reject()
function, the slotDeletedObject() is called from the transaction being
aborted. This causes the subFeature pointer to be nullptr and subsequent
apply() functions from the SpinBox widgets to crash.
Before calling apply check if the subFeature is still there.
2024-02-21 14:56:23 +01:00
André Althaus
30f5595e2a
Reformat files with clang-format
2024-02-17 17:13:14 +01:00
André Althaus
cf627f5ce4
Fix apply() method not called consistently
...
The python console commands where not consistenly reported because
the apply function was not called or not implemented.
The function is now called from the base class and also when
a subfeature is closed in MultiTransform.
Some missing properties are also added.
2024-02-17 17:13:14 +01:00
André Althaus
565b83d8fe
Refactor: optimize member access specifiers
...
After refactoring many members have unnecessarily open access specifiers.
This changes as many members as possible to private or protected.
2024-02-17 17:12:59 +01:00
André Althaus
8694874080
Refactor: remove unused functions
2024-02-17 17:12:59 +01:00
André Althaus
f82663cfb0
Refactor: add default member initializers
2024-02-17 17:12:59 +01:00
André Althaus
2076dff79d
Refactor: replace enum with enum class
2024-02-17 17:12:59 +01:00
André Althaus
0b3eb1ae08
Move duplicated code to the base class
...
All pattern sublcasses contain the same code for handling the
feature list. This code is now moved into the base class that handles
the common ui.
The subclasses now only need to call the setupUI/setupParameterUI function
in their constructors and implement the setupParameterUI function
to create their parameter ui into the specified widget.
The MultiTransform also handles it's common ui and the subclasses
can reuse setupParameterUI without code duplication.
2024-02-17 17:12:32 +01:00
André Althaus
03bd548067
Refactor PD Pattern Tasks ui files
...
All files contain the same add/remove buttons and a feature list.
These common elements are moved into the TaskTransformedParameters.ui file.
The same goes for the common OK Button that is used in a MultiTransform.
The ui files for the patterns only contain their distinctive
parameters. And the common ui files contain an empy widget that will
be filled with the respective parameter widgets from the patterns.
2024-02-17 17:11:57 +01:00
Chris Hennes
e0516b393f
Merge pull request #12460 from bgbsww/bgbsww-toponamingMakeElementPipeShell
...
Toponaming/Part: make element pipe shell
2024-02-16 22:54:22 -06:00
mosfet80
749fbb33b9
Gui: remove SoNavigationDragger ( #12409 )
...
Removed SoNavigationDragger files. These files are no longer used in the project
2024-02-16 21:39:28 -06:00
mosfet80
c919ea8666
Gui: remove ProjectView ( #12410 )
...
This class is not used anywhere, remove it.
2024-02-16 21:38:42 -06:00
mosfet80
be71f476a3
removed unused files
2024-02-16 21:36:36 -06:00
bgbsww
0dd2e686ff
Toponaming/Part: Cleanup makeElementPipeShell, add tests, and some delinting
2024-02-16 22:16:58 -05:00
marioalexis
d0d501a34d
Fem: Run option in examples open and run analysis - fixes #11056
2024-02-16 21:01:23 -06:00
Zheng, Lei
8d5f411b22
Toponaming/Part: Transfer makEPipeShell
2024-02-16 21:01:49 -05:00
Chris Hennes
f092531c9a
Merge pull request #12435 from bgbsww/bgbsww-toponamingMakeElementLoft
...
Toponaming/Part: make element loft
2024-02-16 17:07:08 -06:00
bgbsww
634e77498b
Toponaming/Part: Clean and add tests
2024-02-16 14:01:12 -05:00
Zheng, Lei
9e23a3c086
Toponaming/Part: transfer in makELoft
2024-02-16 11:22:29 -05:00
bgbsww
7ae4542884
TopoNaming/Part: cleanups and tests
2024-02-16 11:22:29 -05:00
Roy-043
ebb5fd9351
Merge pull request #12443 from Roy-043/Draft-fix-wrong-selection-after-commands-improved
...
Draft: fix wrong selection after commands (improved)
2024-02-16 11:46:04 +01:00
Roy-043
0beda2c1bd
Draft: fix wrong selection after commands (improved)
...
The previous fix was not correct. Some commands would cause a crash and several files were missed.
Forum topic reporting a crash:
https://forum.freecad.org/viewtopic.php?t=85243
2024-02-16 10:56:10 +01:00
Chris Hennes
01ad6adacc
Merge pull request #12431 from bgbsww/bgbsww-toponamingMakeElementRuledSurface
...
Toponaming/Part: make element ruled surface
2024-02-15 20:55:29 -06:00
bgbsww
98269a5a21
TopoNaming/Part: cleanups and tests
2024-02-15 19:07:19 -05:00
Zheng, Lei
edc3857bdb
TopoNaming/Part: transfer in MakERuledSurface
2024-02-15 19:05:55 -05:00
Chris Hennes
91efafe7e7
Merge pull request #12417 from bgbsww/bgbsww-toponamingLinearize
...
Toponaming/Part: transfer in linearize
2024-02-15 18:02:08 -06:00
Roy-043
b7cadeab00
Merge pull request #12430 from Roy-043/Draft-remove-reapply_diffuse_color-workaround-step-2
...
Draft: remove reapply_diffuse_color workaround step 2
2024-02-15 23:44:52 +01:00
Roy-043
0426622963
Merge pull request #12429 from Roy-043/Draft-gui_line_add_delete.py-is-obsolete
...
Draft: gui_line_add_delete.py is obsolete
2024-02-15 23:44:29 +01:00
bgbsww
04491c32ed
Toponaming/Part: Clean up linearize, add tests, and some delinting
2024-02-15 16:53:01 -05:00
Roy-043
7bb6b89956
Draft: remove reapply_diffuse_color workaround step 2
...
Stuff that was missed in #11946
2024-02-15 22:28:37 +01:00
Roy-043
3f2e8cf0a0
Draft: gui_line_add_delete.py is obsolete
2024-02-15 22:20:53 +01:00
Max Wilfinger
2bb09fe220
added Assembly option to problem template
2024-02-15 15:18:27 -06:00
marioalexis
c1efba0704
Fem: Expose Constraint view provider symbol node to Python
2024-02-15 13:31:20 -06:00
marioalexis
b23c5f6721
Fem: Move Points and Normals properties to base class
2024-02-15 13:31:20 -06:00
Ladislav Michl
f9d892ce01
Assembly: Add ${PYTHON_INCLUDE_DIRS} to CMakeLists.txt
...
Assembly Gui is including <Base/PyObjectBase.h> which in turn
includes <Python.h>, so path to Python includes is needed.
2024-02-15 13:24:15 -06:00
Zheng, Lei
17a01963e0
Toponaming/Part: transfer in linearize
2024-02-15 14:21:32 -05:00
Chris Hennes
93e94d8868
Merge pull request #12414 from bgbsww/bgbsww-toponamingSearchSubShape
...
Toponaming/Part: Add searchSubShape as findSubShapesWithSharedVertex
2024-02-15 12:49:42 -06:00
Max Wilfinger
94f8a3cc6c
add action workflow to generate monthly issue metrics
2024-02-15 12:39:57 -06:00
bgbsww
11075c396f
Toponaming/Part: Add tests for searchSubShape
2024-02-15 12:36:23 -05:00
Ajinkya Dahale
17f5d1d44b
[planegcs][test] Fix issue in arc-B-spline tangent test
...
Correct the size of the knot vector used (described here with knots and multiplicities).
2024-02-15 10:58:41 -06:00
Zheng, Lei
0a1024350c
Toponaming/Part: transfer in searchSubShape
2024-02-15 07:54:22 -05:00
Chris Hennes
456a6b25de
Merge pull request #12405 from bgbsww/bgbsww-toponamingMakeElementDraft
...
Toponaming/Part: Transfer in MakeElementDraft
2024-02-14 21:10:56 -06:00
Chris Hennes
8229ae07ff
Part/Toponaming: Apply clang-format to TopoShapeExpansion
2024-02-14 18:56:38 -06:00
Chris Hennes
cf724a2b0e
Assembly: Add ${COIN3D_INCLUDE_DIRS} to CMakeLists.txt ( #12407 )
...
* Assembly: Add ${COIN3D_INCLUDE_DIRS} to CMakeLists.txt
2024-02-14 18:26:30 -06:00
bgbsww
c6ca3e41b6
Toponaming/Part: Cleanup and test makeElementDraft
2024-02-14 12:20:10 -05:00
Chris Hennes
9f1e51966f
Merge pull request #12360 from FreeCAD/revert-11937-issue_11825
...
Revert "Resolve #11825 - no automatic quantity conversion: App::anyToQuantity"
2024-02-13 19:00:32 -06:00
LemonBoy
38afc1b118
Part Attacher: Implement 1D intersection for attachments ( #12328 )
...
* PD: Implement 1D intersection for attachments
Extract a line from the intersection of two faces.
Closes #6870
* fixup! Use Handle macro
For some reason I don't fully understand yet the CI was failing, let's
see if this fixes the compilation errors.
* fixup! Add missing(?) header
Well, it compiles just fine on my system...
* fixup! Be more specific in error messages
2024-02-13 17:45:01 -03:00
LemonBoy
4484a3f356
Part Grid: Exclude the grid group from bbox computation ( #12349 )
...
Fixes the problem where View_FitAll would compute a huge bounding box
when the infinite grid is enabled.
Closes #11570
Co-authored-by: wwmayer <werner.wm.mayer@gmx.de >
2024-02-13 17:42:51 -03:00
