Commit Graph

30999 Commits

Author SHA1 Message Date
wmayer
3f2fe95308 App: [skip ci] fix memory leak 2022-11-14 19:42:33 +01:00
Paddle
d6934c0ecd Sketcher: Coincidence constraint: fix error introduced by concentric capability. 2022-11-14 17:39:09 +01:00
wmayer
45bb0289b0 App: implement option to set config key 2022-11-13 19:54:30 +01:00
wmayer
aa0465e162 Gui: fix some clang-tidy warnings:
* modernize-return-braced-init-list
* modernize-use-equals-default
* modernize-loop-convert
* readability-implicit-bool-conversion
* readability-named-parameter
2022-11-13 18:43:39 +01:00
wmayer
90ddd187f5 Gui: fix some clang-tidy warnings:
* readability-braces-around-statements
2022-11-13 17:42:08 +01:00
wmayer
25ee791786 Gui: [skip ci] fix some clang-tidy warnings:
* cppcoreguidelines-non-private-member-variables-in-classes
2022-11-13 17:16:03 +01:00
wmayer
e9017bdf4a clang-tidy: disable 'readability-redundant-access-specifiers' because clang-tidy fails to distinguish between 'public' vs. 'public Q_SLOTS' 2022-11-13 16:50:15 +01:00
wmayer
e0bf6d48d5 Gui: [skip ci] fix some clang-tidy warnings:
* cppcoreguidelines-special-member-functions
* cppcoreguidelines-explicit-virtual-functions
* readability-inconsistent-declaration-parameter-name
2022-11-13 16:35:11 +01:00
wmayer
b2f784f1f5 Gui: fix clazy warnings:
* Wclazy-connect-by-name
* Wclazy-connect-3arg-lambda
2022-11-13 16:08:46 +01:00
wmayer
3335f03f3b Sketcher: fix clazy warnings:
* Wclazy-connect-by-name
* Wclazy-unused-non-trivial-variable
* Wclazy-detaching-temporary
2022-11-13 15:39:27 +01:00
Paddle
cf383d709d Sketcher: Fix element widget repaint delay bug
Related to https://github.com/FreeCAD/FreeCAD/pull/7567#issuecomment-1304724547
2022-11-13 07:13:06 +01:00
wmayer
7f104b077b Gui: fix readability-identifier-length 2022-11-12 23:57:14 +01:00
wmayer
e470bdc018 Gui: replace old-style with new-style connect 2022-11-12 21:57:26 +01:00
wmayer
a2a285b7c9 Gui: improve usability of QuantitySpinBox when used as menu item 2022-11-12 18:24:27 +01:00
wandererfan
4774c432c5 [TD]apply review comments from @chennes
- also delete empty execute method
2022-11-12 11:35:22 -05:00
wandererfan
edf7d93188 [TD]simplify section hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
ecac894248 [TD]simplify embedded image handling 2022-11-12 11:35:22 -05:00
wandererfan
7e59f3ea30 [TD]simplify embedded file handling 2022-11-12 11:35:22 -05:00
wandererfan
a2976bcfbc [TD]simplify embedded hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
1cf51ec1c3 [TD]fix embedded template file handling 2022-11-12 11:35:22 -05:00
Chris Hennes
74d85eeeaa Addon Manager: Refactor to extract metadata checker 2022-11-11 21:50:16 -06:00
wandererfan
0bf5d67906 [TD]fix vertical alignment of section pieces 2022-11-11 19:37:42 -05:00
wmayer
3eaad09ed1 Gui: implement WorkbenchSwitcher class to encapsulate the parameter details 2022-11-11 22:53:02 +01:00
wmayer
e6a8533fa8 Gui: simplify code to handle workbench selector
+ replace three boolean parameters with a single string parameter
+ refactor DlgGeneralImp::saveSettings/loadSettings
+ handle visibility of corner widgets
2022-11-11 22:53:02 +01:00
wmayer
2e1feaa78e Gui: [skip ci] fix several warnings reported by GH actions 2022-11-11 22:53:02 +01:00
wmayer
5bf7199804 Gui: replace old-style connect() with new-style 2022-11-11 22:53:02 +01:00
wandererfan
101a25185a [TD]Section dialog gui tweaks 2022-11-11 08:53:29 -05:00
Uwe
1191a19de4 [Mesh] Feature*: remove unused includes
- also some sorting
2022-11-11 14:02:49 +01:00
wmayer
bc3c81e138 Gui: fix warnings reported by GH Actions:
* Fix trailing spaces
* Replace tabs
* Mark constructors with one argument explicit
* Fix typos
* Include FCGlobal.h to fix parsing errors
2022-11-11 09:56:43 +01:00
vernzimm
1c6aa45fd6 Gui: Add default JPEG save quality (#7737)
* Update SoFCOffscreenRenderer.cpp

Set jpg screenshot capture to 100% quality vs qimage defaulting to -1

* Add default quality to JPG export

Fixed original version and use quality 90% as compromise between file size and fidelity.
2022-11-10 22:49:28 -06:00
Uwe
7a26e69405 [skip ci] [Gui] NaviCube: fix warning about too short variable name
- also some whitespace unification
2022-11-11 05:16:18 +01:00
Uwe
49c9d6ada8 [skip ci] [.clang] set pointer style to left
- since we added the .clang-format file we used Left for the pointer asterisk. It is annoying to get now all the time automatic diffs because the -clang file uses Right.
2022-11-11 05:12:47 +01:00
Uwe
4bade5d96b [Gui] NaviCube: fix rotation to backside
- when pressing the "dot" besides the NaviCube, the rotation to the backside was not in the center thus the view jumped
2022-11-11 04:58:20 +01:00
Chris Hennes
2ff8d5b1a4 Addon Manager: Ensure check message closes 2022-11-10 21:35:46 -06:00
Chris Hennes
74a8d3deec Addon Manager: Refactor to extract connection check GUI 2022-11-10 21:09:47 -06:00
Uwe
0ed3e6d0fe [.clang] use line break after case
- we used in the past line breaks after a case statements to better overview. This should be kept.
2022-11-11 04:06:21 +01:00
Uwe
633279663d [Path] PathSimulator: remove unused includes
- also some sorting
2022-11-11 04:04:33 +01:00
Uwe
083c6054a5 [skip ci] [Github] add file endings 2022-11-11 03:47:00 +01:00
Uwe
356ae47332 [Mesh] Imp* - end: remove unused includes
- also some sorting
2022-11-11 03:34:31 +01:00
wmayer
439a2c65cf Gui: don't use '_tooltip' as argument name because it's already used for a class member 2022-11-11 01:25:33 +01:00
wandererfan
9a07c52aff [TD]fix XDirection rotation of simple sections 2022-11-10 19:19:22 -05:00
wandererfan
bc0c95259c [TD]fix oblique section line ends 2022-11-10 19:19:22 -05:00
wandererfan
48996a15a9 [TD]Section dialogs minor fixes
- make simple and complex dialogs consistent
- fix translation contexts
2022-11-10 19:19:22 -05:00
wandererfan
b8eee9c0f2 [TD]fix fail in calculating section line length 2022-11-10 19:19:22 -05:00
wmayer
6e6e42f696 Gui: [skip ci] fix several warnings reported by GH actions 2022-11-10 23:52:29 +01:00
wmayer
2f41f652c8 Gui: fix regression: show commands of selected category in Toolbar tab 2022-11-10 23:20:18 +01:00
wmayer
07224605dc Gui: use new-style connect and add curly braces to improve readability 2022-11-10 23:20:18 +01:00
wmayer
ee4e64328e Gui: restore fixes of DlgKeyboard.ui and DlgToolbars.ui and fix build failure 2022-11-10 23:20:18 +01:00
Zheng, Lei
2138189f8e Gui: do not remove ending puncuation when clean action title 2022-11-10 23:20:18 +01:00
Zheng, Lei
ae8ba0de3d Gui: fix shortcut context handling in ShortcutManager
Related #6097

Qt ignores shortcut of actions in invisible toolbar, but not for actions
in a hidden menu action of menu bar, which is likely a Qt bug. The
desired behavior should be that of toolbar actions, so that actions
belong to different workbenches can have the same shortcut without
conflict.

This commit works around this inconsistency by ensuring only the active
actions are added in menu bar. In addition, all active actions will be
added to a zero sized child widget of the main window, which ensures the
shortcuts of these actions being active regardless whether the action is
in toolbar or menu bar, visible or not.
2022-11-10 23:20:18 +01:00