Commit Graph

31768 Commits

Author SHA1 Message Date
Syres916
eaf49f82ee [App] Use consistent unit schema names (#21355)
* [Start] ensure user's preferred unit schema is retained after restart of application

* [App] use consistent schema names throughout the application

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [Start] Revert commit 2eea421

in preference to PR #21466

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-26 17:33:45 +02:00
WandererFan
009754581e [TD] fix small angle dims (fix #21114) (#21208)
* [TD]fix handling of very small angle dimensions

- also remove test for too small format specifier

* [TD]lint messages

* [TD]apply review comments.
2025-05-26 17:19:19 +02:00
PaddleStroke
d013890bf6 TechDraw: richannotation : Fix white text issue (#21515)
* TechDraw: richannotation : Fix white text issue

* Update QGIRichAnno.cpp
2025-05-26 17:18:21 +02:00
Benjamin Bræstrup Sayoc
41111c5ee9 TechDraw: fix state handling of dimensions
- Positioning was calculated using `boundingRect` while `transformOriginPoint` was set according to `tightBoundingRect`, causing mismatch when `QGIDatumLabel` contains more than text (eg. shapes around text). Now `transformOriginPoint` and positioning calculated according to `tightBoundingRect`, and setting `transformOriginPoint` of `QGIDatumLabel` are handled by itself. This fixes an issue where the gap between dimension lines and text varied depending on dimension's angle.
- `m_lineWidth` was set in multiple locations, causing confusion and bug introduction
- If `X` or `Y` property changed, the remaining changed properties were not handled due to using `if else` rather than `if` for property change checking. This became an issue due the above mentioned simplification of `m_lineWidth` setting: if `X` or `Y` had changed (upon document restore).
- Center position was uneededly saved in variables `posX` and `posY` when it could be calculated on demand using `tightBoundingRect`. Removing this uneeded state simplfies code and lowers the risk of bug introduction due to lack of updating state.
2025-05-26 17:18:04 +02:00
tarman3
07c774b872 CAM: Added property CycleTime to old Array 2025-05-26 12:13:03 +03:00
tetektoza
81830d21db BIM: Parse Classification in IFC correctly for conversion/type assign 2025-05-26 10:24:34 +02:00
Furgo
0e22d16a56 BIM: add first iteration of unit tests 2025-05-26 10:23:24 +02:00
Furgo
e9d0f287f2 BIM: refactor to reduce code duplication and improved readability 2025-05-26 10:23:24 +02:00
Furgo
bdbcdef87f BIM: remove command now removes windows from walls
Fixes: #21551
2025-05-26 09:53:21 +02:00
Furgo
796ae9805f BIM: add test for window removal from walls 2025-05-26 09:53:21 +02:00
Paul Lee
fec3d96acc [ArchWall] Fix SetLength Error When Base Sketch has External Geom
fix #21357 error message problem

Github issue and discussion:
https://github.com/FreeCAD/FreeCAD/issues/21357
https://github.com/FreeCAD/FreeCAD/issues/21357#issuecomment-2886010914

ArchWall return error when Base Sketch has external(projected) geometry.

External projected geometry has TNP-problem, until the feature is TNP-tolerant,  support of external(projected) geometry at ArchWall is not encouraged. The reported error message is fixed in the meantime in this PR.
2025-05-26 09:49:36 +02:00
Benjamin Bræstrup Sayoc
4e95213e0a TechDraw: centralize usertype constants 2025-05-25 20:42:02 +02:00
Lawrence Woestman
37f8176430 CAM: added command line arguments for line number start, increment
Also added command line arguments for listing tools in preamble
2025-05-24 18:43:11 -07:00
jffmichi
b77f63c7c6 CAM: sort locations for all drilling operations 2025-05-25 00:27:03 +02:00
mosfet80
68aaa50100 Sketcher: Remove unused variables (#21504)
removed unused variables
2025-05-25 00:19:46 +02:00
David Carter
d68d5940bf Materials: Correct model spelling errors 2025-05-25 00:14:08 +02:00
wandererfan
8289f84e0c [TD]fix hidden vertex not created 2025-05-24 14:57:44 -04:00
wandererfan
4d3d0d78e4 [TD]fix vertex visible attribute not restored 2025-05-24 14:57:44 -04:00
wandererfan
053e745f44 [TD]return Qt or conventional coords 2025-05-24 14:57:44 -04:00
Roy-043
66e7940dfd Draft: remove 'CTRL to snap' from tooltips (#20619)
The 'CTRL to snap' option is not the default, it should therefore not be included in the tooltips.

Additionally:
* Some obsolete info was removed.
* Some minor improvements,
2025-05-24 18:55:47 +02:00
Roy-043
7740eca0c0 Draft: Revise close task panels on doc close solution (#21546)
Use built-in feature to close the task panels. See #21253.
2025-05-24 10:25:40 +02:00
Alfredo Monclus
8a4501c900 PD: hole safeguard countersink depth calculation against possible math issues 2025-05-24 02:05:06 -06:00
David Carter
13b7991705 Materials: External interface refinements (#21524) 2025-05-24 08:25:44 +02:00
longrackslabs
0ef4ee0367 Draft: Fix typo in arc input hint ("staring" → "starting") 2025-05-24 08:24:32 +02:00
Alfredo Monclus
432e20c60c PD: hole calculate counterbore and countersink if no standards are available 2025-05-23 20:51:35 -06:00
Alfredo Monclus
91d2b25dfd PD: hole fix head custom values checkbox not appearing 2025-05-23 20:51:28 -06:00
Alfredo Monclus
555dfc6ccb PD: hole: calculate depth of countersink and adjust other parameters accordingly when changed 2025-05-23 17:36:26 -06:00
Alfredo Monclus
808cb6ab21 PD: hole: fix standarized head cuts not working in metric regular sizes 2025-05-23 14:15:44 -06:00
Benjamin Nauck
a82ab42721 Merge pull request #21289 from tetektoza/fix/fix_transparency_doors_windows_ifc
BIM: Change from RGBT to RGBA for IFC
2025-05-23 14:10:47 +02:00
paul
990109fe8c BIM - ArchWindow - Add AutoNormalReversed property 2025-05-23 12:08:33 +02:00
tetektoza
756d60d3df BIM: Additional improvements for Activate button in BIM Views
This patch introduces a few things:
- changes Activate button to be first in the list
- puts it in bold text, also adding (Default) to point it is default
  action
- removes all of the hiding logic upon double click and leaving Activate
by default to be called after double-clicking a BuildingPart
2025-05-23 12:06:55 +02:00
Roy-043
9a505c36c4 BIM: Revise close panel on doc close solution (#21302)
* BIM: Revise close panel on doc close solution

Use built-in feature to close the task panels. See #21253.

* Keep self.doc
2025-05-23 11:49:55 +02:00
tetektoza
c528ce29eb BIM/Help: Access DockWidgetArea QFlag enum correctly
Currently, for both Help and BIM Views panels we can get a traceback
about incorrect casting if we move the panel.

This is because the QFlag of DockWidgetArea that is being passed, as it is not
able to be parsed down to an int. Most probably some historical change
either in Qt or FC.

This error also caused to not write current BIM Views/Help panel setup
to config, resulting in the position being resetted every run.
2025-05-23 11:47:10 +02:00
Krzysztof
a804002f36 Draft: Implementation of 'Align to face' checkbox in Hatch task panel (#21332) 2025-05-23 09:42:19 +00:00
tetektoza
8f8ed52764 BIM: Add missing IFC attributes for both Pipe and Rebar
As the title says - those two tools missed IFC attributes, since they
used different path of initialization than other components, so this
patch makes sure we initialize those properties properly.
2025-05-23 10:50:47 +02:00
Furgo
13924c0469 BIM: allow deleting locked IFC properties when needed 2025-05-23 10:18:36 +02:00
Furgo
f20d00c570 Revert "BIM: add workaround for Draft workbench test mockup"
This reverts commit 5be803863e7552f7cb96998cd682edd3c556b4be.
2025-05-23 10:14:40 +02:00
Furgo
9b83b4b051 BIM: add workaround for Draft workbench test mockup 2025-05-23 10:14:40 +02:00
Furgo
f21fcf4f26 BIM: add basic error checking in unit test, make extrusion a solid 2025-05-23 10:14:40 +02:00
Furgo
0ae1a33e73 BIM: add area calculation unit tests for Arch Components 2025-05-23 10:14:40 +02:00
Furgo
3d07b8e826 BIM: support curved vertical edges for area calculation 2025-05-23 10:14:40 +02:00
Furgo
175d47e5da BIM: refactor component area calculation into a helper class 2025-05-23 10:14:40 +02:00
Furgo
5d77bb7429 BIM: correct planar check to avoid vertical/horizontal misclassification 2025-05-23 10:14:40 +02:00
Furgo
22f329c140 BIM: add support for bsplines in Arch structures 2025-05-23 10:14:40 +02:00
jffmichi
4fd4d0434c CAM: prevent dogbones between two travel moves 2025-05-23 03:34:36 +02:00
pre-commit-ci[bot]
c4d32ea3f9 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2025-05-22 23:23:27 +00:00
Andrea
64f93838df . 2025-05-23 01:18:58 +02:00
pre-commit-ci[bot]
50eeb8b7bb [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2025-05-22 23:17:56 +00:00
Andrea
15ee156b23 CAM: use std::numbers pi definition
se std::numbers pi definition
2025-05-23 01:11:37 +02:00
FC-FBXL5
8de45658e9 TechDraw: Update LineGroup.csv (#21513)
: -> ;

It seems a colon was mistakenly used instead of a semicolon, this has been corrected.
2025-05-22 22:45:22 +02:00