Commit Graph

22 Commits

Author SHA1 Message Date
marcuspollio
4c2a0be22f BIM: cleanup license and add SPDX 2025-04-04 17:46:58 +02:00
Paul Lee
27732fdf50 [ArchWall] Fix Regression Single-edge Wall w/ Multi-Material
Forum Discussion
- https://forum.freecad.org/viewtopic.php?t=93610&start=10#p806296

Github Issues
- https://github.com/FreeCAD/FreeCAD/issues/19147#issuecomment-2607946858
2025-01-27 14:29:04 +01:00
Roy-043
225241e673 Clean up
The recompute and the `try` structure are no longer required.
2025-01-16 11:53:55 +01:00
Roy-043
88a6eecdbb BIM: ArchWall use moveGeometry to move sketch point
The movePoint function is no longer available in V1.1.
2025-01-16 11:53:55 +01:00
Paul Lee
5e99383934 [ArchWall] Fix Regression - EnsureBase prevent creation without Base
Refer to discussion at -
https://github.com/FreeCAD/FreeCAD/pull/18651
https://github.com/FreeCAD/FreeCAD/issues/16409

Wall should do without Base. Base validity tested in execute() prevented the desired and documented behaviour.

EnsureBase() is remarked out in execute() and to be run in getExtrusionData().  With this fix, if there is no Base, or Base is not valid, Wall would be created as declared.
2025-01-06 11:49:50 +01:00
luzpaz
2902ea4995 Trim lines ending with superfluous whitespace 2024-12-22 08:50:37 -05:00
wmayer
4666fe8a5b Arch/Draft: Fix transparency vs. alpha issues
Fix #18295
2024-12-09 11:50:14 +01:00
Paul Lee
578640381a [ArchWall] Further fix dumps()
Noted simply super().dumps() won't work as original method return dumps information.
2024-12-03 15:19:11 +01:00
Yorik van Havre
923297bc61 BIM: ensure the Base has the correct type (#17264)
* BIM: ensure the Base has the correct type - fixes #16409

* BIM: refactor according to chenne's comment
2024-12-02 10:44:11 -06:00
Paul Lee
219a26d080 [ArchWall] loads() dumps() to call parent methods 2024-11-29 10:28:53 +01:00
Paul Lee
9a4c3d0571 [ArchWall] Variant PropertrySet Support in ArchSketch
Now, user can create :

-  Variant Layout / combination of ArchWall, CurtainWall, Slab based on same ArchSketch, with another PropertySet
-  Variant Properties / layer of ArchWall on same ArchSketch with different Width, Offset, Material, Height etc. to create Layers, Composite walls etc.
   (Layout, Layer, Combination, Composite, Elemented etc.)

FreeCAD Forum Discussion:
- https://forum.freecad.org/viewtopic.php?p=784622#p784622
- https://forum.freecad.org/viewtopic.php?p=785583#p785583
2024-11-29 10:28:53 +01:00
Yorik van Havre
f4d213d299 BIM: Only dusplay context menu items when in BIM WB - fixes #17043 2024-11-22 11:48:03 -05:00
paul
2943a6ad10 ArchWall : Bug Fix Length Property Accuracy Problem (#17496)
* ArchWall : Bug Fix Length Property Accuracy Problem

See https://github.com/FreeCAD/FreeCAD/issues/15794

* [ArchWall] Fix regression with multi-material and align center

* ArchWall - Regression Typo

---------

Co-authored-by: Yorik van Havre <yorik@uncreated.net>
2024-11-11 17:26:05 +01:00
Roy-043
3608ed2613 BIM: Compatibility fix for walls based on wire or face with -Z normal
In V1.0 the handling of wall normals has changed. As a result existing walls with their Normal set to [0, 0, 0], based on wires or faces with a shape normal pointing towards -Z, would be extruded in that direction instead of towards +Z as before. To avoid this their Normal property is changed to [0, 0, 1].
2024-10-04 13:54:17 +02:00
paul
664f4d5655 [ArchWall_Draft-OffsetWires] Bug-fix Ellipse Support (#16038)
* [ArchWall_Draft-OffsetWires] Bug-fix Ellipse Support

Fixed bug/regression in ArchWall/Draft-OffsetWires ellipse support.

FC Forum Discussion
- https://forum.freecad.org/viewtopic.php?p=777965#p777897

* Update offsets.py

Typo

* L347 - trailing whitespace after comma
2024-08-26 18:03:21 +02:00
Roy-043
1979f47714 BIM: Fix calculation of wall blocks
At the corners of the base wire the joint width was wrongly added.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=89504
2024-08-01 11:04:05 +02:00
Roy-043
4f37e3738d BIM: Fix handling of Wall normal (#14540)
The `Part.makeLine()` code is unnecessary and also risky as length can be zero. See first image in #14524.
2024-06-13 15:20:25 +02:00
paullee
e563b4ccb7 [ArchWall] Add switch 'ArchSketchData' to use ArchSketch Data or not 2024-06-06 14:04:14 +02:00
paullee
6f75dfd061 [ArchWall] Disable Input (ReadyOny) if Base (ArchSketch) Provided
To avoid confusion, attributes e.g. Align, Width, Offset, Override (Align/ Width/ Offset)
would be disabled, if Base object is ArchSketch which provided the above information

FC Forum Discussion :  https://forum.freecad.org/viewtopic.php?t=87721&start=30#p763761
2024-06-06 14:04:14 +02:00
paul
0261ab8977 [ArchWall] Add Offset per Edge Feature (#14277)
* [ArchWall] Add Offset per Edge Feature

ArchWall.py - Add Override Offset property & ground work for Multi-Layer Wall
Offsets.py - Add offset per edge support to ArchWall

Forum Discussion :
- https://forum.freecad.org/viewtopic.php?p=759634#p759634

* [ArchWall]  Fix bug found by unit test

'off' is no longer used, 'offsets' is used.
2024-05-28 10:39:21 +02:00
Yorik van Havre
4b18e2f2ae BIM: Reapplied #13648 2024-05-22 10:58:23 +02:00
Yorik van Havre
f21a3b3ec9 BIM: Renamed Arch to BIM 2024-05-16 17:23:10 +02:00