Commit Graph

22143 Commits

Author SHA1 Message Date
wmayer
4dd32ce143 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
44f42a8e2c LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
donovaly
e727cd3754 also avoid leading newlines 2020-07-26 19:47:25 -04:00
donovaly
d7ee728be3 assure the translation
- also fix a typo
2020-07-26 19:47:25 -04:00
donovaly
5e6e03b6fa improve coding style 2020-07-26 19:47:25 -04:00
donovaly
2b33e7776d [TD] get rid of trailing newlines
as discussed with luzpaz in https://github.com/FreeCAD/FreeCAD/pull/3735
there shouldn't be trailing newlines in translated strings.

- Moreover fix the logic of the output dialog text
2020-07-26 19:47:25 -04:00
wandererfan
21becb4e7a [TD]remove obsolete QPointF (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
cb90b6a112 [TD]remove obsolete QGraphicRectItem (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
04f1842308 [TD]remove obsolete QGraphicsSVGItem (LGTM) 2020-07-26 19:45:49 -04:00
wandererfan
9dac347fc7 [TD]fix Dim selection fails to clear prev selection 2020-07-26 19:45:49 -04:00
Bernd Hahnebach
a6df94e37f FEM: show result, make it possible to use the menu and icon if there is a pure result object in a document. 2020-07-26 23:40:21 +02:00
wmayer
48f9085746 LGTM: [skip ci] fix: Local variable hides global variable
A local variable or parameter that hides a global variable of the same name.
This may be confusing. Consider renaming one of the variables.
2020-07-26 19:30:24 +02:00
donovaly
8dc95874a2 [TD] add 2 shortcuts for dimensions
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=48980
2020-07-26 11:22:06 -04:00
wmayer
dc65b055e5 LGTM: [skip ci] fix: Empty branch of conditional
An empty block after a conditional can be a sign of an omission and can decrease maintainability of the code.
Such blocks should contain an explanatory comment to aid future maintainers.
2020-07-26 15:49:14 +02:00
wandererfan
8dac7e4666 [TD]fix misaligned PAT hatch on section 2020-07-25 10:30:13 -04:00
wmayer
584a1bf442 LGTM: [skip ci] fix: Resource not released in destructor 2020-07-25 14:48:59 +02:00
wmayer
16edad7afd LGTM: [skip ci] fix: Accidental rethrow 2020-07-24 20:57:14 +02:00
wmayer
d300d148c9 LGTM: [skip ci] fix: Function declared in block 2020-07-24 20:37:17 +02:00
wmayer
9a1a06c94b LGTM: [skip ci] fix: Duplicate include guard 2020-07-24 20:22:00 +02:00
wmayer
eff0655d83 LGTM: [skip ci] fix: Wrong type of arguments to formatting function 2020-07-24 19:58:48 +02:00
wmayer
47d570716c LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
d5d7d65bfc LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
SurajDadral
75ba0b8a77 Add Mark property to ArchRebar object
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=23&t=44580&p=418377#p418630
And required for reinforcement drawing/dimensioning.
2020-07-24 13:50:29 +02:00
luz paz
752f84046c Crowdin: Edits based on feedback from translators [skip-ci]
https://crowdin.com/translate/freecad/27911/en-en#6581566  
https://crowdin.com/translate/freecad/6766/en-en#6584432  
https://crowdin.com/translate/freecad/549/en-en#6578092
2020-07-24 13:49:59 +02:00
vocx-fc
3c35504deb Arch: improve import and export IFC preferences pages
Some tooltips are made more readable by adding newlines.

For `IFC import`, better tooltip for the `Number of cores` option;
also the `Replace 'Project'...` option.

For `IFC export`, better tooltip for the `Export type`;
also `IFC file units`.
Also add `General options` in case other options are added.
2020-07-24 13:48:44 +02:00
wmayer
6ab4bb5a18 smesh: [skip ci] port Netgen plugin to v6.2 2020-07-23 16:22:54 +02:00
Mark Ganson TheMarkster
690652a57e coverity cid 192591 (fix typo) 2020-07-23 13:55:58 +02:00
Mark Ganson TheMarkster
0491fa4ab9 coverity issue cid 305102 2020-07-23 13:55:32 +02:00
carlopav
1911453aa1 Arch: touch Axis when key property change
This allow experimental wall to auto align to the new axis position.
2020-07-23 13:54:18 +02:00
luz paz
f20ab1765f Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
Jean-Marie Verdun
4851947bc0 Remove unnecessary pre-processor directive
Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
Jean-Marie Verdun
0b1af7c838 Add App::Link support to Cloud module
ONLY enabled if the Cloud Module is compiled into FreeCAD
    ALL files must be saved into a Cloud Based storage
    Add a Signal to the PropertyLink to enable support of external storage
    Put the Assembly Document as active document

Signed-off-by: Jean-Marie Verdun <jmverdun3@gmail.com>
2020-07-23 13:47:21 +02:00
wmayer
cb2099aa6b Part: optimize ViewProviderPartExt::getNormals 2020-07-22 20:33:17 +02:00
wmayer
87fcebd538 smesh: [skip ci] port Netgen plugin to v6.2 2020-07-22 20:32:34 +02:00
wmayer
3e86f98d7a smesh: [skip ci] port Netgen plugin to v6.2 2020-07-22 17:35:55 +02:00
Bernd Hahnebach
886d9656f0 FEM: solver frame work, beside dir fix 2020-07-21 22:12:16 +02:00
Bernd Hahnebach
d30862b7ba FEM: unit tests, fix z88 for installed FC 2020-07-21 20:54:30 +02:00
sliptonic
7202749809 Merge pull request #3709 from etrombly/3dSurface
[Path] fix two never ending while loops in PathSurfaceSupport
2020-07-21 10:58:48 -05:00
Bernd Hahnebach
d30e4a5088 Arch: import ifc, use the new layer make command since the dereciated one does not create layers on import 2020-07-21 15:18:41 +02:00
wmayer
f32248997e Coverity: [skip ci] Dereference before null check
Remove logically dead code because 'pcActiveBody' cannot be null at this stage
2020-07-21 14:33:54 +02:00
wmayer
5584c36c1b Coverity: [skip ci] Dereference before null check 2020-07-21 14:31:09 +02:00
wmayer
617668a7f2 Coverity: [skip ci] Bad use of null-like value 2020-07-21 12:23:10 +02:00
Bernd Hahnebach
6b4a5066a4 FEM: calculix solver, fix result mesh purging on multiple result obj. 2020-07-21 07:27:42 +02:00
Sudhanshu Dubey
e3e3781253 FEM: unit tests, add tests for cantilever examples 2020-07-21 00:06:08 +02:00
Sudhanshu Dubey
103f87ca64 FEM: unit tests, add test for node load example 2020-07-20 23:52:28 +02:00
Sudhanshu Dubey
b51f966c2a FEM: unit tests, add test for edge load calculation example 2020-07-20 23:52:13 +02:00
Sudhanshu Dubey
052448e61f FEM: examples, add node load calculation example 2020-07-20 23:52:05 +02:00
Sudhanshu Dubey
2306afbb56 FEM: examples, add edge load calculation on twisted hollow profile 2020-07-20 23:51:58 +02:00
Bernd Hahnebach
6291471e0a FEM: fix unit test after coverity test 2020-07-20 23:11:18 +02:00
Bernd Hahnebach
c47eaa36e2 FEM: coverity, some left outs 2020-07-20 23:10:47 +02:00