Commit Graph

18986 Commits

Author SHA1 Message Date
Aapo
51194d67d5 [TD] Hotfix for Dimension label Arbitrary value regression in DrawViewDimension.cpp 2021-02-25 10:28:42 +01:00
wmayer
8be8c08b47 FEM: [skip ci] fixes #0004405: Using PartDesign axis / plane as direction for constraints 2021-02-24 23:59:10 +01:00
wmayer
7a56781285 FEM: [skip ci] support Line and Plane objects in Constraint::getDirection() 2021-02-24 23:53:15 +01:00
wmayer
ab0a660963 FEM: [skip ci] connect onButtonDirection() slot with clicked() signal 2021-02-24 21:55:51 +01:00
wmayer
a95cd106bb PD: [skip ci] remove invalid static_cast 2021-02-24 20:12:26 +01:00
Yorik van Havre
5ba28fa7ff Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
bc5311b3ee PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
2389b4779a PD: [skip ci] code refactoring
Move adding offset to face from getUpToFace() to addOffsetToFace()
2021-02-24 16:08:03 +01:00
sliptonic
a6fd02cb04 Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
fa5dc51491 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
315d4a8026 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
b2283c5430 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
85bd1bf639 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
f7c50a4d75 fix string formatting 2021-02-23 18:59:04 -06:00
Yorik van Havre
3ef181a751 AddonManager: Fixed missing WB icons 2021-02-23 18:01:04 +01:00
wmayer
eed7357674 PD: [skip ci] AddressSanitizer: stack-use-after-scope
Axis() returns a tmp. object and thus we cannot use a const reference to get its Location() method
2021-02-23 13:57:51 +01:00
Yorik van Havre
d90c1ff72f Merge branch 'master' into Draftutils_BugFixes_01 2021-02-23 11:45:23 +01:00
Yorik van Havre
4dd234bb22 Merge pull request #4506 from berndhahnebach/bhbdev242
Arch: ifc export, save guid to obj attribute
2021-02-23 11:43:02 +01:00
Yorik van Havre
55d37935d9 Merge pull request #4508 from donovaly/TD-BalloonHotfix
[0.19] [TD] fix balloon dragging regression
2021-02-23 11:41:58 +01:00
wmayer
482884cfd4 PD: [skip ci] fix regression caused by e0d07257b7
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
2021-02-23 11:20:45 +01:00
Abdullah Tahiri
7659bb0dae Sketcher: Work-around for expression engine failure to calculate dependencies
=============================================================================

THIS IS A WORK-AROUND NOT TO DELAY 0.19 RELEASE

depsAreTouched is not returning true in this case:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p478477

It appears related to a drastic change in how dependencies are calculated, see:
 https://forum.freecadweb.org/viewtopic.php?f=3&t=55633&p=481061#p481061

This is NOT the solution, as there is no point in systematically executing the ExpressionEngine
on every dimensional constraint change. Just a quick fix to avoid clearly unwanted behaviour in
absence of time to actually fix the root cause.
2021-02-23 07:40:56 +01:00
luz paz
d761c9d2c0 Mesh: Crowdin: fix typo in translation [skip ci]
ref: https://crowdin.com/translate/freecad/561/en-en?filter=basic&value=0#6585564
2021-02-22 08:02:22 +01:00
David Osterberg
f39002fb07 Draft: Fix PathTwistedArray bug 2021-02-22 08:01:34 +01:00
donovaly
ab3464b0f6 [TD] fix balloon dragging
Fixes bug that dragging while pressing CTRL did not work anymore, see https://forum.freecadweb.org/viewtopic.php?f=35&t=55863
2021-02-22 02:17:05 +01:00
Bernd Hahnebach
f5a567a1fc Arch: ifc export, save guid to obj attribute 2021-02-22 01:50:47 +01:00
wmayer
8c26baebab Sketcher: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 129530 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member pixelScalingFactor is not initialized in this constructor nor in any functions that it calls.
2021-02-21 16:59:57 +01:00
wmayer
e728c3590e TD: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316559 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value we. Field we.idx is uninitialized when calling push_back

CID 316549 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member pageheight is not initialized in this constructor nor in any functions that it calls.

CID 186161 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member parent is not initialized in this constructor nor in any functions that it calls.

CID 305170 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking this->m_baseFeat suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

CID 186152 (#2 of 2): Uninitialized pointer field (UNINIT_CTOR)
3. uninit_member: Non-static class member m_mdi is not initialized in this constructor nor in any functions that it calls.

CID 192588 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression
2021-02-21 16:30:30 +01:00
wmayer
1d412261d6 Part: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316522 (#2 of 2): Uninitialized scalar variable (UNINIT)
5. uninit_use_in_call: Using uninitialized value newSelection. Field newSelection.shapeType is uninitialized when calling push_back
2021-02-21 16:06:59 +01:00
wmayer
91c36f9ab1 Mesh: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316517 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316519 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back

CID 316547 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316556 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back
2021-02-21 15:51:56 +01:00
wmayer
d4333072a9 Part: [skip ci] add missing expression bindings to tube dialog 2021-02-21 15:20:12 +01:00
luz paz
110860fa47 Part: Part.CompoundTools.Explode.explodeCompound access a property of...
...a sometimes null object with an error

Python code, file `src/Mod/Part/CompoundTools/Explode.py`
The `explodeCompound` function can be called in a context without assigning the `ViewObject` property, for example from a command line script.

The error that is fixed by this patch. 
```
Traceback (most recent call last):
  ...
  File "/opt/freecad/Mod/Part/CompoundTools/Explode.py", line 23, in explodeCompound
    cf.ViewObject.DontUnhideOnDelete = True
AttributeError: 'NoneType' object has no attribute 'DontUnhideOnDelete']
```

Patch submitted by marioamb.  
Fix #004421  
https://tracker.freecadweb.org/view.php?id=4421
2021-02-21 11:40:20 +01:00
donovaly
9fb381b716 [Part] fix regression in location dialog layout
For some reason the horizontal alignment got broken. This PR replaces the different grids with each on grid per groupbox
2021-02-21 11:36:13 +01:00
sliptonic
20d513cd66 Merge pull request #4484 from Russ4262/fix_profile_feature_filter
[Path] Fixes for Profile operation [0.19]
2021-02-20 17:27:00 -06:00
sliptonic
6697310672 Merge pull request #4498 from sliptonic/bug/slotexperimental
[PATH] move slot op to experimental status
2021-02-20 17:16:22 -06:00
sliptonic
2940953470 Merge pull request #4497 from sliptonic/bug/adaptiveuseoutlineprop
[PATH]  Small fixes to Adaptive op and Heidenhain post processor
2021-02-20 17:15:45 -06:00
wmayer
385efeeb58 Sketcher: [skip ci] fix bad static_cast 2021-02-20 22:46:51 +01:00
David Osterberg
43de589732 PartDesign: Fix throughall distance when throughall is used together with midplane 2021-02-20 20:12:47 +01:00
wmayer
7405dd0ef9 PD: [skip ci] fixes #0004573: missing bindings to expressions in primitives location dialog 2021-02-20 20:04:37 +01:00
donovaly
dd4874d2b6 [Part] add missing bindings
For FC 0.19 we added bindings to the PD primitives but we forgot the Part primitives
2021-02-20 20:02:09 +01:00
Russell Johnson
2b35419e55 Path: LGTM cleanup 2021-02-20 12:32:25 -06:00
Russell Johnson
a961fbee86 Path: Remove unnecessary line return 2021-02-20 12:32:25 -06:00
Russell Johnson
1b3205de20 Path: Add error for incorrect open-edge usage
When profiling open edges, the user must currently select a top edge and then set the Final Depth manually to a value below the selected edge(s).
This fix provides the user with feedback for the empty path generated.
2021-02-20 12:32:25 -06:00
Russell Johnson
215967fe78 Path: Catch error if ofstShape has no Area attribute 2021-02-20 12:32:25 -06:00
Russell Johnson
2b4158addc Path: Fix incorrect empty data type return 2021-02-20 12:32:25 -06:00
Russell Johnson
8e234290ef Path: Catch openEdges error if None 2021-02-20 12:32:25 -06:00
Russell Johnson
b3fc4fcf17 Path: Fix spacing typo 2021-02-20 12:32:25 -06:00
Russell Johnson
d7483f6e85 Path: Fix range() input type per gcc-7 build 2021-02-20 12:32:25 -06:00
Russell Johnson
3a10ed5f27 Path: Fix feature selection and handling
Fix error when working with selections containing edges and faces.  This fix effectively processes edges and only passes faces on to next processing step.  This simplifies the code a bit and changes some `obj.Base` references to `otherBase` to improve readability.
Path: Improve `obj.Base` reading and processing

`obj.Base` is first read in `self._processEdges()`.  All edges are identified and processed there.  Remaining features are saved in `remainingObjBaseFeatures` to be processed in the next section of the Profile code.
Path: Change `if` to `elif`
2021-02-20 12:32:25 -06:00
Russell Johnson
91dd729d4e Path: Fix error for undefined profileshape variable 2021-02-20 12:32:25 -06:00
Russell Johnson
8f4f304635 Path: Fix open-edge profiling for micro bit usage 2021-02-20 12:32:25 -06:00