Chris Hennes
8948505b45
Sketcher/Toponaming: Further linter cleanup
2024-07-26 22:10:44 -05:00
Chris Hennes
037c05a927
Sketcher/Toponaming: Minor code cleanup during review
2024-07-26 21:48:33 -05:00
bgbsww
71870bd6f3
Toponaming: Touchup cleanup
...
Includes some header re-ordering from chennes.
2024-07-26 21:39:39 -05:00
bgbsww
e15646d158
Toponaming: Tests, cleanup, and fix axis drawing
2024-07-26 11:49:56 -04:00
Zheng, Lei
42bf92ad12
Toponaming: Transfer in ExportGeo and associated
2024-07-26 11:49:56 -04:00
Chris Hennes
d92029f0ba
Apply suggestions from code review
2024-07-24 21:48:59 -05:00
bgbsww
b29abf7ffe
Cleanup, format
2024-07-24 16:41:15 -04:00
Zheng, Lei
a7bdbaa662
Toponaming: Transfer in getHigherElement
2024-07-24 15:10:42 -04:00
Zheng, Lei
7d344e2818
Toponaming: Transfer in SketchObject::InternalShape
2024-07-22 17:26:52 -04:00
bgbsww
0bddc51805
Refactor all element name pairs into clearer struct names - renames
2024-07-20 16:32:12 -04:00
bgbsww
159c811bce
Toponaming: refactor getExportElementName to separate method
2024-07-19 10:19:57 -04:00
bgbsww
db9c075be8
Toponaming: Clean Code adding RefIndex to ExternalGeometry and supporting new migration types.
2024-07-19 09:39:19 -04:00
Zheng, Lei
1972156308
Transfer in code from linkstage3
2024-07-19 09:22:17 -04:00
Chris Hennes
c8046b1c60
Sketcher: Fix crash on recompute with points
...
Fixes #15154 .
2024-07-17 10:25:22 -04:00
Pesc0
0e5690d732
Rename variables and clean method
2024-07-15 12:50:30 -04:00
Zheng, Lei
bcea524177
Toponaming: Missing getSubObject code in PartDesign::Body and SketchObject::getSubObject
2024-07-15 11:59:15 -04:00
PaddleStroke
9868533d8d
Sketcher: Fix undo of external creation not working.
2024-07-12 09:41:55 -05:00
bgbsww
af1f7385d4
Toponaming: Comment out console warnings triggered by external geometry
2024-07-09 08:55:21 -05:00
Max Wilfinger
7d21d9edb8
Fix source string typos mentioned on Crowdin ( #15261 )
2024-07-08 17:18:31 -05:00
wmayer
858e59fabf
Sketcher: Fix format string in ExternalGeometryFacade::initExtensions()
...
The format string of the warnings were incorrect and caused an fmt::format_error exception
2024-07-04 22:05:22 +02:00
Chris Hennes
2411f9f3b3
Merge pull request #14461 from AjinkyaDahale/sk-fix-12592-bsp-by-knot-trim
...
[Part][Sketcher] Fix some B-spline trimming issues
2024-07-01 11:28:50 -05:00
bgbsww
d65ee84ff2
Cleanup
2024-06-28 22:24:30 -04:00
pre-commit-ci[bot]
54920e6611
Review cleanups
2024-06-28 11:57:43 -05:00
bgbsww
a674729dd3
Toponaming: Cleanups
2024-06-28 11:57:43 -05:00
Zheng, Lei
7a4bc95d47
Toponaming: Transfer in missing Code for BaseFeatures and Sketches
2024-06-28 11:57:43 -05:00
Ajinkya Dahale
333ca836c0
[Sketcher] Delete point-on-object on trimmed portion
...
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
de61b9dc9f
[Sketcher] Fix some issues with trimming splines
...
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
7c15affce6
[Sketcher] Rearrange directives to appease syntax highlight
...
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
wmayer
f6e67a009d
Fix several compiler warnings
...
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
a36a60d29d
Fem/Sketcher: Fix missing PreCompiled.h files
2024-06-18 08:05:32 -05:00
bgbsww
2d22e7a21a
Toponaming: Fix crash with invalid external geometry
2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
77eedb84f8
Fix importing arcs and elliptical arcs as external geometry.
...
Fix importing elliptical arcs issue #8700 .
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
bgbsww
d467236564
Guard all uses of basic_random_generator for thread safety
2024-06-10 11:10:57 -05:00
mosfet80
62279d083d
[mod] clean ( #14378 )
...
* [mod] clean
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
Chris Hennes
e11bafc715
Merge pull request #14337 from wwmayer/refactor_sketch_analysis
...
Sketch: Refactor SketchAnalysis
2024-06-03 10:49:30 -05:00
wmayer
4185605d5e
clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors
2024-05-29 13:37:07 +02:00
wmayer
ddfc21afc1
Sketch: Refactor SketchAnalysis
...
Refactor detectMissingPointOnPointConstraints()
2024-05-28 15:28:53 +02:00
wmayer
7e5b0d570a
Sketch: Refactor SketchAnalysis
...
Refactor detectMissingEqualityConstraints()
2024-05-28 15:10:51 +02:00
wmayer
112c26cf1c
Sketch: Refactor SketchAnalysis
...
Fix linter warnings
2024-05-28 14:43:46 +02:00
wmayer
e0e2e01484
Sketch: Refactor SketchAnalysis
...
Refactor autoconstraint()
2024-05-28 14:28:07 +02:00
wmayer
1c03bc4eaa
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingEquality()
2024-05-28 14:19:58 +02:00
wmayer
d5c92fee98
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingVerticalHorizontal
2024-05-28 14:08:44 +02:00
wmayer
5461d0d27f
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingPointOnPoint
2024-05-28 13:40:38 +02:00
wmayer
bcc1a9ada5
Sketch: Refactor SketchAnalysis
...
Refactor detectMissingPointOnPointConstraints
2024-05-28 13:24:05 +02:00
wmayer
5982ac470e
Sketch: Refactor SketchAnalysis
...
Move helper classes to anonymous namespace
2024-05-28 12:26:23 +02:00
wmayer
e67502025d
Sketch: Add test case for validating constraints
2024-05-27 19:15:18 +02:00
wmayer
e96ac0b1db
Sketch: Add test case for degenerated geometry
2024-05-27 19:15:18 +02:00
PaddleStroke
6bbf61b1f2
Sketcher: Fix copy of geo constrained to axis. Fixes #14233
2024-05-27 11:37:33 -05:00
wmayer
5696ee821c
Sketcher: Fixes #14240
2024-05-27 12:09:35 +02:00
wmayer
27b1caa82b
Sketch: Refactor Sketch::updateGeometry()
2024-05-20 11:38:06 -05:00
