Commit Graph

909 Commits

Author SHA1 Message Date
berniev
6953310116 Mod: Single arg ctors must be explicit 2022-08-24 16:55:20 +02:00
wmayer
a899f078bd CMake: [skip ci] remove trailing whitespaces 2022-08-24 07:46:07 +02:00
Jonas Bähr
a1776d3e74 Fix build on MacOS-X 10.14: missing Xerces include dir
This undoes most of the Xerces related part of the commits listed below.
The issue resolved here is that the Xerces include dir *is* set in the
CMakeLists.txt of src/Base, but it got removed from various App and Gui
dirs in src/Mod. If those now include a header from src/Base, which
itself includes xercesc, the build fails using Apple clang version 11.0.0
(clang-1100.0.33.17) on Mojave, configured using cmake 3.22.1, with
errors like the following:

In file included from .../src/Mod/Part/App/FeaturePartBoolean.cpp:34:
In file included from .../src/App/Application.h:33:
.../src/Base/Parameter.h:54:10: fatal error: 'xercesc/util/XercesDefs.hpp' file not found
 #include <xercesc/util/XercesDefs.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Finally, a full list of the commits that introduced this spurious include
dir optimization for reference:
- Drawing: commit 96ad045b91
- Image: commit dde71a21d5
- Import: commit c9d28b542f
- Inspection: commit d41f55f382
- Mesh: commit 19072b0538
- Part: commit fe213a48f0
- PartDesign: commit b037d8e240
- Path: commit f23fa31f42
- Points: commit bec723ba17
- Raytracing: commit 08d4ac63a3
- ReverseEnginering: commit 5ca787cb0e
- Robot: commit bad4809a1c
- Sketcher: commit 3c96daf105
- Spreadsheet: commit 66e8a2bef3
- Start: commit c9dee5e70a
- Surface: commit 6b04215be6
- TechDraw: commit 5e6699e48d
- Test: commit ea5b45b92c
- Web: commit ee6d631531
2022-08-24 07:40:04 +02:00
luz paz
1a7ddfdc24 Fix typos and whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-08-23 18:49:47 +02:00
wmayer
91830933d7 TD: [skip ci] fix warnings of checkers about whitespaces 2022-08-22 08:37:08 +02:00
Wanderer Fan
4ad52a5778 [TD]use Label in waiting for thread message 2022-08-21 21:18:26 -04:00
Wanderer Fan
1494b8288a [TD]use new style QObject::connect 2022-08-21 21:18:26 -04:00
wmayer
5014bab534 Mod: replace std::ifstream/std::ofstream with Base::ifstream/Base::ofstream 2022-08-21 12:46:53 +02:00
wmayer
ff01905f0b TD: fix UTF-8 handling in LineGroup 2022-08-20 16:00:36 +02:00
Wanderer Fan
f9d62da307 [TD]code review changes for dvp, dvs 2022-08-18 19:43:04 -04:00
Wanderer Fan
e8a25a8fdf [TD]code review changes for dgh, dpg, dpgi, dra 2022-08-18 19:43:04 -04:00
Wanderer Fan
644b4991e2 [TD]code review changes for dvp and dvd 2022-08-18 19:43:04 -04:00
Wanderer Fan
d6806167e1 [TD]fix typo in message 2022-08-18 13:02:50 -04:00
Wanderer Fan
2d7d882235 [TD]prevent running threads on object delete 2022-08-18 09:34:32 -04:00
Wanderer Fan
74cdc6db61 [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
Wanderer Fan
b1dd0bd2d0 [TD]add preference for progress reporting 2022-08-18 09:34:32 -04:00
Wanderer Fan
f12846599d [TD]fix detail of section not displayed on restore 2022-08-18 09:34:32 -04:00
Wanderer Fan
00b671e370 [TD]fix projectShape for shape outline 2022-08-18 09:34:32 -04:00
Wanderer Fan
6677cd4d8f [TD]clazy warnings and duplicate setter/getter
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
2022-08-18 09:34:32 -04:00
Wanderer Fan
6df801ed96 [TD]respect AutoDistribute on load 2022-08-18 09:34:32 -04:00
Wanderer Fan
a2b09d37c5 [TD]move section cut and detail common to thread 2022-08-18 09:34:32 -04:00
Wanderer Fan
ac63550122 [TD]add progress reporting framework 2022-08-18 09:34:32 -04:00
Wanderer Fan
7e701969af [TD]run hlr and extractFaces in threads 2022-08-18 09:34:32 -04:00
Wanderer Fan
bdf4cea14e [TD]refactor scene/view/mdi
- move scene related functions out of mdiViewPage
  and QGVPage.
- route requests for scene/view/mdi through
  ViewProviderPage
2022-08-18 09:34:32 -04:00
Wanderer Fan
f2ba030ebb [TD]remove precompiled from *.h 2022-08-14 09:20:38 -04:00
Wanderer Fan
4407dde179 [TD]hatch file default handling 2022-08-13 19:45:56 -04:00
Wanderer Fan
2f49a93292 [TD]fix LineFormat ctor line color 2022-08-12 13:00:21 -04:00
wmayer
2062f9ce87 clang: fix warnings [-Winconsistent-missing-override] 2022-08-09 17:36:25 +02:00
berniev
ddafb98813 Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
915369d8a2 Mod: Redundant_string_initialization 2022-08-08 16:52:42 +02:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
b796a0d376 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
2d4c5a4cfb Mod: use emplace_back 2022-08-05 10:36:16 +02:00
Benjamin Bræstrup Sayoc
86dfd0a862 [TechDraw] Simplify code getting default line weights 2022-08-02 16:13:01 -04:00
Benjamin Bræstrup Sayoc
750fa24b2e [TechDraw] Remove deprecated replaceGeomFormat 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
8719b71e39 [TechDraw] Remove deprecated replaceCenterLine 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
0bb56ad93f [TechDraw] Remove deprecated replaceCosmeticEdge 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
127af5bea4 [TechDraw] Remove deprecated replaceCosmeticVertex 2022-08-02 16:09:54 -04:00
Benjamin Bræstrup Sayoc
79d4c1556f [TechDraw] Improve readability of DrawWeldSymbol.cpp 2022-07-29 14:39:21 -04:00
Benjamin Bræstrup Sayoc
811b85caeb [TechDraw] Improve readability of DrawViewSpreadsheet.cpp 2022-07-29 14:39:21 -04:00
wmayer
e48a3a8cea Mod: [skip ci] fix warning: [-Wreturn-std-move] 2022-07-29 18:55:10 +02:00
Uwe
666fab995e [TD] silence a MSVC compiler warning
- as suggested here: https://forum.freecadweb.org/viewtopic.php?p=613409#p613409
2022-07-29 02:21:21 +02:00
Wanderer Fan
54ce3d0fc3 [TD]fix redraw does not paint all views 2022-07-28 09:16:03 -04:00
Wanderer Fan
0805d284d5 [TD]fix Symbol update on property change 2022-07-28 09:16:03 -04:00
andrea
5a9ffe468c Remove deprecated function 2022-07-26 08:52:04 -04:00
Uwe
c9b709d814 [TD] remove unnecessary nullptr checks 2022-07-26 00:28:57 +02:00
wmayer
e7edda9679 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Benjamin Bræstrup Sayoc
6ed38eeb99 [TechDraw] Improve readability of DrawViewDetail.cpp
[TechDraw] Improve readability of DrawViewDimension.cpp

[TechDraw] Improve readability of DrawViewDimExtent.cpp

[TechDraw] Improve readability of DrawViewDraft.cpp

[TechDraw] Improve readability of DrawViewImage.cpp

[TechDraw] Improve readability of DrawViewMulti.cpp
2022-07-20 16:44:26 -04:00
Wanderer Fan
111aef4866 [TD]review comments and rebase for PR7197 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
e326f9bd99 [TechDraw] Improve readability of DrawViewClip.cpp 2022-07-20 12:59:12 -04:00