Commit Graph

28064 Commits

Author SHA1 Message Date
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Uwe
b57e6fa5bd [3rdParty] SalomeMesh: fix parameter typos found by the spellchecker CI 2022-03-13 02:00:52 +01:00
Uwe
25137db5ca [Assembly] fox typos in element names
all found by the spellchecker CI
2022-03-13 01:32:27 +01:00
sliptonic
217174d548 Merge pull request #5440 from voneiden/path-array-improvements
Path: Path Array dressup compatibility
2022-03-12 18:21:40 -06:00
Uwe
6a4c94148c [Gui] QSint: some sorting of headers 2022-03-12 23:57:14 +01:00
mwganson
eaf36231eb PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
7d628a6e03 Add General.NumThreads = CPU core count setting to Gmsh
settings file to enable multi-threaded meshing (much faster
for larger models)
2022-03-12 23:26:55 +01:00
wmayer
7720c3ab07 PyCXX: remove use of std::iterator that is deprecated since C++17 2022-03-12 22:22:00 +01:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
bba7c89c2a Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bcfa246943 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
341cf32369 Sketcher: Coverity 332685, 332686, 332696
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c8a57fb9b4 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
963cae4a0b Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bd84e883cf Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Uwe
ebd92016af [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 20:20:18 +01:00
Uwe
3b395ed856 [skip CI] fix inconsistent line endings in 2 files
was reported by MSVC
2022-03-12 20:12:19 +01:00
Uwe
3017b84191 [skip CI] [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 19:52:29 +01:00
Uwe
5989f9e138 [zipios] fix comment typos found by the spellchecker CI 2022-03-12 19:51:21 +01:00
Uwe
4dab2eeca3 [skip CI] [Tools] wxWidgets: fix inconsistent line endings 2022-03-12 19:42:07 +01:00
Uwe
ec0d0beb19 [skip ci] [Gui] fix a typo 2022-03-12 19:19:16 +01:00
Uwe
0ebdbff9bf [skip ci] [3rdParty] SMESH: fix comment typos found by the spellchecker CI 2022-03-12 19:18:12 +01:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
9f373d26b3 [3rdParty] SalomeMesh: fix more comment typos found by the spellchecker CI 2022-03-12 19:02:37 +01:00
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
97472c46ad [3rdParty] SalomeMesh: fix comment typos found by the spellchecker CI 2022-03-12 18:38:53 +01:00
Uwe
b19db18cdd [CXX] uniform inconsistent line endings 2022-03-12 18:29:51 +01:00
Uwe
6964e86b4d [CXX] fix typos found the spell CI 2022-03-12 18:25:35 +01:00
Uwe
c50f2e980c [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
fc51a07127 [3rdParty] fix typos found by the spellchecker CI 2022-03-12 17:49:37 +01:00
Uwe
931e2a3c17 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
e4777d16f8 [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
7bef267503 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
589f074e7d Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00
Chris Hennes
e7d50f0b13 Addon Manager: Fix window focus issues 2022-03-11 20:07:20 -06:00
mwganson
fc617e1524 Part: 2doffset fix crash by chacking for null shape before adding with builder.Add() 2022-03-12 02:48:22 +01:00
Zheng, Lei
2a28ad5cef PD: add SubShapeBinder 'Refine' property
Respect setting in BaseApp/Preferences/Mod/PartDesign/RefineModel
2022-03-12 02:45:13 +01:00
Zheng, Lei
8d6b06bc86 PD: fix SubShapeBinder 'Fuse' function 2022-03-12 02:45:13 +01:00
Uwe
5d798e26cf [Path] fix a typo 2022-03-12 02:24:44 +01:00
Uwe
045eafd062 [CXX] fix typos found by the spellchecker CI 2022-03-12 02:19:48 +01:00
Uwe
cd58a8336c [CXX] fix typos reported by the spellchecker CI 2022-03-12 02:07:38 +01:00
Uwe
5dba742beb [Path] 2nd part of the Git fix attempt
renaming it back
2022-03-12 02:01:29 +01:00
Uwe
99a0a67867 [Path] next attempt to fix Git error by renaming
use lowercase letters fro file ending like it is also in the CMake file
2022-03-12 02:00:40 +01:00
Uwe
76e601a712 [Path] try to silence a git error with a file
Git has issues with this file telling me it is corrupted and its file ending is wrong (in Git lowercase, in the file uppercase).

The attempt is to just to save save it with FC 0.20.
2022-03-12 01:55:37 +01:00
wmayer
ec8353ba99 Part: refactor PropertyPartShape::SaveDocFile and PropertyPartShape::RestoreDocFile
Set exception mask of std::istream::failbit | std::istream::badbit to istream to make sure it raises an exception for corrupted input files.
See: https://forum.freecadweb.org/viewtopic.php?p=536747
2022-03-11 22:06:38 +01:00
Wanderer Fan
cb5334a98c [TD]fix getScale should be Scale.getValue 2022-03-11 11:59:31 -05:00
sliptonic
da2dcaa7f4 Merge pull request #6552 from Russ4262/fix/leadin_leadout_simulation
Path: Fix Leadin-Leadout dressup simulation related to arcs [Bug]
2022-03-11 10:06:42 -06:00
sliptonic
14949faf06 Merge pull request #6541 from Russ4262/fix/ramp_entry_dressup
Path: Fix enumeration dictionary error [Bug]
2022-03-11 10:04:53 -06:00
sliptonic
f8fa9c047e Merge pull request #6530 from sliptonic/bug/6114
[Path] Fix minor non-modal bug.  Fixes 6114
2022-03-11 10:03:53 -06:00