Commit Graph

272 Commits

Author SHA1 Message Date
wmayer
74ead2c6ff Mod: whitespace fixes 2022-05-17 11:51:22 +02:00
Zheng, Lei
3ef438eaf0 Fix mixed line endings 2022-04-26 12:52:55 -05:00
Chris Hennes
702238a99c Mesh: PR6497 move return statement to new line 2022-03-29 12:36:30 -05:00
wmayer
99fd8af911 Mesh: include header with export macros 2022-03-24 20:42:15 +01:00
wmayer
c9a0fae9db lgtm: [skip ci] FIXME comment
Change FIXME or remove it
2022-03-20 16:51:23 +01:00
wmayer
cb81addfa1 Mesh: [skip ci] lgtm: Multiplication result converted to larger type
Multiplication result may overflow 'float' before it is converted to 'double'.
2022-03-20 15:53:04 +01:00
wmayer
f6f21f4fa6 Mesh: Fix several coverity issues:
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
2022-03-13 14:58:14 +01:00
wmayer
e4435cdcba Base/App: fix warnings from code analysers:
* convert old-style-casts to explicit C++ casts where possible
* make some implicit conversions explicit
2022-03-06 23:49:30 +01:00
wmayer
a6f0f69ed6 Mesh: overload MeshAlgorithm::NearestFacetOnRay to set a max. angle between facet and ray 2022-02-13 12:46:01 +01:00
wmayer
853454a139 Mesh: modernize C++11
* remove redundant void-arg
* use nullptr
* replace deprecated headers
2022-01-26 18:05:02 +01:00
luz paz
e4aad767f4 Mesh: translate doxygen from DE to EN
For the purpose of making the source documentation uniform, source comments in this file were translated to English.
2022-01-13 17:27:43 +01:00
luzpaz
1c83d8fedd Points: translate doxygen from DE to EN + fix superfluous whitespace (#5287)
* Points: translate doxygen from DE to EN + fix superfluous whitespace

For the purpose of making the source documentation uniform, source comments in this file were translated to english.

* Points: remove superfluous whitespace

* Fix left over DE to EN translations (from Cam and Mesh code)
2021-12-25 20:41:12 +01:00
luz paz
9c74c0afb1 Mesh: translate doxygen from DE to EN
For the purpose of making the source documentation uniform, source comments in this file were translated to english.
2021-12-22 01:09:52 +01:00
luz paz
0042f58e4c Make source code comments use gender neutral pronouns
The changes also include some grammatical fixes as well.
2021-12-02 16:18:04 -05:00
luz paz
9a9267f922 Mesh: Convert comments from DE->EN
Bringing uniformity to documenting FreeCAD
2021-11-03 11:13:16 -04:00
wmayer
e3ebe4bc9f Mesh: add basic support of 3MF file format 2021-10-22 17:11:16 +02:00
wmayer
30ba396a82 Mesh: improve MeshGeomFacet::IntersectWithFacet 2021-10-20 19:42:39 +02:00
wmayer
cef86fb1ef Mesh: extend API to access edges of a facet via Python 2021-10-20 13:01:11 +02:00
wmayer
5a55386919 Mesh: [skip ci] add unit tests for coplanar and intersecting triangles 2021-10-19 20:31:39 +02:00
wmayer
8d0d149b5b Mesh: add method to get intersection of edges 2021-10-19 19:22:21 +02:00
wmayer
abf1cd1586 Mesh: [skip ci] update tri-tri-intersection 2021-10-19 15:14:36 +02:00
bartus
0c3ba910aa Fix linux build: undefined std:string_view
Pop 'mesh' library c++ stranderd to c++17
Add required <string_view> header
2021-10-03 14:36:16 +02:00
Chris Hennes
822bc86894 Mesh: remove unused variable in Nastran reader 2021-09-29 16:34:58 -05:00
wmayer
e1c5bfab1f Mesh: add method MeshAlgorithm::GetFacetsBorders 2021-09-29 22:33:45 +02:00
wmayer
1d9ba918ac Mesh: [skip ci] rename MeshAlgorithm::GetMeshBorder to MeshAlgorithm::GetFacetBorder 2021-09-29 19:38:52 +02:00
wmayer
8ff9bbc930 Mesh: improve function to fix points on edge 2021-09-29 19:32:18 +02:00
wmayer
3dd5438880 Mesh: [skip ci] when points lie exactly on a plane it can happen that a plane fit creates U,V vectors with NaN while W is valid 2021-09-29 12:35:28 +02:00
wmayer
0a9d08218a Mesh: detect points on edges 2021-09-28 22:30:21 +02:00
Chris Hennes
bd4623a2a3 [Mesh] Improve unit tests
Add a test for the CTRIA3 element, and add code to check the used nodes
and cancel the file load if they don't all exist.
2021-09-25 19:42:00 -05:00
Chris Hennes
b10dc6757a Merge branch 'master' into meshNastranFileFormat 2021-09-25 16:34:33 -05:00
wmayer
bd46e970d9 Mesh: [skip ci] change MeshTopoAlgorithm::SplitOpenEdge to return a boolean to indicate if the operation succeeded or not 2021-09-25 14:52:49 +02:00
Chris Hennes
7655e7347d [Mesh] Improve NASTRAN input support
Adds support for original-NASTRAN fixed-field-width low-precision GRID
element (the existing code assumed space-delimited input).
2021-09-22 11:58:04 -05:00
Chris Hennes
e233ba54e6 Merge pull request #5047 from chennes/lgtmMeshEmptyBlocks
[Mesh] Implement high-precision NASTRAN GRID* element
2021-09-22 09:22:48 -05:00
Chris Hennes
f9f08f8805 [Mesh] Implement GRID* input in NASTRAN
LGTM complained about two empty blocks in the Mesh NASTRAN reader: those
blocks related to the code skipping the input of the high-precision GRID
element. This commit adds support for that element.
2021-09-20 10:32:10 -05:00
wmayer
e211b89cf8 port to MSYS2/clang 2021-09-19 19:49:44 +02:00
wmayer
3ab5dadd82 Mesh: add function section() to Mesh class 2021-09-16 17:31:45 +02:00
wmayer
33f3fa6865 Mesh: define the typenames FacetIndex and PointIndex to distinguish between facet and point related indexes 2021-09-14 23:01:29 +02:00
wmayer
40d2955c66 Base: split export/import macros from FCConfig.h and move them to FCGlobal.h
The FCGlobal.h can be included in a Global.h header file of an extension module.

The reason is that some IDEs (e.g. QtCreator) fails to detect the export/import macros when only defined in the PreCompiled.h files and thus raise a parser warning.
2021-09-14 16:40:30 +02:00
Megidd Git
c3df0db4f7 Mesh: fix infinite loop when repairing mesh facet indices 2021-09-12 09:13:57 +04:30
Ajinkya Dahale
11f89dd641 [Mesh] Skip false positive tests for coplanar self-intersections
Fixes issue #4732.

Within the code, a different algorithm is used for intersection checks when
faces are found to be coplanar. That algorithm does not return the "intersection
line", which is used to remove false-positives. This however results in
false-negatives.
2021-08-31 11:11:11 -04:00
wmayer
182952a881 Mesh: [skip ci] do not make lower case read lines of OBJ file as otherwise it may fail to load the MTL file 2021-03-20 19:19:30 +01:00
wmayer
9f937f765d Mesh: [skip ci] fix regular expression in MeshInput 2021-03-10 17:49:05 +01:00
wmayer
91c36f9ab1 Mesh: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316517 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316519 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back

CID 316547 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316556 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back
2021-02-21 15:51:56 +01:00
wmayer
1b42828d25 Mesh: [skip ci] implement splitFacet 2021-02-14 00:54:30 +01:00
Chris Hennes
feb4ffc693 Correct minimum distance calculation in SplitFacet
Found via LGTM.
2021-02-12 21:59:50 +01:00
Chris Hennes
5d0cf1081e LGTM: Eliminate float-to-double overflow warning
LGTM complains if this calculation is done from inside the sqrt() call
because it sees the explicit cast to float and assumes that sqrt() is
intended to take a double. By adding an intermediate step it should be
clear to LGTM that the float version of sqrt is intended.
2021-02-09 20:01:13 +01:00
Chris Hennes
081cc4d9eb Remove extra comma in Asymptote surface color definition
Found via LGTM.
2021-02-08 10:50:18 +01:00
wmayer
e81482c7f9 Mesh: [skip ci] improve reading OFF mesh format 2020-11-03 11:15:37 +01:00
wmayer
ebb43351d1 Mesh: [skip ci] improve reading OFF mesh format 2020-11-02 16:36:07 +01:00
wmayer
df9282dc12 C++11: [skip ci] replace deprecated function std::mem_fun_ref with lambda functions 2020-10-15 18:55:29 +02:00