Commit Graph

28079 Commits

Author SHA1 Message Date
wmayer
7acdcbd031 PD: Fix several coverity issues:
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
2022-03-13 16:32:19 +01:00
wmayer
15ee1fdd4e Part: Fix several coverity issues:
* CID 350581: Structurally dead code
* CID 350620: Structurally dead code
* CID 350563: Big parameter passed by value
* CID 350552: Uncaught exception
* CID 305193: Uncaught exception
* CID 350556: Uninitialized scalar field
* CID 350579: Uninitialized pointer read
2022-03-13 16:06:40 +01:00
wmayer
81ea374800 MeshPart: Fix several coverity issues:
* CID 350570: Uninitialized scalar variable
* CID 350628: Uncaught exception
2022-03-13 15:50:39 +01:00
wmayer
883012e4b0 TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
69a5bfd6b1 Mesh: Fix several coverity issues:
* CID 350557: Out-of-bounds read (false-positive)
* CID 316517: Uninitialized scalar variable
* CID 316519: Uninitialized scalar variable
* CID 316547: Uninitialized scalar variable
* CID 316556: Uninitialized scalar variable
* CID 350614: Uncaught exception
* CID 350606: Uncaught exception
* CID 332681: Using invalid iterator
2022-03-13 14:58:14 +01:00
wmayer
d419b325fb Fem: Fix several coverity issues:
* make SelectionChangeModes an enum class
* CID 350596: Uninitialized scalar field
* CID 350572: Uncaught exception
* CID 350647: Uncaught exception
2022-03-13 14:09:04 +01:00
wmayer
b78dc894e1 Core: Fix several coverity issues:
* CID 350582: Big parameter passed by value
* CID 350639: Big parameter passed by value
* CID 305234: Uncaught exception
* CID 316529: Uncaught exception
* CID 350597: Uncaught exception
* CID 350623: Uncaught exception
* CID 332690: Uncaught exception
* CID 332700: Unchecked return value
* CID 350576: Uninitialized scalar field
* CID 350587: Uninitialized scalar variable
* CID 192606: Uninitialized scalar field
* CID 332699: Uninitialized pointer field
* CID 350561: Dereference null return value
* CID 350610: Dereference null return value
* CID 350567: Dereference after null check
2022-03-13 13:53:32 +01:00
Anders Torger
2e6c4373bf Apply multi-thread configuration for Calculix also when started via task panel 2022-03-13 13:32:30 +01:00
Uwe
d0fe16610d [Gui] QSint: remove unused headers 2022-03-13 12:59:11 +01:00
wmayer
5fd93b7d3b Fix several coverity issues:
* CID 350617: Dereference after null check
* CID 350585: Out-of-bounds read
* CID 350624: Resource leak
* CID 332701: Uncaught exception
* CID 350642: Uninitialized scalar field
* CID 350590: Uninitialized scalar field
* CID 350629: Uninitialized scalar variable
* CID 350602: Uninitialized scalar variable
* CID 350564: Uninitialized scalar variable
* CID 350548: Uninitialized scalar variable
2022-03-13 12:12:49 +01:00
wmayer
afabaea5cb PD: Fix several coverity issues:
* CID 350622: Negative array index read
* CID 350613: Negative array index read
* CID 166163: Negative array index read
* refactor Hole::updateDiameterParam()
2022-03-13 12:10:01 +01:00
Abdullah Tahiri
23f18505f2 Sketcher: Redraw constraints on wheel event
===========================================

https://forum.freecadweb.org/viewtopic.php?p=577585#p577585
2022-03-13 11:33:52 +01:00
Abdullah Tahiri
6397201dc0 Gui: Pass wheel event to viewprovider
=====================================

https://forum.freecadweb.org/viewtopic.php?p=578857#p578857
2022-03-13 11:33:52 +01:00
wmayer
49888175ed Robot: [skip ci] add header with export macros 2022-03-13 08:37:58 +01:00
Ajinkya Dahale
9007662425 [Sketcher] Fix "toggle internal geo" on multi-selection
Some deleted GeoIds can stay in selection and GeoIds can change as some objects
are deleted.
2022-03-13 06:58:40 +01:00
sliptonic
73e995a0f7 Merge pull request #6566 from Russ4262/fix/boundary_dressup_begin_safeheight_retraction
Path: Correct beginning retraction to safe height in Boundary Dressup, issue #6279 [Bug]
2022-03-12 19:05:39 -06:00
Uwe
b57e6fa5bd [3rdParty] SalomeMesh: fix parameter typos found by the spellchecker CI 2022-03-13 02:00:52 +01:00
Uwe
25137db5ca [Assembly] fox typos in element names
all found by the spellchecker CI
2022-03-13 01:32:27 +01:00
sliptonic
217174d548 Merge pull request #5440 from voneiden/path-array-improvements
Path: Path Array dressup compatibility
2022-03-12 18:21:40 -06:00
Uwe
6a4c94148c [Gui] QSint: some sorting of headers 2022-03-12 23:57:14 +01:00
mwganson
eaf36231eb PartDesign::SubShapeBinder add 2D offsetting 2022-03-12 23:30:09 +01:00
Anders Torger
7d628a6e03 Add General.NumThreads = CPU core count setting to Gmsh
settings file to enable multi-threaded meshing (much faster
for larger models)
2022-03-12 23:26:55 +01:00
wmayer
7720c3ab07 PyCXX: remove use of std::iterator that is deprecated since C++17 2022-03-12 22:22:00 +01:00
Matti Eiden
34ed7bc123 PathArray: Support applying PathArray on Dressups 2022-03-12 22:31:16 +02:00
Abdullah Tahiri
bba7c89c2a Sketcher: Coverity 332695 - unlikely array indexing with negative value 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bcfa246943 Sketcher: Coverity 332679 - logically dead code removed 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
341cf32369 Sketcher: Coverity 332685, 332686, 332696
=========================================

Detected by coverity as unchanged variable (constant intended).

It was actually an unnecessary variable that prevented correct command committing.
2022-03-12 21:14:19 +01:00
Abdullah Tahiri
c8a57fb9b4 Sketcher: Coverity 350601 - possible resource leak 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
963cae4a0b Sketcher: Coverity 350637 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Abdullah Tahiri
bd84e883cf Sketcher: Coverity 350641 - unhandled exception in noexcept destructor 2022-03-12 21:14:19 +01:00
Uwe
ebd92016af [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 20:20:18 +01:00
Uwe
3b395ed856 [skip CI] fix inconsistent line endings in 2 files
was reported by MSVC
2022-03-12 20:12:19 +01:00
Uwe
3017b84191 [skip CI] [3rdParty] libE57: fix comment typos found by the spellchecker CI 2022-03-12 19:52:29 +01:00
Uwe
5989f9e138 [zipios] fix comment typos found by the spellchecker CI 2022-03-12 19:51:21 +01:00
Uwe
4dab2eeca3 [skip CI] [Tools] wxWidgets: fix inconsistent line endings 2022-03-12 19:42:07 +01:00
Uwe
ec0d0beb19 [skip ci] [Gui] fix a typo 2022-03-12 19:19:16 +01:00
Uwe
0ebdbff9bf [skip ci] [3rdParty] SMESH: fix comment typos found by the spellchecker CI 2022-03-12 19:18:12 +01:00
Russell Johnson
4ae4e7be1a Path: Correct beginning retraction to safe height feed rate, issue #6279 [Bug]
This commit changes the feed rate of the beginning retraction from G1 at Feed to a G0 Rapid rate.  This initial command is causing a problem with the Tag Dressup due to the first move being a G1 to Safe Height.
2022-03-12 12:18:09 -06:00
Uwe
9f373d26b3 [3rdParty] SalomeMesh: fix more comment typos found by the spellchecker CI 2022-03-12 19:02:37 +01:00
Abdullah Tahiri
7294d4d7a3 Sketcher: move comment to right position 2022-03-12 18:45:16 +01:00
Uwe
97472c46ad [3rdParty] SalomeMesh: fix comment typos found by the spellchecker CI 2022-03-12 18:38:53 +01:00
Uwe
b19db18cdd [CXX] uniform inconsistent line endings 2022-03-12 18:29:51 +01:00
Uwe
6964e86b4d [CXX] fix typos found the spell CI 2022-03-12 18:25:35 +01:00
Uwe
c50f2e980c [Assembly] fix typos found by the spellchecker CI 2022-03-12 17:52:33 +01:00
Uwe
fc51a07127 [3rdParty] fix typos found by the spellchecker CI 2022-03-12 17:49:37 +01:00
Uwe
931e2a3c17 [Robot] fix some typos found by the spellchecker CI 2022-03-12 17:46:48 +01:00
Abdullah Tahiri
5e88ee99f5 Sketcher: BSpline code review and fix
=====================================

- Avoid using EditCurve for the double use of storing the pole positions and the last mouse position. Split into individual vector for poles and previous cursor position (with appropriate names).
- Store all pole geoids to better show the intend of the code.
- Avoid indexing when referring the last inserted value of a std::vector, use back() instead.
- Encapsulate code to draw the bspline polygon and the cursor text to the given position. This allow to select the right function for every case, while avoiding unclear names, such as "mousemove()".
- Refactor code to finish command, to avoid calling unclear names such as "releasebutton" to better show the intend of the function call.
- Ensure deleted pole does not appear anymore in the scenograph.
2022-03-12 15:47:50 +01:00
Uwe
e4777d16f8 [Part] remove unused variable
MSVC complained about it
2022-03-12 15:44:27 +01:00
Wanderer Fan
7bef267503 [TD]fix 2 edge angle Dim special case 2022-03-12 08:55:35 -05:00
Chris Hennes
589f074e7d Test: Add first tests for Metadata 2022-03-11 20:15:44 -06:00