Commit Graph

88 Commits

Author SHA1 Message Date
Alex Young
80dbfd5814 Arch: removes unused imports
Removes unused imports as reported by LGTM.

There are exceptions: `import Arch_rc` is shown as an alert, but has side effects.  It's not clear what the best thing to do in those cases is, so I've left them for now.
2021-02-14 16:27:06 +00:00
Chris Hennes
9d1958475e [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
luz paz
ccf30d98d2 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
luz.paz
8af8689d73 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
ef5acc5023 Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
luz.paz
f53ef01d94 Arch: use string operator instead of numeric LGTM fix 2019-10-25 10:23:24 -03:00
luz.paz
7a1f98fda1 Misc. source comment typo and whitespace fixes 2019-05-06 13:42:30 +02:00
Yorik van Havre
506cfd9bd2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
paullee0
4e35701577 Add RiserThickness feature
Mantis
  https://freecadweb.org/tracker/view.php?id=0003816

Discussion
  https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=120#p298162
2019-04-04 11:08:04 -03:00
luz.paz
a703ae39d3 More misc. typos 2019-03-31 11:42:37 +02:00
paullee0
8ceaab78fc Fix to Build Curve Segment Railing Wire To Follow Curve Landing
Limited by makePipeShell, curvilinear railing still usually has problems to be created

Discussions:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=bfd05589642577079096cd8879b7a88f&start=120#p285656
https://forum.freecadweb.org/viewtopic.php?f=22&t=34081#p285607
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=110#p284683
2019-03-19 14:16:05 -03:00
paullee0
8af522df52 Revert "Build Curve Segment Railing Wire To Fit Landing"
This reverts commit e5989280bb8aeb73b73483c0c74d019bdb1116d6.
2019-03-19 14:16:05 -03:00
paullee0
1198f11a0b Build Curve Segment Railing Wire To Fit Landing
Limited by makePipeShell, curvilinear railing usually has problems to be created

Discussions:-
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=110#p284683
https://forum.freecadweb.org/viewtopic.php?f=22&t=34081#p285607
2019-03-19 14:16:05 -03:00
paullee
4ffd00e520 Fix Right Align Railing Offset Bug 2019-02-06 10:13:37 -02:00
luz.paz
b1b81f6df3 Crowdin: Arch/ArchStairs.py missing paranthesis fix 2019-01-30 11:08:03 -02:00
Yorik van Havre
86d8372056 Misc translation fixes from https://forum.freecadweb.org/viewtopic.php?p=281670 2019-01-23 18:20:43 -02:00
luz.paz
3fb71fbe2a [For v0.18] Crowdin fixes
https://crowdin.com/translate/freecad/568/en-en#1172237
https://crowdin.com/translate/freecad/568/en-en#1172239
https://crowdin.com/translate/freecad/568/en-en#195053
https://crowdin.com/translate/freecad/568/en-en#1172247
https://crowdin.com/translate/freecad/568/en-en#1172249
https://crowdin.com/translate/freecad/568/en-en#1172251
https://crowdin.com/translate/freecad/6766/en-en#6511058
https://crowdin.com/translate/freecad/6766/en-en#6511060
https://crowdin.com/translate/freecad/6766/en-en#6502381
+ random typo fixes
2019-01-13 02:24:50 +01:00
paullee
ba4520d259 Curvilinear Landing based on underlying curve edges supported; found sortEdges() 'problem'
Discussion:-
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=100#p277409
2019-01-02 17:26:34 -02:00
paul
2246e73488 Fix another 2 missing parentheses 2018-12-03 10:30:08 -03:00
Yorik van Havre
78338e6e19 Fixed py3 sntax errors 2018-12-03 10:30:08 -03:00
paullee
55474651ab Some methods become Static, returnOutlines() become more generic purpose etc. 2018-12-03 10:30:08 -03:00
paullee
b3c49686da Fix Typo - vbaseFollowLastSement --> vbaseFollowLastSegment 2018-12-03 10:30:08 -03:00
Yorik van Havre
31b896ad07 Fixed coverity issues
184298 Bad use of null-like value
183849 Bad use of null-like value
183846 Bad use of null-like value
183845 Copy-paste error
183844 Bad use of null-like value
2018-11-19 19:17:56 -02:00
Yorik van Havre
61bc405586 Arch: Fixed py3 errors in IFC export 2018-11-08 17:23:06 -02:00
paullee
deedc12ee0 Tweak makeRailing(None) to (re)-create Railing and insert back to Stairs.Additions
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&p=260767#p260767
2018-10-07 13:48:33 -03:00
paullee
88e8e3131a Default Stairs (i.e. without Base Dwire etc.) also have Railings created
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=55d32dc42111afa6c7fdf7b0fc0f3ab7&start=90#p260764
2018-10-07 13:48:33 -03:00
paul
7b2cd33048 Merge pull request #1 from luzpaz/ArchStairs_Improvement_9
Typo fix for Archstair_Improvement9
2018-10-07 13:48:33 -03:00
paullee
644d763ea0 ArchPipe objects named as "Rail"
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&p=259085#p259085
b68934e550 (diff-fb9ac48ea14ab86d0e964fee1f4e4838)
2018-09-28 13:18:40 -03:00
paullee
b009dbee06 Add Property 'Width of Landing'; set width of different 'edge' of a Landing
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=80#p257963
https://forum.freecadweb.org/viewtopic.php?f=22&t=29709
2018-09-28 13:18:40 -03:00
paullee
84ad999c3b ArchStairs: Fix HalfTurnLeft error/bug 2018-09-26 17:10:42 +02:00
Yorik van Havre
fa37600825 Arch: python3 fix 2018-08-25 00:11:43 -03:00
paullee
999332e633 Fix railing height at starting point etc.
Discussion:

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p247814
2018-08-22 10:17:24 -03:00
paullee
57e6f2e9d2 Add Railing Height and Offset
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p247036
2018-08-22 10:17:24 -03:00
paullee
5fed56b612 'Multi-segment' continuos railing update following Stairs' changes
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=60#p246607
2018-08-20 10:52:59 -03:00
paullee
62eb4f6a4e Fix railing on 2 sides; Make continous railing for 'multi-segment' stairs; Group under 'Master Stairs'
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p246607
2018-08-20 10:52:59 -03:00
paullee
3291046564 Fixing Railing - Left & Right
Discussion:-
(Somewhere here only - Not discussed exactly here, codes not post here)
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p245038
2018-08-20 10:52:59 -03:00
paullee
3d05a97e90 Fix StraightLanding connecting bit; other TreadDepth RiserHeight issues etc.
Discussion:
(Somewhere here)
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244648
2018-08-19 11:15:58 -03:00
paullee
8e6d5060f4 'Centralise' all cases use MakeStraightStairsWithLanding method; further fix TreadDepth and RiserHeight Enforce
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244502
2018-08-19 11:15:58 -03:00
paullee
df6a4b6939 Add TreadDepth & RiserHeight Enforce properties; Fix MakeStair, MakeStraightLanding functions; Test Right Railing
Discussion:
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244502
2018-08-19 11:15:58 -03:00
paullee
89751fa07e Fix MakeStairs, _CommandStairs functions; Testing Railing (One side only)
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=50#p244345
2018-08-19 11:15:58 -03:00
paullee
b848a6a2e2 Various general bugs fixes and _CommandStairs related 2018-08-17 10:35:46 -03:00
paullee
4a1cbebf52 Add HalfTurnRight 'basic' feature, Master Stairs to accommodate differnt flight of stairs 2018-08-17 10:35:46 -03:00
paullee
35fedc0be3 Add basic MultiEdgesLanding method 2018-08-15 10:46:43 -03:00
paullee
cae9a831e3 Add AbsTop Property - Absolute Top Level of a segment/flight of stairs; To enable 'multi-segment' stairs. 2018-08-15 10:46:43 -03:00
paullee
825f0176b3 Add LastSegment Property - to enable 'multi-segment' / 'multi-flight' stairs; and fix some LandingDepth related bug. 2018-08-15 10:46:43 -03:00
paullee
91dc92331f Add HalfTurnLeft landing stairs basic feature.
- HalfTurnRight, stairs alignment etc. 'fix' added in 'later version' in my local machine not yet in this commit

Discussion posts :-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=bbca78d86eda8a6f8837fc2901d88be7#p240745
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p247814
2018-08-12 14:09:39 -03:00
Yorik van Havre
c078c4a448 Removed non-printable character at line 1 2018-08-10 10:41:50 -03:00
paullee
79df4134b0 1. Fixed typo in previous commit (item 3)
2. Added URL of discussion post / thread
3. Previous commit - Added Landing Depth Control to ArchStairs

Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358#p240197
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p249409
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p249498
2018-08-10 10:41:50 -03:00
paullee
0e6ec613f0 Add Control Landing Depth 2018-08-10 10:41:50 -03:00
Yorik van Havre
a1faed3449 Arch: using basic object names for all arch objects 2018-07-07 14:40:10 -03:00