Commit Graph

41889 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc
9709fc43de TechDraw: fix incorrect click handles of editable labels (#21131)
Fixes #20964:
- When `text` element doesn't have id
- When `text` element has transform attribute
2025-05-29 08:30:59 -04:00
pre-commit-ci[bot]
0691a2d863 [pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/pre-commit/mirrors-clang-format: 300fa4c170bf0887bb5585d17ec50901ad2625fb → c8ab0f80399e63a4fabbf5313c0606831f09742e](300fa4c170...c8ab0f8039)
2025-05-29 00:14:40 +02:00
PaddleStroke
859d4f4fa5 TechDraw: Fix DrawViewSpreadsheet being assigned wrong QGI in QGSPage.cpp (#21623) 2025-05-29 00:06:34 +02:00
dependabot[bot]
0a3c940d08 Bump github/issue-metrics from 3.20.0 to 3.20.1
Bumps [github/issue-metrics](https://github.com/github/issue-metrics) from 3.20.0 to 3.20.1.
- [Release notes](https://github.com/github/issue-metrics/releases)
- [Commits](6a0f49b4e1...119b5237f4)

---
updated-dependencies:
- dependency-name: github/issue-metrics
  dependency-version: 3.20.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-28 21:01:12 +02:00
sliptonic
4a0dec7098 Merge pull request #21530 from jffmichi/sort_all_drilling
CAM: sort locations for all drilling operations
2025-05-28 13:55:20 -05:00
sliptonic
32a8887589 Merge pull request #21528 from mosfet80/piDef
CAM: using std::numbers pi definition
2025-05-28 13:53:00 -05:00
tetektoza
8ec6605fc4 BIM: Add support for deactivation active object to BIM Views Tree (#21570)
* BIM: Use checkbox in model tree for Activation/Deactivation of WP

* BIM: Set active object after deactivating current object if it exists

Currently we can get into a scenario where user can activate two working
planes, one after another. For example, Level, and  then Level001. If
they activate both, and then deactivate Level001, working plane switches
back to Level. But, we didn't set the object as the active one, so user
didn't have clear information that they can deactivate it, only the
working plane was switching it.

So this patch sets the object as the active one, if it exists.

* BIM: Add support for deactivation active object to BIM Views Tree

As the title says - it adds the checkbox that's similarly done in Part
workbench, so user can select/deselect the item and if they had previous
active object, it will also fall back to the previous object.

Also, moved out part of the common logic from ArchBuildingPart and
BimViews to utils.

* BIM: Handle correct context on activating WP for NativeIFC/BIM

* BIM: Remove redundant logic from BIM Views upon double click

As all of the logic is being handled now in `activate` function in
BimViews, this logic is redundant

* BIM: Rename button for taskbar and BIM Views from Activate to Active
2025-05-28 11:27:11 +02:00
Yorik van Havre
1f6ecf83b2 Draft: Added snap recenter functionality (#19728)
* Allow to align the working plane on selected edge + face of a same object, which aligns the plane with the face, but positions it on the edge (the WP is positioned on the edge's first vertex, the WP's X axis is aligned with the edge, and the face's center point provides the third point to define the plane)
* Added a "Recenter" in-command shortcut. This moves the WP to be centered on the current snap position (the WorkingPlane snap button is taken into account, so one can only move the WP in the same plane or not).
2025-05-27 19:17:43 +02:00
Benjamin Nauck
6b7e4185e1 Merge pull request #21552 from alfrix/fixup_hole
PD: Fixup hole
2025-05-27 15:00:13 +02:00
Benjamin Nauck
eb51a5d784 Merge pull request #21379 from alfrix/set_style
Gui: Set QStyle to Fusion if not set
2025-05-26 22:13:31 +02:00
Luz Paz
8a5290ae86 Fix various typos
Found via codespell
2025-05-26 21:40:10 +02:00
Jacob Oursland
bc5616dbf6 CI: pin occt==7.8.1 on weekly builds. 2025-05-26 18:31:05 +02:00
Pieter Hijma
d025501755 Spreadsheet: Add tests for rename property 2025-05-26 18:11:27 +02:00
Pieter Hijma
75a9e26473 Core: Add tests for renaming dynamic properties 2025-05-26 18:11:27 +02:00
Pieter Hijma
5bdfba3a1a Core: Update expressions on property rename
This includes both expressions in generic containers and in
spreadsheets.
2025-05-26 18:11:27 +02:00
Pieter Hijma
18d87df6f1 Core: Add a Python interface for property rename 2025-05-26 18:11:27 +02:00
Pieter Hijma
e7f8f2f48c Core: Add logic to rename dynamic properties 2025-05-26 18:11:27 +02:00
chris
dc7ceddc50 fix for #20656 2025-05-26 18:07:12 +02:00
Syres916
ef4c33fee4 [Gui] InputField correct icon visibility logic on opening a pre-completed task panel 2025-05-26 17:54:39 +02:00
Chris Hennes
e4fa55a922 CAM: Ensure float constants are single-precision (#21322)
* CAM: Ensure float constants are single-precision

* Revert suggestion

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-26 17:38:34 +02:00
Syres916
0e40f2dfc5 [App] Use consistent unit schema names (#21355)
* [Start] ensure user's preferred unit schema is retained after restart of application

* [App] use consistent schema names throughout the application

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [Start] Revert commit 2eea421

in preference to PR #21466

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-26 17:33:45 +02:00
Kacper Donat
d5a091bf0c Merge pull request #21571 from alfrix/property_editor_2
Gui: property editor do not enter edit mode if the property is read-only
2025-05-26 17:20:06 +02:00
WandererFan
4dd2313425 [TD] fix small angle dims (fix #21114) (#21208)
* [TD]fix handling of very small angle dimensions

- also remove test for too small format specifier

* [TD]lint messages

* [TD]apply review comments.
2025-05-26 17:19:19 +02:00
PaddleStroke
82696359f6 TechDraw: richannotation : Fix white text issue (#21515)
* TechDraw: richannotation : Fix white text issue

* Update QGIRichAnno.cpp
2025-05-26 17:18:21 +02:00
Benjamin Bræstrup Sayoc
ade3922a31 TechDraw: fix state handling of dimensions
- Positioning was calculated using `boundingRect` while `transformOriginPoint` was set according to `tightBoundingRect`, causing mismatch when `QGIDatumLabel` contains more than text (eg. shapes around text). Now `transformOriginPoint` and positioning calculated according to `tightBoundingRect`, and setting `transformOriginPoint` of `QGIDatumLabel` are handled by itself. This fixes an issue where the gap between dimension lines and text varied depending on dimension's angle.
- `m_lineWidth` was set in multiple locations, causing confusion and bug introduction
- If `X` or `Y` property changed, the remaining changed properties were not handled due to using `if else` rather than `if` for property change checking. This became an issue due the above mentioned simplification of `m_lineWidth` setting: if `X` or `Y` had changed (upon document restore).
- Center position was uneededly saved in variables `posX` and `posY` when it could be calculated on demand using `tightBoundingRect`. Removing this uneeded state simplfies code and lowers the risk of bug introduction due to lack of updating state.
2025-05-26 17:18:04 +02:00
Alfredo Monclus
1bb05bf987 Gui: property-editor make readonly cells look disabled 2025-05-26 07:13:44 -06:00
tetektoza
8eaaaaff50 BIM: Parse Classification in IFC correctly for conversion/type assign 2025-05-26 10:24:34 +02:00
Furgo
5386ca838a BIM: add first iteration of unit tests 2025-05-26 10:23:24 +02:00
Furgo
edc4d04a41 BIM: refactor to reduce code duplication and improved readability 2025-05-26 10:23:24 +02:00
Furgo
df2e055183 BIM: remove command now removes windows from walls
Fixes: #21551
2025-05-26 09:53:21 +02:00
Furgo
92a9b1ae54 BIM: add test for window removal from walls 2025-05-26 09:53:21 +02:00
Paul Lee
8ff5c71101 [ArchWall] Fix SetLength Error When Base Sketch has External Geom
fix #21357 error message problem

Github issue and discussion:
https://github.com/FreeCAD/FreeCAD/issues/21357
https://github.com/FreeCAD/FreeCAD/issues/21357#issuecomment-2886010914

ArchWall return error when Base Sketch has external(projected) geometry.

External projected geometry has TNP-problem, until the feature is TNP-tolerant,  support of external(projected) geometry at ArchWall is not encouraged. The reported error message is fixed in the meantime in this PR.
2025-05-26 09:49:36 +02:00
Benjamin Bræstrup Sayoc
9af522c085 TechDraw: centralize usertype constants 2025-05-25 20:42:02 +02:00
Alfredo Monclus
8be84f2a9f Gui: property editor do not enter edit mode if the property is read-only 2025-05-25 06:25:09 -06:00
jffmichi
4b4a15beef CAM: sort locations for all drilling operations 2025-05-25 00:27:03 +02:00
mosfet80
41c750be47 Sketcher: Remove unused variables (#21504)
removed unused variables
2025-05-25 00:19:46 +02:00
David Carter
15ed1a07a9 Materials: Correct model spelling errors 2025-05-25 00:14:08 +02:00
Roy-043
96af3a5bba Draft: remove 'CTRL to snap' from tooltips (#20619)
The 'CTRL to snap' option is not the default, it should therefore not be included in the tooltips.

Additionally:
* Some obsolete info was removed.
* Some minor improvements,
2025-05-24 18:55:47 +02:00
Roy-043
98d4222253 Draft: Revise close task panels on doc close solution (#21546)
Use built-in feature to close the task panels. See #21253.
2025-05-24 10:25:40 +02:00
Alfredo Monclus
3aabb826aa PD: hole safeguard countersink depth calculation against possible math issues 2025-05-24 02:05:06 -06:00
David Carter
8ef8f64e9b Materials: External interface refinements (#21524) 2025-05-24 08:25:44 +02:00
longrackslabs
77a11efa0b Draft: Fix typo in arc input hint ("staring" → "starting") 2025-05-24 08:24:32 +02:00
Alfredo Monclus
07e7918baf PD: hole calculate counterbore and countersink if no standards are available 2025-05-23 20:51:35 -06:00
Alfredo Monclus
9bbddbc1f6 PD: hole fix head custom values checkbox not appearing 2025-05-23 20:51:28 -06:00
Alfredo Monclus
ff17eb611a PD: hole: calculate depth of countersink and adjust other parameters accordingly when changed 2025-05-23 17:36:26 -06:00
Alfredo Monclus
236c287f16 PD: hole: fix standarized head cuts not working in metric regular sizes 2025-05-23 14:15:44 -06:00
saso badovinac
a969f31573 Update codeql.yml
disable cpp scan on pull requests and enable actions scan
2025-05-23 15:10:01 +02:00
Benjamin Nauck
e4eeb66626 Merge pull request #21289 from tetektoza/fix/fix_transparency_doors_windows_ifc
BIM: Change from RGBT to RGBA for IFC
2025-05-23 14:10:47 +02:00
paul
62cc73c104 BIM - ArchWindow - Add AutoNormalReversed property 2025-05-23 12:08:33 +02:00
tetektoza
bcb8932930 BIM: Additional improvements for Activate button in BIM Views
This patch introduces a few things:
- changes Activate button to be first in the list
- puts it in bold text, also adding (Default) to point it is default
  action
- removes all of the hiding logic upon double click and leaving Activate
by default to be called after double-clicking a BuildingPart
2025-05-23 12:06:55 +02:00