Commit Graph

31059 Commits

Author SHA1 Message Date
berniev
ba62ec0e24 remove unused code in find pyside 2022-11-20 13:43:10 +01:00
Uwe
db837c7468 [sketch] Geo.cpp: fix compiler warning
- as reported here: https://forum.freecadweb.org/viewtopic.php?f=10&t=73647
2022-11-20 00:38:21 +01:00
wmayer
7193ea0007 Base: [skip ci] fix readability-identifier-length 2022-11-19 16:54:08 +01:00
wandererfan
23b1ed84a4 [Units]Allow querying schema for unit of measure 2022-11-19 16:49:46 +01:00
luz paz
94c9430a26 [Sketcher] fix header uniformity
Make uniform all Sketcher headers.
2022-11-19 16:04:55 +01:00
berniev
2ecd6db0e7 change ALL_UPPER_CASE constexpr definitions to camelCase 2022-11-19 16:00:36 +01:00
wmayer
cdb953c462 Part: [skip ci] fix some warnings reported by GH actions 2022-11-19 15:57:54 +01:00
marioalexis
6d74cfa383 Part: Fix endless-loop in TopoShapePy::proximity function 2022-11-19 15:31:13 +01:00
luz paz
a0ad4ebebb [Arch] fix header uniformity
Make uniforum all Arch headers
2022-11-18 20:22:24 +01:00
luz paz
ba0304462d [skip ci] Add commits to .git-blame-ignore-revs
Added:  
d1f6451f1643fe8bc2bd44bac331ea2a82e2fce0  
20dfd030c2dd7f60cbc238b27c80dec0d1314cc6  
1201c0925b83feff79bd64ea458b26a3b9dba0f2
2022-11-18 16:21:24 +01:00
Bernd Hahnebach
c8b2215bed FEM: gmsh binary location on osx, add comment 2022-11-18 12:05:36 +01:00
Bernd Hahnebach
987159dd7f FEM: add standard path for gmsh on osx 2022-11-18 12:02:22 +01:00
wmayer
47cfb7569c Arch: replace tabs with spaces 2022-11-18 11:47:17 +01:00
0penBrain
4b8b93c3b8 Sketcher: disable auto-constraint in Copy/Clone/Move commands 2022-11-18 08:18:58 +01:00
0penBrain
8a574f5a51 Sketcher: Clone: do not apply parallel constraint if angle constraint is applied on arc 2022-11-18 08:18:58 +01:00
Aapo
300ca5b206 [TD] DrawViewPart: Fix Dimension attachment on Cosmetic CenterLines upon document restore 2022-11-17 19:25:43 -05:00
luz paz
f13299a5a6 Path: remove trailing whitespace 2022-11-18 00:01:25 +01:00
luz paz
4c09fe0162 Sketcher: remove trailing whitespace 2022-11-17 23:56:13 +01:00
luz paz
e2a81c8674 Arch: remove trailing whitespace 2022-11-17 23:54:03 +01:00
wmayer
3e70636bdc App: [skip ci] fix warnings reported by GH actions 2022-11-17 23:50:34 +01:00
wmayer
e931bedb43 App: [skip ci] fix typo 2022-11-17 20:00:00 +01:00
wmayer
a8134bfb25 App: fix endless-loop in DocumentObject::getParents 2022-11-17 19:05:32 +01:00
wmayer
cd34494063 App: replace boolean with enum 2022-11-17 17:38:31 +01:00
wmayer
701998e899 App: fix endless-loop when recursively determining placement of an object 2022-11-17 15:46:06 +01:00
sliptonic
9515e169b5 Merge pull request #7759 from LarryWoestman/staging
Path:  Changes for Path refactoring to fix regressions.
2022-11-16 18:09:38 -06:00
wmayer
87ed32c3a7 App: fix possible stack overflow in GroupExtension::hasObject() 2022-11-17 00:30:44 +01:00
wmayer
a3ea47a58b Gui: [skip ci] use full namespace of AccelLineEdit 2022-11-16 23:26:08 +01:00
wmayer
c088ba55f9 Gui: fix endless-loop in View3DInventorSelection::checkGroupOnTop 2022-11-16 21:02:49 +01:00
wmayer
308cf4ffb0 Gui: code-refactoring
Split selection handling from View3DInventorViewer and move to View3DInventorSelection
2022-11-16 20:27:14 +01:00
Ajinkya Dahale
e1485388d4 [Sketcher][planegcs] Make changes as per comments on #7484
Comments by @abdullahtahiriyo.

Remove default values and smaller constructor for `CenterOfGravity` and
`WeightedLinearCombination` constraints.

Clarify comments.

Improve readability of `CenterOfGravity` and `WeightedLinearCombination`
constraints.
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
473a380b49 [Sketcher][planegcs] Set knot constraint as internal alignment 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
f75bd1eed7 [Sketcher] Do not make knots construction points 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
e1d72a3023 [Sketcher] Stop treating knots as fixed in GUI commands
This stops constraints from becoming non-driving when not set.

Follow 0penbrain's comments

typo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
ba4f2bf128 [Sketcher] Constrain B-spline knots as linear combination of poles
Also squashes:

[Sketcher] Create center of gravity constraint in planegcs

[Sketcher] typo

[Sketcher] Use accurate "weights" for knots

By weights we mean the linear combination factor B_i(x) such that
spline(x) = sum(pole_i * B_i(x)) for _non-rational_ splines.

[Sketcher] Use more appropriate weights for knots

These are relevant for knots _away_ from any ends (and possibly other high
multiplicity knots).

[Sketcher] Make COG constraint weights user-definable

[Sketcher] Make `flattenedknots` for periodic B-Splines

[Sketcher] Fix incorrect setup of `flattenedknots`

Without ensuring enough space, iterators become invalid. These iterators are
needed because for periodic B-splines we need to pad flattenedknots with offset
values within flattenedknots.

Apparently there is still some iterator issues even after the reserve. Just use
fresh vectors instead.

[Sketcher] Apply knot constraints by parameter

Hopefully this will allow directly applying constraints on knots.

[Sketcher] Disable some knot updating

[Sketcher] Use center of gravity constraint on knots

[Sketcher] Fix knot COG constraint for periodic splines

[Sketcher] Add start/end point of periodic spline to solver

This removes the trouble of transferring constraints to the underlying knot.

[Sketcher] Support knot constraints on rational B-splines

[Sketcher] Remove virtual from overridden methods in planegcs

Follow 0penbrain's comments

[Sketcher][planegcs] Use `unsigned int` in signatures

Also `size_t` at places

Suggestions by @abdullahtahiriyo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
bad4406387 [Sketcher] Reformat some if-else for readability
Weren't folding right in spacemacs.
This commit can be omitted if undesired.
2022-11-16 15:35:37 +01:00
wandererfan
59e2aa9189 [TD]fix alignment of section line marks on rotated base view 2022-11-16 08:56:00 -05:00
0penBrain
44c77e5542 [Typo]Sketcher: 'Clone' is the first command of CompCopy, match the tooltip 2022-11-16 14:48:39 +01:00
wmayer
5166ca54c0 Gui: MSVC requires a user-defined destructor of RecentFilesAction
otherwise the class declaration of Private is needed in the header file
2022-11-16 12:46:47 +01:00
Yorik van Havre
eb217f7e66 Merge pull request #7526 from paullee0/ArchWall_15_UseAndCreate-ArchSketch-If-Present
[ArchWall]  Use and Create ArchSketch if add-on is present
2022-11-16 11:08:11 +01:00
Yorik van Havre
27eb4fdf80 Merge pull request #7786 from Roy-043/Draft-housekeeping-rename-snap-icons
Draft: housekeeping: rename snap icons
2022-11-16 09:58:47 +01:00
wmayer
77bae9c9a0 TD: fix memory leaks with raw pointers of GeometryObject
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
2022-11-15 16:16:08 -05:00
luz paz
48b8869b42 [skip ci] Add commits to .git-blame-ignore-revs
Added:  
f02978c1b43bd0201a458ebab2ade8682ef6cc6d  
48365a1df5286c7a5608cd3a5cce0def5e4d5380
2022-11-15 14:30:28 -06:00
luz paz
2f1ff7928b Part: remove trailing whitespace 2022-11-15 14:19:30 -06:00
luz paz
52af260eb8 [skip ci] Add commits to .git-blame-ignore-revs
Added: 
5033d112f024d9d535932507e31430e99c30c420  
c1a05eb4618b3293c48577d65a96c3151dfd605f
2022-11-15 16:17:47 +01:00
luz paz
2d94a99740 TechDraw: remove trailing whitespace 2022-11-15 16:17:22 +01:00
luz paz
be783892bb MeshPart: remove trailing whitespace 2022-11-15 12:45:52 +01:00
wmayer
c5522245fa App: fix memory leak and consistently use Py::asObject() in DocumentObserverPython 2022-11-15 11:04:41 +01:00
wmayer
ea1d29230e Gui: [skip ci] consistently use Py::asObject() in DocumentObserverPython 2022-11-15 11:04:07 +01:00
luz paz
c174e063f3 Mesh: remove trailing whitespace 2022-11-14 21:37:03 -06:00
wandererfan
356faf94da [TD]prevent Complex Section with no Base View 2022-11-14 19:41:12 -05:00