Commit Graph

1908 Commits

Author SHA1 Message Date
Uwe
fb99e37727 [TD] remove unnecessary nullptr checks 2022-07-26 00:28:57 +02:00
wmayer
c5910c1530 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
luz paz
e3bdf0a1ef Fix typos in Part and TechDraw workbenches
[skip ci]
2022-07-21 15:15:35 +02:00
Benjamin Bræstrup Sayoc
7ee5be032d [TechDraw] Improve readability of DrawViewDetail.cpp
[TechDraw] Improve readability of DrawViewDimension.cpp

[TechDraw] Improve readability of DrawViewDimExtent.cpp

[TechDraw] Improve readability of DrawViewDraft.cpp

[TechDraw] Improve readability of DrawViewImage.cpp

[TechDraw] Improve readability of DrawViewMulti.cpp
2022-07-20 16:44:26 -04:00
edi271
a1b7e3e33b [TD] Add SurfaceFinishSymbol command
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2022-07-20 16:13:56 -04:00
Wanderer Fan
cc2648b399 [TD]review comments and rebase for PR7197 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
5fcea95ed1 [TechDraw] Improve readability of DrawViewClip.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
0072e423b8 [TechDraw] Improve readability of DrawViewBalloon.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
86ec5d0a09 [TechDraw] Improve readability of DrawViewArch.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
361012df77 [TechDraw] Improve readability of DrawViewAnnotation.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
23c2c47386 [TechDraw] Improve readability of DrawTile.cpp 2022-07-20 12:59:12 -04:00
Benjamin Bræstrup Sayoc
88b52bd00d [TechDraw] Improve readability of DrawRichAnno.cpp 2022-07-20 12:59:12 -04:00
Uwe
b2bb479788 [TD] last part of removal of superfluous nullptr checks 2022-07-20 12:17:16 +02:00
Uwe
b81d7e4864 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
7b4e5d7522 [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Uwe
15ec3e2cda [TD] Gui: remove more superfluous nullptr checks 2022-07-19 03:40:32 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Uwe
36add10c86 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Uwe
22fb8ed337 [TD] fix compilation on MSVC
- CLMODE was used before its declaration, therefore it did not compile
forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=70316
2022-07-17 00:26:13 +02:00
Benjamin Bræstrup Sayoc
f604c32c4d [TechDraw] Improve readability of DrawUtil.cpp 2022-07-16 16:00:43 -04:00
Benjamin Bræstrup Sayoc
f7c236a071 [TechDraw] Gather rotation calculations in a single function 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
dd4e7ff159 [TechDraw] Improve readability of Cosmetic.cpp 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
6356459ab6 [TechDraw] Refactor CosmeticEdge constructors
Use constructor delegation and default parameters for CosmeticEdge
2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
a5e10cc49b [TechDraw] Use constructor delegation for CosmeticEdge 2022-07-16 16:00:10 -04:00
Benjamin Bræstrup Sayoc
95f1c6f240 [TechDraw] Use default parameters for LineFormat constructor 2022-07-16 16:00:10 -04:00
Wanderer Fan
c25756af8a [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
94dde1b9fb [TD]fix ext line gap preference 2022-07-16 11:28:38 -04:00
Benjamin Alterauge
fead475d64 Group dxf relevant files in one folder 2022-07-16 10:55:24 +02:00
Benjamin Bræstrup Sayoc
5931199b24 [TechDraw] Improve readability of ViewProviderWeld.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
85fea935ab [TechDraw] Improve readability of ViewProviderViewSection.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
3b809fe77b [TechDraw] Improve readability of ViewProviderViewPart.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
fc3fdf337c [TechDraw] Improve readability of ViewProviderTemplate.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
a006618177 [TechDraw] Improve readability of ViewProviderRichAnno.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
5302576015 [TechDraw] Improve readability of ViewProviderProjGroupItem.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
51b9c1df14 [TechDraw] Improve readability of ViewProviderPage.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
92997d1338 [TechDraw] Improve readability of ViewProviderLeader.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
b3f7458a2e [TechDraw] Improve readability of ViewProviderHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
2309dfc547 [TechDraw] Improve readability of ViewProviderGeomHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
5d29f60040 [TechDraw] Improve readability of ViewProviderGeomHatch.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
2cd5adc0f9 [TechDraw] Improve readability of ViewProviderBalloon.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
3f277ddb16 [TechDraw] Improve readability of TaskWeldingSymbol.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
75db87a1ee [TechDraw] Improve readability of TaskSelectLineAttributes.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
c4de72c93c [TechDraw] Improve readability of TaskSectionView.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
9c0c565ecb [TechDraw] Improve readability of TaskRichAnno.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
47b98c0684 [TechDraw] Improve readability of TaskProjGroup.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
096f471426 [TechDraw] Improve readability of TaskLineDim.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
664426d394 [TechDraw] Improve readability of TaskLeaderLine.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
b2b2f6aabf [TechDraw] Improve readability of TaskDetail.cpp 2022-07-15 11:31:11 -04:00
Benjamin Bræstrup Sayoc
ec2dc0f495 [TechDraw] Improve readability of TaskCenterLine.cpp 2022-07-15 11:31:11 -04:00