Commit Graph

1148 Commits

Author SHA1 Message Date
wmayer
bd4736bf0d implement PropertyConstraintListItem::assignProperty to add item for each datum constraint 2017-12-30 19:49:34 +01:00
wmayer
6ee4be519d fix heap corruption due to invalid static_cast 2017-12-29 22:32:10 +01:00
luzpaz
048c787e32 Sketcher: comment typos 2017-12-25 10:59:48 +01:00
wmayer
c18bc414bb fixes #0003252: External geometry tool keeps hovered item active after leaving 2017-12-25 10:47:51 +01:00
wmayer
511835e098 restore removed link to preferences-sketcher.svg 2017-12-23 17:07:12 +01:00
Abdullah Tahiri
434a47d61c Sketcher: new UI command for arbitrary sides polygon
fixes #1639
2017-12-23 14:45:39 +01:00
Abdullah Tahiri
27c202a1f0 Sketcher: Dialog for arbritary sides regular polygon 2017-12-23 14:45:39 +01:00
Abdullah Tahiri
d0c1b147dd Sketcher: Icons for arbitrary regular polygon 2017-12-23 14:45:39 +01:00
Abdullah Tahiri
c54c08cca4 Sketcher: Wrong mapping of constraints to axes
==============================================

Expressions for remapping of geometry where simply wrong.

Surprisingly no bug reports were filed for this one.
2017-12-12 23:08:44 +01:00
Abdullah Tahiri
588f1bd795 Sketcher: Merge, copy expressions
===================================

Support for copying expressions instead of hard values.

fixes #2936
2017-12-12 23:08:44 +01:00
Abdullah Tahiri
9b781f9c54 Sketcher Solver: Means to reset the initilization of movement
=============================================================

Just amazed it was working "so well" without never reseting to zero this.

It might bring advantages and close bugs... who knows!
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
ad855c99e3 Sketcher: New Setting for improved dragging mode 2017-12-12 22:20:27 +01:00
Abdullah Tahiri
023e319b84 Sketcher: Clean code and adapt previous solution only to non-relative cases
===========================================================================

Cleaning up ViewProviderSketch, as relative mode is never used for points.

Adapting the recalculation of the initial solution only to non-relative cases.

For relative movement cases (movePoint with relative=true) no cases where such a solution will be advantageous have been identified
and applying a similar solution involves changing the current behaviour too much, as to run the risk of introducing further bugs.

Decision to be revised if such cases where an advantage can be found are discovered.
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
eff8529ec6 Sketcher: jumping while dragging - force recalculate initial solution
=====================================================================

fixes #1734

Upon dragging, the initial solution is first calculated and them DogLeg is left with the work of solving for a solution next to the initial solution.

When the change is too big and the gradients are no longer accurate to continue dragging, the dragging flips and jumps.

The solution offered here is, not to update always the solution, as this also creates artifacts, but update it if the dragging goes beyond 20 times the initial dragging distance.

https://forum.freecadweb.org/viewtopic.php?f=3&t=7589#p203580

https://forum.freecadweb.org/viewtopic.php?f=3&t=7589#p203712
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
eb40ddda4e Sketcher: Do not show support when entering sketch edit mode if it is a datum plane
=====================================================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25700
2017-12-07 11:39:35 +01:00
Abdullah Tahiri
324c31d4e2 Sketcher: Fixing Polyline Arc Endpoint autoconstraints
======================================================

fixes #3091

Autoconstraints did not check whether the arc was CW or CCW, as such the autoconstraint on the second position was sometimes assigned to the start point.
2017-12-07 11:31:35 +01:00
Abdullah Tahiri
4006c6ee97 Sketcher: Fixes no horizontal/vertical on edge if previous horizontal/vert aligment on vertex
=============================================================================================

fixes #3257
2017-12-07 11:11:40 +01:00
Abdullah Tahiri
2e1d219377 Sketcher: Fix Polygon disappearing on creation with autoconstraints on
======================================================================

Fixes #3154

About the fix:
- If a non-zero vector is passed to seekAutoConstraint, it will suggest a vertical/horizontal constraint, which does not
make sense in the construction method.
- Passing a zero vector enables to treat it like a point, so for example point on object will be suggested, but not vertical/horizontal constraints.
2017-12-07 10:59:49 +01:00
Abdullah Tahiri
a680961406 Sketcher: BSpline, prevent 0 mm Radius for poles on creation
============================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25701
2017-12-07 10:52:28 +01:00
Unknown
3d9ecab346 SVG cleanup: remove all redundant <dc:title> content
Removed duplicate mentions of `[agryson] Alexander Gryson`
2017-12-02 14:02:14 +01:00
wmayer
adfcd154c6 fixes #0003176: Sketcher: always over-constrained when referencing external B-Spline 2017-12-02 13:02:42 +01:00
wmayer
651ff24481 when painting items make sure that constraint id is in range 2017-12-02 10:11:45 +01:00
Eivind Kvedalen
ea487bb948 Sketcher: Fixed regression in fix for issue #3245. 2017-11-28 19:14:57 +01:00
wmayer
2059d47e2c move encodeAttribute from Property to Persitence to avoid code duplication 2017-11-26 18:38:45 +01:00
wmayer
399dca7cb3 fix crashes when using sketch tools 2017-11-23 13:22:37 +01:00
wmayer
99a2fd16f4 fixes #0002290: Point-on-object constraint icon not selectable 2017-11-20 14:06:12 +01:00
wmayer
046954a05b fix coverity issues 2017-11-18 18:07:00 +01:00
Jeff
c770ce7a34 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
luzpaz
706141b967 Make uniform the use of B-spline visible to users
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=25411
This commit does not include fixes to source  comments unless they were 'doxygenated'.
No .xml files were altered either.
2017-11-17 19:30:37 -05:00
Eivind Kvedalen
36301ff67b Sketcher: Fix for issue #3245, including regression test. 2017-11-16 21:44:23 +01:00
luzpaz
987b8db0b5 More typos, grammar fixes, uniformity 2017-11-15 10:46:43 -05:00
wmayer
ca36e884bd fix German translation 2017-11-12 16:37:06 +01:00
wmayer
209271078b fix German translation 2017-11-12 00:54:51 +01:00
wmayer
74d1aa72ea fix German translation 2017-11-11 22:47:12 +01:00
DeepSOIC
db26cbcc4c Sketcher: fix false detection of doubleclick
Double-click detector code was comparing double-click threshold (value =
5) with distance between clicked objects in model space (i.e.
double-click distance threshold was equal to 5 mm in model space
regardless of zoom). The fix changes the comparison to pixels on screen
instead.

This fixes the inability to select sketch entities in quick succession,
when the sketch is small (i.e. less than 40 mm or so).
2017-11-10 18:12:48 +03:00
Abdullah Tahiri
41deaf82dd Sketcher: Delete all geometry menu command (in sketcher tools) 2017-11-06 14:18:12 +01:00
Abdullah Tahiri
3aec9b3859 Sketcher: Python command to delete all internal geometry and constraints of an sketch 2017-11-06 14:18:12 +01:00
Abdullah Tahiri
e4a52991b6 Sketcher: Restore inter-body expression engine links in Carbon Copy 2017-11-02 19:52:26 +01:00
wmayer
a16f5bf9aa override onExtendedDocumentRestored in AttachExtension 2017-10-25 22:52:39 +02:00
Yorik van Havre
cfe2d134a2 Updated translations from crowdin 2017-10-23 18:32:02 -02:00
wmayer
f5b6694c83 fixes #0002434: merge sketches produces sketch on XY plane when original sketches were on XZ 2017-10-18 21:17:15 +02:00
wmayer
6786bb4c79 issue #0002613: Create symmetric geometry with conic 2017-10-16 15:56:32 +02:00
wmayer
c9fb7985f9 issue #0002613: Create symmetric geometry with conic 2017-10-16 15:49:05 +02:00
wmayer
520ec2c095 issue #0002613: Create symmetric geometry with conic 2017-10-16 15:31:04 +02:00
wmayer
8b2fcf3677 fix several kind of warnings:
+ fix -Wparentheses/-Wlogical-op-parentheses
+ fix -Wunused-variable
+ disable -Wundefined-var-template due to many false-positives (clang)
+ fix -Winconsistent-missing-override
+ fix -Wmaybe-uninitialized
2017-10-15 19:12:07 +02:00
Unknown
772c5b1970 Doxygen Typos
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
wmayer
fb2b9d6cef remove possibility of directly cross-referencing other body, use shape binder instead! 2017-10-13 17:28:21 +02:00
Unknown
15c0d38536 Capitalize beginning of tooltips + Typos
Capitalized all remaining uncapitalized tooltips. 
+ Fixed typo in instantiate() function. Shouldn't have any repercussions on the code, AFAICT. 
+ other typos
2017-10-13 00:26:53 +02:00
wmayer
1be2d52deb whitespace improvements + some optimizations 2017-10-12 11:22:10 +02:00
wmayer
4c7841c071 don't select circle/ellipse center if not inside selection box 2017-10-12 11:07:27 +02:00