Commit Graph

38918 Commits

Author SHA1 Message Date
Furgo
be5255e9bf Create the assembly object inside the list of commands 2024-10-07 17:48:00 +02:00
Florian Foinant-Willig
c1c9cb63e0 Fix duplicate calculation at Task validation 2024-10-07 17:46:21 +02:00
mwganson
98f57c9ecc [Step Import] fix issue with non-latin characters in import path 2024-10-07 17:43:14 +02:00
marcuspollio
91a68b1b58 Start: little layout tweak to First Start Region 2024-10-07 17:41:42 +02:00
wmayer
4fe1513365 TD: Fix compiler warnings
This fixes the compiler warning: unused parameter 'mode' [-Wunused-parameter]

It's a regression of #16889 to not initialize the class member m_createMode any more that causes UB,
i.e. whenever m_createMode is accessed it may return an unexpected value.
2024-10-07 17:40:32 +02:00
Yorik van Havre
6c3c559225 Merge pull request #16963 from FlachyJoe/fix_primitivePlacement
PartDesign: Fix primitive placement
2024-10-07 17:39:27 +02:00
Unl0gic
4a617bf326 Update SurfaceSupport.py
- Fixed mapping v_bit to ConeCutter
2024-10-07 17:35:02 +02:00
wandererfan
528c2a0a17 [TD]fix parallel edge test (fix #16851)
- missing normalization before test
2024-10-07 17:34:11 +02:00
Benjamin Bræstrup Sayoc
5ce6c7933a [Sketcher] If origin selected: don't do distance to origin
In auto constrainer. Fixes #12684
2024-10-07 09:02:43 -05:00
mwganson
dfafbfb040 [PartDesign AllowCompound] recompute all features when AllowCompound property is changed either from true to false or from false to true 2024-10-07 08:56:07 -05:00
shai
f43444c03e Fix issue #17035 2024-10-07 08:35:43 -05:00
Eric Price
2d0fc0a177 Changed QuickMeasurement to be conservative (#17060)
* Changed QuickMeasurement to be conservative

QuickMeasurement should not measure while tool dialogs are open
this includes but is not limited to editing sketches
also changed several other sanity checks to be opt-in vs opt-out, as discussed.

* move the test if it is safe to measure to when the measurement actually happens - avoids any potential race conditions
2024-10-07 08:33:31 -05:00
Roy-043
24b9f75d5a BIM: BimWall add missing imports
Fixes #16996.
2024-10-07 15:21:11 +02:00
Roy-043
8875672e78 Draft: avoid confusing SVG warning for nested circles and ellipses
Forum topic:
https://forum.freecad.org/viewtopic.php?t=90942
2024-10-07 15:07:51 +02:00
bgbsww
33bea16a38 Disallow end_all_events in Gesture Nav Style 2024-10-07 15:03:17 +02:00
Roy-043
6a32980b5d More logical implementation of the fix. 2024-10-07 14:58:36 +02:00
Roy-043
f92ecfeff7 Draft: Stop draftToolBar.escape() executing multiple times
Fixes #17027.

The `DraftTaskPanel.reject()` function can be called multiple times if Esc is pressed during a fast mouse move. We need to prevent multiple calls to `draftToolBar.escape()` as this will lead to multiple calls to `gui_utils.end_all_events()` which results in a crash.
2024-10-07 14:58:36 +02:00
Max Wilfinger
8b8f591a8a Update images on XDGData and README 2024-10-07 14:54:41 +02:00
Furgo
32e09d9554 Prepend a single quote to BOM index to be interpreted as a string in generated spreadsheets 2024-10-04 08:53:02 -05:00
Roy-043
a08d5a4c1e BIM: Compatibility fix for walls based on wire or face with -Z normal
In V1.0 the handling of wall normals has changed. As a result existing walls with their Normal set to [0, 0, 0], based on wires or faces with a shape normal pointing towards -Z, would be extruded in that direction instead of towards +Z as before. To avoid this their Normal property is changed to [0, 0, 1].
2024-10-04 13:54:17 +02:00
Ajinkya Dahale
596fa2856b [Sketcher] Apply tangent autoconstraint only when Dir given
This relates to `seekAutoConstraint` and `seekAndRenderAutoConstraint`.

Fixes #16321.
2024-10-03 23:17:43 -05:00
Florian Foinant-Willig
142f2aff39 [PD Helix] allow refinement to fail 2024-10-03 21:54:07 -05:00
Chris Hennes
7a37ea9bc0 Merge pull request #16726 from bgbsww/bgbsww-AssemblySubNames
Assembly: Correctly build reference from selection subname
2024-10-03 13:46:35 -05:00
Jiří Pinkava
9008373919 Gui: fix warning with duplicate name in DlgSettingsLightSources 2024-10-03 13:22:48 -05:00
Kris Wilk
7e81287914 Placement Dialog: Use default tab order (Fix #16944) 2024-10-03 11:43:42 -05:00
Chris Hennes
d423795e2d CI: Update linter settings 2024-10-03 10:36:36 -05:00
Kris Wilk
ffa1189634 Prevent using reserved names for properties or aliases (Fix #16846) (#16902)
* Prevent naming properties with reserved words (Fix #16846)

* Prevent using reserved constant names for properties or aliases

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* App: Add unit test for isTokenAConstant

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-10-03 10:03:10 -05:00
PaddleStroke
69b4a6429e Chennes fix
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-10-03 09:59:15 -05:00
PaddleStroke
69fd894017 Assembly: Use cpp getGlobalPlacement python binding rather than reimplementing it. 2024-10-03 09:59:15 -05:00
PaddleStroke
306183ce26 Core: GeoFeature: Add python binding to the new getGlobalPlacement() 2024-10-03 09:59:15 -05:00
Frank Martinez
141a627b8f [AddonManager] Set default filter to ANY package type 2024-10-03 09:55:04 -05:00
PaddleStroke
6c494623d4 QuickMeasure: Prevent crash by limiting selection to Part::Features (#16921)
* QuickMeasure: Prevent crash by limiting selection to Part::Features

* chennes' fix

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-10-03 09:49:09 -05:00
Roy-043
ab44bd1f7b BIM: check if Width and Height of window are not zero 2024-10-02 21:49:21 -06:00
André Althaus
a10dcb2a1a Only omit edges for group children in the dependecy graph
All edges for GeoFeatureGroupExtension where omited even if the
dependency was not a child of the object.
2024-10-02 21:44:30 -06:00
André Althaus
49771dc955 Show nested groups in the dependency graph
Depending on the creation order (objectArray) some nested groups where
not shown a nested because their children where processed before the
parents.
2024-10-02 21:44:30 -06:00
wmayer
08ff1e5eeb Core: Fix macro recording when using module_io 2024-10-02 21:13:19 -06:00
Benjamin Nauck
9913d6a1aa Fix macos crashes when unhandled exceptions reaches qt 2024-10-02 21:11:41 -06:00
wmayer
6c0659711b Core: Do not save changes of a text object if the GUI document is about to be closed
This fixes #16873: Text document breaks some Analysis container objects
2024-10-02 20:42:00 -06:00
David Carter
d876e18808 Materials: Correct DiffuseColor custom attribute
Custom attributes were modified to maintain the behaviour of setting
transparencies using the DiffuseColor alpha channels
2024-10-02 20:35:09 -06:00
Pieter Hijma
eab82038ba Gui: Fix segfault in Expression Editor/VarSet 2024-10-02 20:31:20 -06:00
André Althaus
c7da5387b9 Remove the explicit dependency on Version.h from the fc_version target
This caused problems witht the Makefile generator because it doesn't
support the BYPRODUCTS option.
2024-10-02 20:30:42 -06:00
David Carter
eef681f0f9 FEM: Translation error causing a crash
An error in the Italian translation added an extra '{}' to the
translation string resulting in a dump when formatting.

This has also been updated in CrowdIn but as it's causing a crash is
also beiung changed via this PR. It should updated correctly when
doing the next translation pull.

Fixes #16704
2024-10-02 20:29:01 -06:00
Florian Foinant-Willig
22131b3c93 [PD] Fix subtractive primitive placement 2024-10-02 13:40:21 +02:00
Florian Foinant-Willig
2276ffbf0a [PD] fix change primitive AttachmentOffset move the body 2024-10-02 13:40:17 +02:00
hlorus
813ee36cb8 MeasureGui: Also hide delta measurements 2024-09-30 18:24:19 +02:00
hlorus
1f081cd15e MeasureGui: Remove leftover reset of _mMeasureObject
This was introduced in af9097ce87 due to a faulty resolve of a merge conflict
2024-09-30 18:22:58 +02:00
WandererFan
e8772751e6 [TD]Fix auto correct msg missing16892 (#16909)
* [TD]fix bad return code on auto-correct fail

* [TD]prevent changing references in property editor

- this is a "shoot yourself in the foot" practice
2024-09-30 18:20:47 +02:00
mwganson
59be5b1757 [Part CheckGeometry] prevent crash when attempting to check origin axis 2024-09-30 18:19:11 +02:00
Benjamin Nauck
de294dabca Include a warning to devs for unhandled exceptions
The same situation will cause a crash on at least macOS.
2024-09-30 18:15:14 +02:00
wandererfan
127d16eacc [TD]fix no dim repair on area (fix #16894) 2024-09-30 18:13:28 +02:00