Commit Graph

1731 Commits

Author SHA1 Message Date
Daniel Wood
a8c03357b3 remove duplicate signal 2020-04-18 12:43:39 +01:00
sliptonic
9fbaa122f7 Merge pull request #3327 from Russ4262/3D_Surface_updates
[Path] 3D Surface fixes(7), minor optimizations, and cleanup
2020-04-17 10:40:53 -05:00
sliptonic
f03c560080 Merge pull request #3331 from Russ4262/Waterline_updates
[Path] Waterline fixes(5), new IgnoreOuterAbove feature, and code simplification
2020-04-17 10:40:15 -05:00
Russell Johnson
b899d6c8b1 Path: Optimization for open edges update
Remove required usage of DocObject creation, in lieu of Part geometry usage - the preferred method.
Limit DocObject creation to debugging mode only.
Remove dependency on Draft module.
Drawback is top edge must be selected, and Final Depth set appropriately when using profiling open edges.
2020-04-16 12:53:32 -05:00
Russell Johnson
dc8befa478 Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:35:05 -05:00
Russell Johnson
28abb95ea5 Path: Add new support module for 3D Surface and Waterline 2020-04-16 00:28:33 -05:00
Russell Johnson
4cd4b2e879 Path: Comment cleanup; adjust messages; set 2 default values 2020-04-16 00:28:33 -05:00
Russell Johnson
cb796ca2c9 Path: Implement new module PathSurfaceSupport; Add Spiral cut pattern
New module is shared with 3D Surface operation. Module contains PathGeometryGenerator class. More common methods can be moved into the new module.
2020-04-16 00:28:25 -05:00
Russell Johnson
aaf1eee7c5 Path: Preparation for making property defaults readable through class 2020-04-16 00:28:18 -05:00
Russell Johnson
eb354c3a1d Path: Improve backwards compatibility capabilities 2020-04-16 00:28:11 -05:00
Russell Johnson
ed85341cd9 Path: Improve property visibility in Data tab 2020-04-16 00:28:04 -05:00
Russell Johnson
a0cecce62e Path: Expose operation's property details to access via class 2020-04-16 00:27:58 -05:00
Russell Johnson
9e9d5ce962 Path: Fix weakness in face analysis for unique OuterWire cases
synced with PathSurface module
2020-04-16 00:27:49 -05:00
Russell Johnson
aa1261dc7d Path: Waterline fixes(5), new IgnoreOuterAbove, and code simplification
Fix module base for getFacets()
Fix isOnLineSegment() usage.
Fix property visibility in Data tab.
Fix missing raise to SafeHeight after clearing layer.
Fix handling of `import ocl` failure
Move Draft import to dependent function
Raise `import ocl` test in code execution
Disable face selection for Waterline and issue warning as intermediate fix. Application of face-selection from 3D Surface requires some modification for use in Waterline.  This work is to be done.  Some existing carryover methods should be usable in current form.
Compact setup() function
Sync some methods with PathSurface in preparation of extracting common methods to independent support module.
Increase SampleInterval range for OCL Dropcutter algorithm.
Convert OCL Dropcutter waterline to use FreeCAD.Vector() points rather than ocl.Point().
Simplify some code and delete unnecessary comments.
LGTM cleanup.
New feature - IgnoreOuterAbove. Ignore the outer-most waterline above this height.  Designed to eliminate the model profile path created in some use cases.
Adjust tooltip language for `Algorithm`
2020-04-16 00:27:40 -05:00
Russell Johnson
c0a5a8c97e Path: Improve Tasks editor interaction
Swap setEnabled() method for show() and hide().
Include showing and hiding associated labels.
Path: Hide `optimizeEnabled` input
2020-04-16 00:27:06 -05:00
Russell Johnson
341da1092d Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:20:46 -05:00
Russell Johnson
0bd0d52baf Path: Simplify if ... is True: statements. 2020-04-16 00:17:47 -05:00
Russell Johnson
ccfd52477f Path: New class - PathGeometryGenerator; new CutPattern - Offset
Converted _planarMakePathGeom() into independent class, PathGeometryGenerator, as preparation to share common code with Waterline.
Implementation of new class within existing code.
Added new cut pattern: Offset.  It is ported from Waterline.
2020-04-16 00:17:40 -05:00
Russell Johnson
f6ad7101c6 Path: Create shared support module for 3D Surface and Waterline 2020-04-16 00:17:33 -05:00
Russell Johnson
fd34891c99 Path: Improve compatibility between file versions
Verify enumerations on document reload, maintaining the existing value for the property.
2020-04-16 00:17:33 -05:00
Russell Johnson
a6cb530d57 Path: Fix weakness in face analysis for unique OuterWire cases 2020-04-16 00:17:24 -05:00
Russell Johnson
f41ec732e1 Path: Added Spiral cut pattern; Adjusted tooltip language 2020-04-16 00:17:16 -05:00
Russell Johnson
b5048f4f02 Path: Multiple fixes; code optimizations and cleanup
Fix _processRotationalOp() arguments and erroneous call thereto.
Fix isOnLineSegment() usage.
Fix transition between profile edge and clearing.
Fix _planarSinglepassProcess() method.
Fix `ProfileEdges` feature.
Fix Y-axis rotation error in G-code and display.
Fix error handling of `import ocl` test.
Raise `import ocl` test in code sequence.
Convert ocl.Point scan results and handling to FreeCAD.Vector() type throughout `Rotational` scan code.
Change properties group from `Rotational` to `Rotation`.
Make operation property details accessible through class.
Relocate Draft import to dependent function.
Improve property visibility in Data tab.
Issue warning for Rotational scans if faces are selected.
Compact setup() function.
LGTM cleanup throughout.
Delete unnecessary comments.
2020-04-16 00:17:05 -05:00
Russell Johnson
c6b9adec25 Path: GUI improvement - swap setEnabled() for show() and hide()
Improve GUI usability by using hide() and show().
Apply hide() and show() to labels as well.
Fix visibility update issue on loading task window for editing of existing operation.
2020-04-16 00:14:11 -05:00
Eric Trombly
070099daa4 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
sliptonic
1ff9c0899b Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00
Eric Trombly
7fe094ac02 add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
sliptonic
1f1043bf3c Merge pull request #3333 from fra589/master
[Path] Add size parameter for syntax highlighting of GCode editor
2020-04-13 08:48:18 -05:00
Daniel Wood
15318f4957 Deburr: signal for update when values are changed 2020-04-12 06:33:34 +01:00
Patrick F
954590dd4a Added confirm dialog for table delete 2020-04-12 00:49:09 +02:00
Patrick F
abea303a88 Improved error handling 2020-04-11 19:27:37 +02:00
Gauthier
ae05df5034 Merge remote-tracking branch 'upstream/master' 2020-04-11 17:06:31 +02:00
Gauthier
bc9569515a Add size parameter for syntax highlighting of GCode editor 2020-04-11 17:05:59 +02:00
Patrick F
c94ef27e0d Add tool table list to UI 2020-04-10 22:10:35 +02:00
Patrick F
034b48f849 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into toolbit-gui 2020-04-09 21:55:28 +02:00
Russell Johnson
ad784bc7d5 Path: PEP8 cleanup
line endings fix
2020-04-07 22:17:37 -05:00
Russell Johnson
20d85edd62 Path: Fix broken Gui::QuantitySpinBox class
Now, custom expressions are applied to spinbox.
Spinbox now updates, after clicking elsewhere.
Path: Shorten for loop search
2020-04-07 22:17:37 -05:00
sliptonic
ee520f1013 user attributes kinda works. Hacked. 2020-04-07 10:09:34 -05:00
sliptonic
4030e44e41 checkpoint 2020-04-07 10:09:34 -05:00
sliptonic
baba091596 linuxcnc tool table exporter 2020-04-07 10:09:34 -05:00
sliptonic
663d5f3086 revise library editor 2020-04-07 10:09:34 -05:00
sliptonic
c200734dc6 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
Patrick F
65aee430af Removed offset check 2020-04-06 21:11:40 +02:00
Eric Trombly
5ecbc89f30 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
b631c5600a move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
2b8cd1be42 add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
0cbf56886a clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
54022ea630 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
fbc266c158 remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
651c383925 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00