Commit Graph

1731 Commits

Author SHA1 Message Date
Eric Trombly
5f648aa2c1 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
sliptonic
bb45a2b01f Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
Patrick F
b8a32610c8 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
luz.paz
cafed2a137 [skip ci] Fix typos in Path WB
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-01 13:28:48 +02:00
Patrick Felixberger
66fbec6005 Setup length depending on tool 2020-03-31 17:31:30 +02:00
Patrick Felixberger
d66ff3364e Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-31 17:18:06 +02:00
sliptonic
e76c505a17 Merge pull request #3231 from Russ4262/4th_axis_fixes
[Path] 4th-axis rotational alignment improvements;  Code clean-up
2020-03-31 08:17:18 -05:00
Russell Johnson
ebb383cc6c Path: Synchronize tooltips. Apply DepthOffset. Hide properties.
Sync tooltip text between 3D Surface and Waterline.
Also, apply `DepthOffset` to Experimental Waterline algorithm.
Hide some properties in Data tab.
2020-03-30 23:24:47 -05:00
Russell Johnson
6644d08191 Path: Implement experimental Waterline algorithm
Insert experimental Waterline algorithm that is non-OCL based.  It slices by step-down value, not stepover.
2020-03-30 22:34:57 -05:00
Russell Johnson
7d4b2f2a50 Path: Fix bug that fails Multi-pass usage 2020-03-30 22:34:57 -05:00
Russell Johnson
5d03294980 Path: Fix "increase by factor of 10" issue
Forum discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44486.
2020-03-30 22:34:57 -05:00
Russell Johnson
a907585f0d Path: Four bug fixes per forum discussion
Fix grammar mistake.
Fix Gcode comment formatting.
Fix application of `Optimize Step Over Transitions` by adjusting the offset tolerance for creating the offset cut area for the operation.
Fix math error in circular based cut patterns for small diameter cutters.
Identification of bugs begins in the forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=41997&start=210.
Path: Lower SampleInterval minimum to 0.0001mm
2020-03-30 22:34:57 -05:00
Russell Johnson
11db9553d4 Path: Add Cut Pattern selection to task panel 2020-03-30 22:34:57 -05:00
Russell Johnson
3720b57d63 Path: Add initPage() call to update GUI upon loading
Added initPage() function call updates task panel values and visibilities when user edits an existing operation.
2020-03-30 22:34:57 -05:00
Russell Johnson
3363639681 Path: Update GUI inputs for independent Waterline operation 2020-03-30 22:34:57 -05:00
Russell Johnson
d495ee202d Path: Add ScanType and LayerMode inputs
Added combo boxes with labels
Path: Remove 'Algorithm' property usage.


Path: Connect `ScanType` and `LayerMode' selections from task panel


Path: Update GUI inputs for independent 3D Surface operation
2020-03-30 22:34:57 -05:00
Russell Johnson
4109f0c7df Path: Restructure initOperation() for backward compatibility
Added initOpProperties() to handle independent creation of properties for backward compatibility and to allow for future storage of enumeration property lists within the operation.
Path: Change from PathSurface code to `Waterline`


Path: Updates and fixes


Path: Simplify code

Remove `Algorithm` and `AreaParams` property usage.
Remove other unused properties.
Simplify setupEditorProperties().
Path: Remove unused methods


Path: Update property initialization and handling

Make properties backward compatible with previous versions of the operation.
Remove references to unused properties due to 3D Surface and Waterline separation.
Path: Insert placeholder for `Experimental` algorithm


Path: Fix missing property and fix syntax

Missing `Algrorithm
2020-03-30 22:34:57 -05:00
Russell Johnson
df253cdcdc Path: Add Waterline task panel
Path: Update `Waterline` task panel and GUI code
2020-03-30 22:34:57 -05:00
Russell Johnson
a2c72feba8 Path: Add commented references for missing imported modules
PathSurfaceGui and PathWaterlineGui are imported in the initGui.py module due to OCL dependency.
2020-03-30 22:34:57 -05:00
Russell Johnson
dacb6e62f2 Path: Add Waterline selection gate
Using the same gate as PathSurface
2020-03-30 22:34:57 -05:00
Russell Johnson
312f09e81e Path: Add Waterline modules to PathScripts 2020-03-30 22:34:57 -05:00
sliptonic
f44d7451f5 Merge pull request #3290 from fra589/master
[Path] fix tool change and Feature missing output
2020-03-30 22:18:07 -05:00
sliptonic
c65d0f9858 Merge pull request #3266 from Russ4262/Fix_ProfileEdges_Open-Edges
[Path] Fix failed open edge path for zero GeometryTolerance case
2020-03-30 22:17:03 -05:00
Gauthier
1908e86e26 [Path] fix tool change and Feature missing output 2020-03-30 20:01:47 +02:00
sliptonic
4e91020c1f fix error when discretize N=1
cleanup
InitGui to add Path_Probe command
Probe setupsheet
2020-03-26 15:23:23 -05:00
sliptonic
040324c6ae discretizing 2020-03-26 13:26:05 -05:00
sliptonic
71da490688 Path: adding dressup task panel 2020-03-26 13:26:05 -05:00
sliptonic
a8483c764e Path: Finish GUI & Cleanup 2020-03-26 13:26:05 -05:00
sliptonic
4b0f4e1ac0 Path: make setupsheet handle PropertyFile 2020-03-26 13:26:05 -05:00
sliptonic
70a52a8eda Path: Layout op panel for probe 2020-03-26 13:26:05 -05:00
sliptonic
59a9ab9bc0 Path: Z depth correction from probe data 2020-03-26 13:26:05 -05:00
Russell Johnson
9b4b8fb920 Path: Apply rotation improvement to B(y) rotations 2020-03-26 10:43:32 -05:00
Russell Johnson
9239c67ec7 Path: Remove unnecessary comments
PathAreaOp
PathProfileFaces
2020-03-26 10:43:32 -05:00
Russell Johnson
7cbd3bf793 Path: Improve rotational transitions between operations
Check previous and next operations for rotation, and eliminate rotational reset if can be done.
2020-03-26 10:43:32 -05:00
Russell Johnson
0564739c5f Path: Improve 4th-axis rotation analysis and application
Fix incorrect depth calculations for envelopes.
Added solid-based model orientation check developed in PathProfileEdges open edges upgrade.
Clean-up some blank indentations.
Down-grade some messaging levels.
Add a few debug comments.
2020-03-26 10:43:32 -05:00
Russell Johnson
60329f8389 Path: Deleting blank indents 2020-03-26 10:43:32 -05:00
Russell Johnson
cbc38e988e Path: Fix failed open edge path for zero GeometryTolerance case
Add error message to inform user to set Job.GeometryTolerance to an acceptable value.
Remove creation of docObject in lieu of geometry shape usage.
2020-03-26 10:29:00 -05:00
sliptonic
ad7755e6d7 Merge pull request #3245 from Schildkroet/4th-axis-improve
[Path] Added 4th axis support to drilling GUI
2020-03-24 14:24:54 -05:00
luz.paz
76a77e4f88 [skip ci] Fix typos
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-24 11:14:24 +01:00
Patrick Felixberger
1955c62a28 Added 4th axis support to drilling GUI 2020-03-23 00:48:09 +01:00
Eric Trombly
8756ae8590 Change example_pre to use a list of commands instead of one string 2020-03-22 17:59:16 -05:00
Patrick Felixberger
7997ad73b0 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-22 23:53:08 +01:00
Eric Trombly
f66747ec15 split paths on M6 and change placement to use offset 2020-03-22 12:15:57 -05:00
Eric Trombly
0d281b91dc split paths on M6 and change placement to use offset 2020-03-22 12:10:11 -05:00
Eric Trombly
7f76c5fbc3 split paths on M6 and change placement to use offset 2020-03-22 12:06:36 -05:00
Eric Trombly
f1ebaa4cc6 change preprocessor to split lines 2020-03-22 12:06:36 -05:00
Eric Trombly
31b17055f1 initial work for modifying path of imported gcode 2020-03-22 12:06:36 -05:00
Russell Johnson
9bdbfc2a69 Fix failed Job creation due EnableRotation property error
PathAreaOp:   Add SetupProperties() function
PathPocketBase:   Modify SetupProperties() function to include return from same in PathAreaOp.
PathPocketShape:  remove blank indents
PathProfileBase:  Modify SetupProperties() function to include return from same in PathAreaOp.
PathProfileFaces:  fix `EnableRotation` issue
2020-03-21 11:05:46 -05:00
sliptonic
0ae842586e Merge pull request #3192 from Schildkroet/4th-axis-improve
[Path] 4th axis improve
2020-03-18 23:48:22 -05:00
Russell Johnson
9b47226953 Fix application of DepthOffset property 2020-03-18 12:32:45 -05:00