kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
27,087 Commits 40 Branches 6 Tags
d5ae0777d0c72752b32cd0fb56fe8db2482e3bc3
Commit Graph

1820 Commits

Author SHA1 Message Date
Ajinkya Dahale
d5ae0777d0 [PD] Correct include guard name 
Correction in `PartDesignGui::ReferenceHighllighter`
 2022-01-18 03:01:20 +01:00
wmayer
6461f9f6d2 PD: [skip ci] make uniform the license text of test modules 2022-01-17 16:38:10 +01:00
wmayer
2d1c083d9a PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
f147986fa9 App: Bugfix for NULL-Pointer dereference of Property->getName() 2022-01-16 14:30:51 +01:00
Chris Hennes
089b18f868 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
66864bbe7b [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
wmayer
a1a8de633c PD: fix small inconsistence, use forwared declaration 2022-01-14 12:22:16 +01:00
Ajinkya Dahale
b2e6f91c1d [PD] Use buttonToggled signal in PD pipe 
Combines other button toggle methods/signals/slots involved.
 2022-01-13 22:31:05 -05:00
Ajinkya Dahale
1296e2c417 [PD] Use Gui::ButtonGroup in TaskDlgPipeParameters 2022-01-13 22:31:05 -05:00
luz paz
19e984f8c9 Fix various typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2022-01-12 14:50:39 -06:00
Uwe
626425526b [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Yorik van Havre
e33ef084ff Merged crowdin translations 2022-01-10 11:23:59 +01:00
luz paz
b0fcf45513 Fix various superfluous whitespace in *.dox files 2022-01-09 21:01:42 -06:00
David Österberg
2ba95b3423 PartDesign: Improve orientation behaviour for conical helices (#5363) 
* PartDesign: Improve orientation behavior for conical helices

As identified in the forum
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136

The Freenet orientation mode does not give expected results for helices with cone angle.
By using an auxiliary helix that is axially offset it is guaranteed that the orientation frame
is always consistent with a cylindrical coordinate system.

Results will be the same as before when cone angle is 0.
 2022-01-09 22:13:15 +01:00
Uwe
f84d32d1b6 [PD] sort includes 
- to keep the overview
- removed double entries
- will make diff of pending PRs smaller
 2022-01-09 21:36:07 +01:00
wmayer
f1a265479d PD: declare signedLengthConstraint in FeatureExtrude as static class member 2022-01-09 10:53:04 +01:00
David Osterberg
968a9d83ae PartDesign: Silence noisy FeatureTransformed 
Remove several report view messages that are not necessary for everyday use.
By request from the forum (https://forum.freecadweb.org/viewtopic.php?f=3&t=64900&start=20#p558962)
 2022-01-08 15:30:39 +01:00
Uwe
38cc6f29e0 [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
5aadc54d18 [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
e2f883fcc4 [PD] Pad/Pocket: sort out common code 
- sort out a constraint used by Pad and Pocket
- also unify Length2 parameter naming
 2022-01-08 00:45:19 +01:00
Uwe
faa9658b9d [PD] remove double include 2022-01-07 21:58:16 +01:00
Uwe
9a8e055cc6 [PD] Hole: fix angle constraints 
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
 2022-01-07 20:38:05 +01:00
Uwe
7c158a3751 [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
wmayer
4e1f2d5015 PD: [skip ci] remove unused variable 2022-01-07 15:50:09 +01:00
Uwe
ccc45659b0 [PD] correct copyright 
these files were added by Werner in 2020
 2022-01-06 21:56:53 +01:00
Uwe
a6b01fa1f0 [PD] Hole: some coding style fixes 
all done by MSVC
 2022-01-06 16:18:25 +01:00
Uwe
7afcc93062 [PD] remove wrong comment 
was accidentally introduced by ma previous commit
 2022-01-06 16:15:39 +01:00
Uwe
d232f17e23 [PD] Hole: don't call onChanged on restoration 
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=10&t=65035
 2022-01-06 15:51:03 +01:00
Uwe
8df64b7426 [PD] add missing hole constraint 
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
 2022-01-06 15:39:13 +01:00
Uwe
f2b0333c75 [PD] Hole: coding style fixes 
all by MSVC
 2022-01-06 03:51:13 +01:00
Uwe
76c611ae2a [PD] remove unnecessary Unicode characters 
they cause problems: https://forum.freecadweb.org/viewtopic.php?p=559077#p559077
 2022-01-06 02:57:53 +01:00
wmayer
ddbf8e0e2d Sketcher: avoid attaching to/detaching from the same parameter group twice 2022-01-05 14:05:05 +01:00
Uwe
64b2677ac0 [PD] get rid of a CI compiler warning (#5335) 
* [PD] get rid of a CI compiler warning

The CI compiler outputs this warning:
FeaturePad.cpp:101:20: warning: variable 'obj' set but not used [-Wunused-but-set-variable]

Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
 2022-01-05 12:26:48 +01:00
Uwe
dfa62af40f [PD] avoid a single-letter variable 
(single letter variables make it hard to read and understand code quickly and are error-prone for typos)
 2022-01-05 03:16:00 +01:00
David Osterberg
a0746a0c02 PD: Fix bug in FeatureTransformed 
It is important to not include the original in the pattern because the original might not be at the tip of the feature tree. Including the original
will interfere with changes that occur further down in the feature tree

This fixes the bug identified in
https://forum.freecadweb.org/viewtopic.php?f=3&t=64900
 2022-01-05 02:27:53 +01:00
mwganson
977b602469 [PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command 2022-01-05 01:40:10 +01:00
mwganson
b8b015d0f1 [PartDesign::Scripts::Spring.py] update old example script 2022-01-03 11:45:05 +01:00
Jonas Bähr
d70faa1f5e PD: helix cleanup: remove unused strings from task panel ui 
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
 2022-01-03 11:40:29 +01:00
Jonas Bähr
88063627d2 PD: Use the helix property docs as tooltip in the task panel 
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
 2022-01-03 11:40:29 +01:00
wmayer
175ceb2d12 PD: [skip ci] remove obsolete TaskPocketParameters.ui 2022-01-01 11:50:43 +01:00
wmayer
c855a3072e PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
e1b03bc0eb [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a930d4ebac [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
Yorik van Havre
6cb3782c03 Merged crowdin translations 2021-12-29 12:20:12 +01:00
Uwe
0a27540479 [PD] refine helix intersection calculation 2021-12-24 01:40:25 +01:00
Uwe
3cff3202ef [PD] fix Helix creation bug 
Helices with zero height and zero growth are valid as long as there are no more than 1.0 turns.
 2021-12-24 01:10:21 +01:00
Zheng, Lei
d286a54fc1 PartDesign: show error on SubShapeBinder CopyOnChange failure 
The failure is not obivous as it would have been occurred in a
hidden temporary document.
 2021-12-21 21:41:02 -07:00
Zheng, Lei
2bd4404afb PartDesign: expose SubShapeBinderPython 2021-12-21 21:41:02 -07:00
Zheng, Lei
39c04e4877 PartDesign: support CopyOnChange in SubShapeBinder 2021-12-21 21:41:02 -07:00
Uwe
fa50122c33 [PD] fix a hole thread issue 
- The thread must not be deeper than the hole.
  (One could see that if one used a thread depth dimension and set
  it to the same value than the hole depth, the thread was too deep.)
 2021-12-22 02:54:49 +01:00