Commit Graph

24151 Commits

Author SHA1 Message Date
wmayer
da90fa3ba7 PD: [skip ci] drop some superfluous static_cast 2021-02-18 22:51:15 +01:00
Chris Hennes
da7c6d9172 [PD] Fix isFeatureMovable() to check null status of property
As reported by @donovaly, if you try to move a pipe that does not have
an auxilliary spine, the code segfaults. This commit adds a check to ensure
that not only does the property exist (which in this case it always does), but
also that it does not contain a null. That is a valid value for the property
to have, but cannot be itself interrogated for moveability by the isFeatureMovable
recursive call. This fix is also applied to the other similar conditions in that
function to ensure they never yield the same segmentation fault.

Forums topic: https://forum.freecadweb.org/viewtopic.php?p=479388#p479388
2021-02-18 22:44:13 +01:00
David Osterberg
fc6b98e4d7 PartDesign: Mild code cleanup of Helix 2021-02-18 21:51:44 +01:00
wmayer
2aca60be85 Gui: [skip ci] fix crash on macOS in editor of vector list property 2021-02-18 21:43:53 +01:00
Abdullah Tahiri
de7ae73915 Sketcher: Improved ViewProvider visualisation for non-rational Bsplines with non-unitary weight constraints
===========================================================================================================

OCCT forces weights of non-rationa Bsplines to be 1.0

In the presence of non-unitary weight constraints, the weight representation (constraint) has a different radius
than the circle.

This commit fixes this behaviour, by forcing the circle to match the weight constraint.

The information layer still reports OCCT weights being 1.0, but the visual artifact is fixed.
2021-02-18 17:28:38 +01:00
Abdullah Tahiri
6d0c845208 Part: Geometry - BSpline - fix weight assignment
================================================

If during assignment of weights (during the for loop iteratively setting the poles) all weights
become (temporarily) equal even though weights does not have equal values
OCCT will convert all the weights (the already assigned and those not yet assigned)
to 1.0 (nonrational b-splines have 1.0 weights). This may lead to the assignment of wrong
of weight values.

The work-around is to temporarily set the last weight to be assigned to a value different from
the current value and the to-be-assigned value for the weight at position last-to-be-assign but one.

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=478701#p478702
2021-02-18 17:28:38 +01:00
Yorik van Havre
3122859464 Merge pull request #4456 from donovaly/TD-balloon-drag
[0.19] [TD] fix dragging of balloons
2021-02-18 15:48:58 +01:00
Yorik van Havre
00b0f740ea Merge pull request #4470 from mnesarco/master
Icons for Marz, ExtMan, MnesarcoUtils Workbenches
2021-02-18 15:47:47 +01:00
Yorik van Havre
b2cb259ef5 Merge pull request #4479 from Roy-043/ArchRoof-compatibility-fix-2
[Arch] ArchRoof: Improved compatibility fix
2021-02-18 15:46:52 +01:00
wmayer
8a855f67d9 Base: [skip ci] take care of case-sensitivity of header file 2021-02-18 10:17:03 +01:00
donovaly
966540aa3a QGIViewBalloon.cpp: a fix as suggested 2021-02-18 01:41:23 +01:00
Roy-043
f9d93749bc [Arch] ArchStructure.py wrongly used Part.Line (endless line) to close a wire. 2021-02-17 23:29:01 +01:00
Roy-043
fbe7178cdb [Arch] ArchRoof: Improved compatibility fix
The check if a relative profile in turn references a relative profile has been improved. Added: run or angle of profilRel must be zero.
2021-02-17 21:35:51 +01:00
turn211
52869487a8 Gui: Add new stylesheet ProDark-FreeCAD-theme (#4472)
forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=55134
2021-02-17 13:20:30 -06:00
davidmubernal
a8fcecc722 Addon Manager: Add MakerWorkbench icon 2021-02-17 17:12:08 +01:00
Aapo
003990d4c0 Added new names to About-Credits info, tried to manually find new names from ~80 top public GitHub contributors. 2021-02-17 16:13:24 +01:00
Chris Hennes
2f98337403 [TD] Fix error in editable status of DOCUMENT_TYPE
All of the TechDraw ISO7200_Pep templates so that the DOCUMENT_TYPE area is
fully editable, allowing the user to overwrite the default contents entirely
instead of just adding to it.
2021-02-17 16:01:44 +01:00
wmayer
6a3e76addb PD: [skip ci] fix typo in comment 2021-02-17 15:55:47 +01:00
marioalexis
a0d8b26f21 FEM: Fix typo in filter function tooltip 2021-02-17 15:54:17 +01:00
wmayer
1955848194 PartDesign: [skip ci] make base object visible again if initial additive helix fails to recompute 2021-02-17 13:33:02 +01:00
David Osterberg
b0773e2b99 PartDesign: Helix: fix preview 2021-02-17 13:19:06 +01:00
wmayer
bb73b571f7 App/Gui: fix possible crash when destroying Python feature or its view provider 2021-02-17 12:00:38 +01:00
Frank D. Martinez M
2b56639a5c AddonManager: Added icons for Marz, ExtMan, MnesarcoUtils workbenches 2021-02-16 14:50:12 -05:00
sliptonic
90b970ab4f Merge pull request #4440 from mlampert/bugfix/path-invalid-base-geometry-robustness
[Path]: bugfix/invalid base geometry robustness
2021-02-16 09:27:06 -06:00
sliptonic
900612ce2b Update PathOp.py
fix typo
2021-02-16 09:25:59 -06:00
Yorik van Havre
039faa7aeb Merge pull request #4464 from luzpaz/spacemouse-warning
3Dconnexion: Clarify ambivalent console output warning [skip ci]
2021-02-16 16:25:46 +01:00
Bernd Hahnebach
3c1d251014 FEM: code formatting, revert parts of commit 058582edb5b 2021-02-16 16:17:47 +01:00
sliptonic
8388a7e730 Merge pull request #4467 from mlampert/bugfix/cleanup-redundant-check
[Path]: bugfix PVS detected redundant check
2021-02-16 09:02:09 -06:00
sliptonic
56acd0c885 Merge pull request #4455 from mlampert/bugfix/toolbit-properties-alignment
[Path]: Bugfix/toolbit properties alignment
2021-02-16 09:00:19 -06:00
Markus Lampert
5def0433cd Fixed angle detection 2021-02-15 23:23:16 -08:00
donovaly
038e35c002 QGIViewBalloon.cpp: code simplification 2021-02-16 01:51:43 +01:00
mlampert
11bfb431d2 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 16:03:28 -08:00
mlampert
500f470220 Merge branch 'master' into bugfix/path-invalid-base-geometry-robustness 2021-02-15 16:01:48 -08:00
donovaly
5932bbd6a6 [TD] fix dragging of balloons
as reported in https://forum.freecadweb.org/viewtopic.php?f=10&t=55109&start=30#p478147
dragging a balloon pollutes the undo steps destroying working with undo and drawings.
2021-02-15 22:28:13 +01:00
Markus Lampert
b3c11f5cd2 Fixed TC creation from templates if legacy tools are enabled. 2021-02-15 22:15:17 +01:00
Markus Lampert
0342e6360d Removed obsolete preference api 2021-02-15 22:15:17 +01:00
luz paz
cc0f72953f 3Dconnexion: Clarify ambivalent console output warning
This commit simply demystifies the warning that most users will see when they boot in to FreeCAD "Couldn't connect to spacenav daemon." by adding 
"Please ignore if you don't have a spacemouse."
2021-02-15 15:40:15 -05:00
mlampert
df5503b952 Merge branch 'master' into bugfix/toolbit-properties-alignment 2021-02-15 12:22:13 -08:00
Markus Lampert
abca623803 Only use IconViewProvider in PathStock when required. 2021-02-15 12:21:33 -08:00
Syres916
81b5612640 Added missing </a> as per review 2021-02-15 20:12:39 +01:00
Syres916
8f893430b9 [Start] Enable hyperlink for installed Addons
as per discussion https://forum.freecadweb.org/viewtopic.php?f=8&t=55623
2021-02-15 20:12:39 +01:00
David Osterberg
60c634c275 PartDesign: Subtractive Loft. Raise error when base is null.
Previously Subtractive loft would create a shape if there is no base
object. This is because the code is shared with Additive Loft, where
that is the right thing to do. Now we check for this, and return error
if there is nothing to subtract from.
2021-02-15 19:50:51 +01:00
Yorik van Havre
9c51b54b8c Merge pull request #4448 from luzpaz/BUG-4559
Gui: Stylesheet fix applied to all shipped stylesheets [skip ci]
2021-02-15 19:02:28 +01:00
sliptonic
66bda1a80b Merge pull request #4387 from mlampert/feature/add-experimental-features-to-preferences
[Path]: Expose experimental feature flag in preferences - with warning.
2021-02-15 10:09:53 -06:00
sliptonic
adf1c94a0c Merge pull request #4433 from J-Dunn/master
[PATH] fix conecutter core dumps #4561
2021-02-15 10:03:09 -06:00
David Osterberg
86f148175f PartDesign: Improve Helix parameter proposals
The previous initial proposed parameters could cause self intersection
when the user switches axis
2021-02-15 16:48:42 +01:00
Bernd Hahnebach
17b1dc1ae8 FEM: code formatting, pep8 2021-02-15 16:13:44 +01:00
Bernd Hahnebach
d4b35f13f4 FEM: material task panel, fix edition of Poisson Ratio 2021-02-15 16:13:38 +01:00
Bernd Hahnebach
b44075912a Arch: add BIM_Classification command before make use of it 2021-02-15 16:13:30 +01:00
Yorik van Havre
335cc13d48 Draft: Applied patch from nahshon - fixes misc errors from translation fixes 2021-02-15 15:50:45 +01:00