Commit Graph

36495 Commits

Author SHA1 Message Date
Roy-043
de65f805b9 Draft: Improve logic of Draft_Label texts
The proposed code fixes the following issues:
1. There is no check if the target object itself has a property that matches the label type.
2. If a subelement is selected that does not have the label type property, the value from the main object is displayed instead.
3. The default text is an empty string.

Example:

Currently If you select a vertex of a wire, and select "Length" as the label type, you will get the length of the wire. With the new code the text will then be "Length not available for (sub)object".

Forum topic (issue #1):
https://forum.freecad.org/viewtopic.php?t=86222
2024-03-20 18:29:01 +01:00
wmayer
43ec38ec9e Issue #11989: Segfault on "Move Object to Other Body"
The reason of the crash is a static_cast of an unknown type that causes undefined behaviour. The feature AdditiveLoft has the
property Section of type PropertyLinkSubList but the function does a static_cast to PropertyLinkList.

The solution is to use a dynamic_cast that returns null if the cast fails.
2024-03-20 18:06:23 +01:00
wmayer
1818cd998b Fixes #13011: Failure of test additionOperators when built with Qt6 2024-03-20 18:05:13 +01:00
wmayer
a7002ec6e6 Tests: add test for attach extension
Create two plane features and map the second on the first plane with map mode 'FlatFace'
2024-03-20 18:04:10 +01:00
oscarale
e0deea0068 Arch: Added longname and description to ArchSpace Text variables 2024-03-20 10:36:31 +01:00
Chris Hennes
74a3232452 Merge pull request #12943 from bgbsww/bgbsww-toponamingFeatureChamfer
Toponaming/part features chamfer, fillet; dependencies and test updates
2024-03-19 16:53:30 -05:00
bgbsww
7c812105ee Toposhape/Part: Cleanup FeatureFillet, FeatureChamfer and dependencies 2024-03-19 11:10:18 -04:00
Zheng, Lei
5da174f46e Toposhape/Part: Transfer in FeatureFillet, FeatureChamfer and dependencies 2024-03-18 22:05:25 -04:00
wmayer
9209331e59 Gui: fix several regressions caused by PR #12035
* fix hard crash in MainWindow::_updateActions() if no MDI view exists
* in MDIView::buildWindowTitle() use the label of the document because this changes when saving it while the name is immutable
* fix const correctness in MDIView::buildWindowTitle()
* do not set the modified flag of the main window in MDIView::buildWindowTitle() but in the calling instance
* move setting the main window title to Application::viewActivated to reduce code duplication
* fix missing application name if FreeCADGui is loaded as Python module
2024-03-18 23:27:51 +01:00
luzpaz
65cdbe3e89 Fix various typos throughout the codebase (#13029)
* Fix various typos throughout the codebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-03-18 16:54:30 -05:00
Chris Hennes
65efff5765 Merge pull request #12957 from bgbsww/bgbsww-toponamingMakeElementOffset
Toponaming/Part make element offset
2024-03-18 16:07:14 -05:00
sliptonic
cefe728904 Merge pull request #12909 from FlachyJoe/fix-variablelink
[Link] Fix SIGSEGV with LinkCopyOnChange=Tracking
2024-03-18 11:57:00 -06:00
Yorik van Havre
d77f958112 Draft: Made get_type aware of IFC objects 2024-03-18 18:50:56 +01:00
Yorik van Havre
5c8f026f67 Arch: Allow the IFC exporter to append to an existing IFC file 2024-03-18 18:50:28 +01:00
sliptonic
cf515f19c0 Merge pull request #13006 from maxwxyz/assembly-icons
UI: Assembly - update too similar icons
2024-03-18 11:38:36 -06:00
André Althaus
35ca189589 Fix regression in pattern reference selection
Reference selection in the GUI was accidentially changed to only
allow specific types of objects, preventing e.g. selection of a DatumPlane
for mirroring.

This restores the previous functionality.
2024-03-18 18:31:12 +01:00
sliptonic
67a31fa948 Merge pull request #12899 from yorikvanhavre/arch-array-ifc
Arch: Fixed IFC export of arrays
2024-03-18 11:25:32 -06:00
Max Wilfinger
3d5d58c418 add constraint perpendicular to the context menu if a conic and line is selected. 2024-03-18 13:24:16 -04:00
PaddleStroke
58975135f4 Sketcher: Chamfer tool (and fillet refactor) 2024-03-18 13:23:54 -04:00
PaddleStroke
e6802b049c Sketcher : fix error in className of CmdSketcherCompHorizontalVertical 2024-03-18 13:23:54 -04:00
sliptonic
8787ae45df Merge pull request #12878 from maxwxyz/view-command-group
UI/UX: Create a toolbar command group for default views
2024-03-18 11:21:32 -06:00
lyphrowny
be14bde507 FEA: fix 1d beam cross section orientation (#12833)
* FEA: fix 1d beam cross section orientation

* FEM: revert 1,2-directions to FreeCAD way; fix normal direction for z<0

* FEM: change 1-direction to +y axis

Previous commit changes the 1-direction to -y axis, however originally it was directed at +y axis. This commit makes the 1-direction face +y axis

* FEM: update cantilever tests

* FEM: relax math.isclose by adding abs tolerance
2024-03-18 18:16:10 +01:00
PaddleStroke
0012301001 Navicube : Add missing 'Fit selection' menu entry. 2024-03-18 17:37:40 +01:00
Max Wilfinger
9469f0fdad use setWindowModified() to indicate modified state and window title 2024-03-18 17:36:20 +01:00
Max Wilfinger
bdebed7d17 display current active document in main window title 2024-03-18 17:36:20 +01:00
wandererfan
87baa154ac [TD]use weak_ptr as deletion guard
- prevent crash if dimension deleted by Python while dialog
  is open
2024-03-17 13:22:51 -04:00
bgbsww
a27e91a272 Toposhape/Part: clean and add tests 2024-03-17 10:24:58 -04:00
Zheng, Lei
201d48659f Toposhape/Part: Transfer in makEOffset, makEOffsetFace, makEOffset2d 2024-03-17 10:24:58 -04:00
bgbsww
582d015eaf Clean and add tests for makeElementSolid 2024-03-17 10:24:58 -04:00
bgbsww
4688de0239 Toposhape/Part: Clean GeneralFuse, Fuse, Cut; add tests; tweak other tests 2024-03-17 10:24:58 -04:00
wmayer
48ff9ad3a1 [TD]Refactor LTNP correction code for Dimensions
- additional geometry types

- add method to handle line like bsplines

- handle deleted ref body feature

- add test for empty savedGeometry

- add switch for matcher/LTNP on/off
2024-03-17 08:56:34 -04:00
Max Wilfinger
7247789e12 update assembly icons 2024-03-17 11:21:16 +01:00
edi271
1bc62cf113 [TD] AxoLengthDimension: use getScale() instead of Scale 2024-03-16 20:00:27 -04:00
pavltom
1ead8c6f0f [TechDraw] Unify Projection Group parent linking 2024-03-16 19:59:49 -04:00
wmayer
87e0d10d33 Sketch: fixes #12480: Sketcher_CreateBSplineByInterpolation Unhandled unknown C++ exception
The interpolation of a BSpline can fail and then OCC throws an exception. Because this OCC exception isn't handled by the DrawSketchHandler the core system handles it as unknwon C++ exception
2024-03-17 00:47:43 +01:00
luzpaz
d3c5c4c091 TD: fix whitespace in CommandPositionSectionView.py
Fix header whitespace
2024-03-17 00:46:19 +01:00
luzpaz
72f719f192 TD: fix whitespace in CommandVertexCreations.py
Fix whitespace in header
2024-03-17 00:46:19 +01:00
luzpaz
6ef8494580 TD: Fix whitespace in CommandAxoLengthDimension.py
Fix header whitespace
[skip ci]
2024-03-17 00:46:19 +01:00
wmayer
9ba9092036 plugin: port FreeCAD's QtDesigner plugin to Qt6 2024-03-16 18:47:34 +01:00
Max Wilfinger
357b50d1d1 Merge pull request #12998 from maxwxyz/update-GH-labels
Update labels.yml for correct GitHub label
2024-03-16 16:04:57 +01:00
Max Wilfinger
4b6b2396ea Update labels.yml for correct GH label 2024-03-16 14:41:46 +01:00
wmayer
c68b75e807 Gui: fixes #12891: Random color not working for App::Part 2024-03-16 09:46:06 +01:00
wmayer
75d30d2b04 App: add overloaded template method getExtension()
This allows it to write more elegant code like:
auto ext = obj->getExtension<>(GroupExtension);
instead of
auto ext = dynamic_cast<GroupExtension*>(obj->getExtension(GroupExtension::getExtensionClassTypeId(), true, true));
2024-03-16 09:46:06 +01:00
wmayer
d57640005e TD: fixes #12984: Doing Ctrl-Z in TechDraw reliably causes a segfault 2024-03-16 09:43:40 +01:00
wmayer
b762cb1936 Drawing: Fixes #12953
The deprecated Drawing module still uses some classes that have been removed with Qt6.
These are the classes:
* QRegExp that is replaced with QRegularExpression
* QGLWidget that is replaced with QOpenGLWidget
2024-03-16 09:42:34 +01:00
wmayer
971a698a38 Mesh: fixes #12798: Macro not recording mesh decimation 2024-03-16 09:41:18 +01:00
wmayer
479ad3487d Mesh: add unit tests for mesh export 2024-03-16 09:39:49 +01:00
wmayer
f0881b5dbf App: Fix segmentation fault while dragging object
For more details see: https://forum.freecad.org/viewtopic.php?t=86001

The reason of the crash is that the GIL is not locked while accessing certain Python functions
2024-03-16 09:36:33 +01:00
Chris Hennes
819e99e334 Merge pull request #12885 from bgbsww/bgbsww-toponamingAttachment
Toponaming/Part:  Bring over attacher differences
2024-03-15 17:18:36 -05:00
Florian Foinant-Willig
15a9069cd2 Merge branch 'main' into fix-variablelink 2024-03-15 21:50:17 +01:00