Commit Graph

39437 Commits

Author SHA1 Message Date
Ajinkya Dahale
ed59a23778 [Sketcher] Add some utility functions to Sketcher::Constraint
`involvesGeoId`, `invovesGeoIdAndPosId`, `substituteIndexAndPos`
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
680b4bdb2e [Sketcher] Some trivial for loop changes in SketchObject 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
398c95eb66 [PartDesign] Fix TestTopologicalNamingProblem
Issue caused by refactor of `SketchObject::trim()`.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
d652db63f0 [Sketcher] Attempt to fix toponaming issue on trim refactor
TNP fix algorithm doesn't seem to like when edge with geoId 0 is deleted/made
construction after new geometry is added. Instead, we just ensure that one of
the newly added geometries becomes geoId 0 instead.

Making a `generateId(const Part::Geometry*)` was part of earlier attempts, but
still appears to remain relevant. This part can be reverted if necessary.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
30e95ee86a [Sketcher] Refactor SketchObject::trim()
DO NOT MERGE because not complete: not all constraints are not transferred.

Includes:

* Adjust `deriveConstraintsForPieces` for trim
* Make sure new points are constrained on the cutting edges
* Add constraints at trim end(s) dependent on pre-exisiting ones with cutting curve(s). Also change tests to reflect that auto-coincidence can now be applied to non-periodic curves as well.

Known issue(s):
* Some redundant constraints may be added under certain circumstances (e.g. in
presence of perpendicular-via-point)
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
bf4eed0921 [Sketcher] Refactor SketchObject::split() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
75a347490e [Sketcher] Add tests for split and trim
Includes:
* Tests for splitting and trimming of various types of curves
* Assertions on constraints expected to be added on these curves
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
077fe45acd [Sketcher] Refactor SketchObject::AutoLockTangencyAndPerpty() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
f5de512cf3 [Sketcher] Refactor SketchObject::delGeometry()
Just dropped cognitive complexity to 25.
2024-12-04 00:57:40 +05:30
Ajinkya Dahale
5bf1c3dac0 [Sketcher] Refactor SketchObject::getPoint()
...to reduce cognitive complexity.

Use templates to break longer functions. Also makes it possible to avoid
repetition of type-checking logic.
2024-12-04 00:57:39 +05:30
Ajinkya Dahale
03b143a0d1 [Sketcher][test] Add unit tests for SketchObject::getPoint() 2024-12-04 00:57:39 +05:30
Max Wilfinger
9b8e1b03bc Update stale_issues.yml
Remove print outputs
2024-12-03 20:10:27 +01:00
Aik-Siong Koh
5d143d1f59 Assembly: Simulation implementation 2024-12-03 20:07:04 +01:00
Max Wilfinger
3e70f7244d Update stale_issues.yml
fix label selection
2024-12-03 19:59:03 +01:00
Max Wilfinger
d501cb7076 fix stale action.
Add .yml extension and move to workflow folder.
2024-12-03 18:43:30 +01:00
Yorik van Havre
0cbe738e25 BIM: Support for property sets in Native IFC (#18067)
* BIM: UI to add properties and psets to IFC objects

* BIM: Support native IFC objects in BimProperties

* BIM: Support removing IFC properties

* BIM: Fixed lint issues
2024-12-03 16:08:27 +01:00
Paul Lee
578640381a [ArchWall] Further fix dumps()
Noted simply super().dumps() won't work as original method return dumps information.
2024-12-03 15:19:11 +01:00
Roy-043
aaf54262c4 BIM: import ToDo from correct file (#18221)
* BIM: import ToDo from correct file

* Oops, forgot to save some files.
2024-12-03 15:18:06 +01:00
wmayer
d1ef73dddc Fix compiler warnings 2024-12-03 10:16:08 +01:00
Ladislav Michl
e62b91ada4 Base: Drop QString-std::string conversion functions from Tools
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
2024-12-02 23:30:53 -05:00
Vincent Belpois
1a13d25811 Sketcher: remove auto-generated 'enum value' comments 2024-12-02 23:27:26 -05:00
PaddleStroke
5d937a4f84 Assembly: Insert new part (#17922)
* Assembly: Joint Object : encapsulate the joint creation widget such that the task can be subclassed and ui customized by other commands.

* Assembly: Insert New Part

* Update src/Mod/Assembly/CommandInsertNewPart.py

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2024-12-02 18:34:02 +01:00
Max Wilfinger
17b53ce42e add action/stale to keep the GitHub backlog tidy 2024-12-02 12:31:26 -05:00
Benjamin Bræstrup Sayoc
e025b1bfe2 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
Jacob Oursland
7df1a5d00a CMake: modernize to use CMAKE_<LANG>_COMPILER_LAUNCHER for ccache. 2024-12-02 12:24:50 -05:00
Pieter Hijma
46dfa2e39b Gui: Fix VarSet dialog 2 digit problem 2024-12-02 12:17:56 -05:00
Rotzbua
45ab20fd7e feat(win): add registry for silent uninstall
Entry is recommended to support the silent uninstall process without knowing the arguments.
https://nsis.sourceforge.io/Add_uninstall_information_to_Add/Remove_Programs#Recommended_values
2024-12-02 12:16:54 -05:00
PaddleStroke
734814f495 Assembly: Make ExplodedView: a group extension. So that we don't mimick group. Fixing the delete exploded view group issue 2024-12-02 12:14:43 -05:00
Fabio Rossi
d4b495bfd5 add local OndselSolver includes only when not external 2024-12-02 12:04:54 -05:00
Florian Foinant-Willig
115667f73a PartDesign: decouple refine and other geometric computation (#17008) 2024-12-02 10:57:30 -06:00
Benjamin Nauck
32e339447a Move back the assembly util functions to AssemblyUtil (#18020)
* Move back util functions to AssemblyUtils again

* Add getPropertyByName<T>() helper

* Improve constness in AssemblyUtils

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-02 10:48:48 -06:00
Yorik van Havre
94a4727ce9 BIM: Set opening name - fixes #16948 2024-12-02 11:44:52 -05:00
Yorik van Havre
923297bc61 BIM: ensure the Base has the correct type (#17264)
* BIM: ensure the Base has the correct type - fixes #16409

* BIM: refactor according to chenne's comment
2024-12-02 10:44:11 -06:00
Chris Hennes
0f9afb13fa Merge pull request #17826 from jbaehr/cam-fix-rename-cw-ccw-climb-conventional-main
CAM: Port #17655 to main: "Fix CW/CCW to Climb/Conventional rename"
2024-12-02 11:41:40 -05:00
Roy-043
bcd7373068 Solve merge conflict
OK, there was indeed a merge conflict due to reformatting.
2024-12-02 11:35:28 -05:00
luzpaz
ca9b0e4c58 Spreadsheet: use 'text' instead of 'foreground' in tooltip (#18018)
* Spreadsheet: use 'text' instead of 'foreground' in tooltip
2024-12-02 10:32:12 -06:00
Roy-043
2b2a80ac3c Pattern name Diamant -> Diamond 2024-12-02 11:40:01 +01:00
Roy-043
3c21ff425e Draft: Display default file and pattern in hatch task panel
Fixes #18197.
2024-12-02 11:40:01 +01:00
martinRenou
479cf6ebf5 Fixing OfflineRenderingUtils.guidata on BIMExample.FCstd 2024-12-02 11:36:39 +01:00
wmayer
c5bb5def46 Gui: Do not ignore alpha channel when converting QImage to SoSFImage
Fixes #18213: Sketcher constraints have black box backgrounds
2024-12-01 20:14:00 -05:00
Stephen Hurd
9749a07130 Fix compile on FreeBSD with spnav
If spnav is installed on a FreeBSD system, it will be detected,
but the build will fail.  With this change, it both builds
successfully and works on FreeBSD.
2024-12-01 10:40:30 +01:00
mosfet80
0bdb8a0e22 Disable python2 support
Disable python2 support
2024-12-01 10:39:48 +01:00
wmayer
e4b7d7a29f RE: Fix dialog title 2024-11-30 18:52:23 +01:00
mosfet80
5e9f2cf6ad Clean MainWindow.cpp
Removed unused code
2024-11-30 14:13:46 +01:00
mosfet80
30c0b92f70 Update ubuntu.sh 2024-11-30 14:09:16 +01:00
mosfet80
54b614dc44 Update debian.sh 2024-11-30 14:09:16 +01:00
mosfet80
1d73ad0a0c Update sub_buildUbuntu2004.yml 2024-11-30 14:09:16 +01:00
mosfet80
19cb4aa226 Remove spd lib include 2024-11-30 14:09:16 +01:00
wmayer
f72679f6a5 Fix compiler warnings 2024-11-30 00:46:05 +01:00
Chris Mayo
7aedf91a1c Remove MeshPy::coarsen() and code using GTS
FC_USE_GTS not used since before:
1162aaea88 ("Remove references to gts and ode", 2012-07-05)

GTSAlgos.h and GTSAlgos.cpp removed in:
db5c8f7db8 ("[Mesh] remove GTSAlgos", 2022-11-11)

MeshPy::coarsen() added not later than 2011 and never implemented.
2024-11-29 23:42:28 +01:00