Commit Graph

127 Commits

Author SHA1 Message Date
luz.paz
1319bfe11c LGTM: Fix 'testing equality to None'
Testing whether an object is `None` using the `==` operator is inefficient and potentially incorrect.
2020-04-22 12:18:33 +02:00
Yorik van Havre
0ea99fd22e Draft: Fixed div by zero error in snapping 2020-04-14 16:01:29 +02:00
wandererfan
093b6d9901 [Draft]support BSplineCurve in getNormal 2020-04-10 12:52:52 -04:00
vocx-fc
173f509349 Draft: DraftGeomUtils clean up docstrings and spaces 2020-04-07 18:12:06 +02:00
vocx-fc
95b8b6ebc4 Draft: DraftGeomUtils clean up imports, and Python 2 compatibility
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Also fix copying of a list in order to keep compatibility
with Python 2.
2020-04-07 18:12:06 +02:00
luz.paz
c8cb520887 [skip ci] fix follow-up typos 2020-03-06 14:50:35 +01:00
luz.paz
ebe194a9e9 Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
paullee0
f77a6949c9 [ArchWall, DraftGeomUtils] fix bug: ArchWall with Offset Attribute set and based on Sketch fails at some cases
DraftGeomUtils.offsetWire() supports ArchWall Offset setting inherently now.

Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=42933
2020-02-10 11:19:47 +01:00
paullee0
0f38aad7ba [DraftGeomUtils] OffsetWire() to accept input as Face as previously did.
Forum Discussion -
https://forum.freecadweb.org/viewtopic.php?f=23&t=42282&p=359233#p359233
2020-01-10 10:08:00 +01:00
paullee0
7acfb3b0f3 [ DraftGeomUtils ] - Fix Indent as commented on Github 2020-01-08 15:22:54 +01:00
paullee0
4818fc4ab4 [DraftGeomUtils] - Add per edge Align support
Per edge align feature
- OffsetWire() function is per-edge-aware of aligns information (alignList) for offsettg individual edge
- Instead of using dvec which universally offseting all edge consistently, it calculate vector per edge for offseting
- 2 modes of 'offsetting' to get 2 'offseted' wires from a basewire taking into per-each align info

It accept a normal info to make e.g. all wires in a Sketch gain consistent direction, instead of calculating from indiviual wires
2020-01-08 15:22:54 +01:00
paullee0
52947e5adc [DraftGeomUtils] isReallyClosed(): Add back support to test if wire is Circle / Ellipse 2020-01-07 07:16:41 -03:00
luz.paz
8cfa85cf18 Draft: [skip ci] Fix header uniformity
This PR fixes header uniformity across all Draft files
2019-12-27 00:16:12 +01:00
luz.paz
e804698edc Draft: use string operator instead of numeric LGTM fix 2019-10-25 10:25:31 -03:00
luz.paz
30a717beac Fix typos and misc. formatting [skip ci]
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-10-21 16:02:23 -03:00
Yorik van Havre
7c556b5daa Removed tabs 2019-10-21 15:58:44 -03:00
paullee0
f1219d5e7f [Draft - DraftGeoUtils] Refine isReallyClosed() : Part of ArchWall / DraftGeomUtils Multi-Width Support Improvement Proposal 2019-10-21 15:58:44 -03:00
Yorik van Havre
24caf8dab1 Draft: Fixed text color and faces with holes in SVG rendering 2019-08-28 20:09:25 -03:00
luz.paz
0f36eedc0b Fix typos
Found via `codespell -q 3 -I ../fc-word-whitelist.txt -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller`
2019-07-16 11:21:52 -03:00
Yorik van Havre
a6334a4bfd Cleanup in doxygen stuff 2019-07-15 23:20:52 -03:00
paullee0
b7907e0fd8 ArchWall_DraftGeomUtils Multi-Width support added
Discussion:- https://forum.freecadweb.org/viewtopic.php?f=23&t=36772&p=319829#p319829
2019-07-13 12:52:20 -03:00
paullee0
a8c5acbeaa Fix offsetWire() to treat wire with 1 edge (circle e.g) correctly (no need to connect()) 2019-06-27 11:30:59 -03:00
luz.paz
9845c002ab Misc. source comment typo and whitespace fixes
Found via codespell
2019-06-16 20:47:07 +02:00
Yorik van Havre
c4d61de818 Better vertices comparison 2019-04-07 12:15:50 -03:00
paullee0
b4618137c9 Fix findIntersection() can't find coincident points due to overspecifying Precision by user
- Cap Precision in precision()
2019-04-07 12:15:50 -03:00
paullee0
25afa7ae36 OffsetWire() - Seems has repeatedly sortEdges, remark out here
- edges = Part.__sortEdges__(wire.Edges)
2019-04-07 12:15:50 -03:00
paullee0
ca0db24704 Fix connect() bug - If prev v2 had been calculated, do not calculate again, just use it as current v1
- avoid chance of slight difference in result
2019-04-07 12:15:50 -03:00
paullee0
11cba4f715 Fix offsetWire() bug - first edge vector should depends on geometry (line or arc) 2019-04-07 12:15:50 -03:00
Yorik van Havre
bfb0a85ab5 Arch: Lowered tolerance of planar profiles for Arch structures 2018-12-27 12:29:03 -02:00
Yorik van Havre
75b939eb21 Draft: re-added missing arcFrom2Pts function in DraftGeomUtils 2018-11-16 18:28:01 -02:00
luz.paz
60bd74aaad Trailing whitespace fixes 2018-08-18 21:48:42 +02:00
luz.paz
fab9cad50f Misc. typos
Found via `codespell`
Trivial typos

Found via `codespell`
2018-08-18 21:48:42 +02:00
Yorik van Havre
6ca4d89cce Arch: bugfixes in IFC exporter 2018-07-26 19:23:48 -03:00
Yorik van Havre
c36d84ba6c Draft: applied patch #1530 from easyw 2018-06-29 12:20:04 -03:00
Yorik van Havre
6a837c1ebe Draft: Fixed draft2sketch not working with ellipses 2018-05-25 18:48:04 -03:00
Yorik van Havre
3198ee8af3 Draft: Added 'Flatten' context menu entry to Draft Wires 2018-05-14 16:49:25 -03:00
luz.paz
9167064fc1 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
Yorik van Havre
351c0fde12 Draft: Fixed default precision value 2017-12-13 10:57:55 -02:00
tomate44
0627fed2ee add ArcOfEllipse to DraftGeomUtils.orientEdge 2017-10-30 17:30:44 +01:00
Yorik van Havre
c24ea6eff3 Draft/Arch: Support for Y situations in sketches - issue #3163 2017-10-27 16:41:31 -02:00
Yorik van Havre
d5a467706d Draft: Small optimizing in DraftGeomUtils.findIntersection() 2017-06-22 17:59:54 -03:00
Yorik van Havre
10ad6c6d02 Draft: Hold snapping points
When drawing (snapping) using the Draft module, it is now possible
to press the Q key to record points. Additional snap locations then
become available orthogonally to these hold points.
2017-04-05 19:04:05 -03:00
hgutsche
201c9d89b0 Some fixes for doygen syntax errors and some configuration to make it run smoother under Windows 2017-02-28 18:52:04 +01:00
Kunda
a7414e5789 source typo fixes pt1 (only on py3 merged code)
issue 0002914
2017-02-27 11:32:47 +01:00
Yorik van Havre
09ba0390d3 Arch: Testing opening property for windows 2017-02-14 10:07:59 -02:00
luzpaz
d5a38892d8 Draft: doxygen tweaks
Getting familiarized with doxygen by starting some initial work on Draft module
typo introduced from commit
2017-02-04 16:09:49 +01:00
Priit Laes
e095084cfb python: Draft: *.py: Fix syntax for Python3 2017-02-04 15:48:43 +01:00
Zheng, Lei
00016543fa Draft: various fixes and improvements of makeSketch
* Fixed extra conincidence constraint on closed wire
* Fixed Part::Feature arc handling
* Added support for Part.Shape
* Added radius and radius equal constraint
* Added support for auto deleting objects and all of its linked children
* Improved performance of autoconstraint
2017-01-24 10:25:58 -02:00
Yorik van Havre
72afcde8db Draft: Added stretch tool - fixes #1163 2017-01-13 11:25:25 -02:00
wwmayer
e198383242 Merge pull request #413 from realthunder/sortEdges
Add C++ implementation of Part.sortEdges
2017-01-04 17:12:10 +01:00