Commit Graph

3915 Commits

Author SHA1 Message Date
Uwe
5f88e71e1f [FEM] fix function selection for cut filter
this is the same fix as https://github.com/FreeCAD/FreeCAD/commit/54ef47276fba
for the cut filter
2022-03-31 00:02:48 +02:00
Uwe
8d8d8fd055 [FEM] fix a comparison operator
Fixes a mistake I introduced with https://github.com/FreeCAD/FreeCAD/commit/54ef47276fba
2022-03-30 23:54:42 +02:00
wmayer
e9c088c0ae Fem: [skip ci] issue #6673: selecting a point for the point result filter crashes 2022-03-30 08:23:55 +02:00
Uwe
ee797360e1 [FEM] improve sphere cut function handling
This commit improves https://github.com/FreeCAD/FreeCAD/commit/2853f671
it turned out that it is valid to use a sphere being part of a Pipeline A ,a also for filters in a Pipeline B, C etc. Thus we must recompute the whole analysis container
2022-03-30 03:35:13 +02:00
Uwe
54ef47276f [FEM] fix bug 4 of the cut filter bugs
as reported here: https://forum.freecadweb.org/viewtopic.php?p=584217#p584217
2022-03-30 02:57:35 +02:00
Uwe
bb74a6b2b8 [FEM] [skip CI] remove superfluous ifs I introduced today 2022-03-30 01:45:59 +02:00
Chris Hennes
bb0e2f1c51 FEM: PR6497 move return statement to new line 2022-03-29 12:35:58 -05:00
Uwe
2853f6715a [FEM] fix sphere cut filter
when using a sphere as function for a filter, the pipeline must be recomputed when the sphere geometry is changed, not only the sphere
2022-03-29 04:48:59 +02:00
wmayer
5974abe351 Fem: in case the range collapses to a single value expand it to a valid range with +/- eps 2022-03-28 20:16:22 +02:00
Chris Hennes
52daf6c546 FEM: PR4556 Step 3: sort QGridLayout by row-col 2022-03-28 10:43:21 -05:00
Chris Hennes
1b6b921941 FEM: PR4556 Step 2: remove native=true 2022-03-28 10:43:21 -05:00
wmayer
0239732e69 Fem: fix error: Unhandled Base::Exception caught in GUIApplication::notify 2022-03-28 15:56:49 +02:00
Uwe
51c7a8c2d3 [FEM] fix crash in pipeline creation
fixes #6670
2022-03-28 02:41:38 +02:00
Uwe
361ea3367d [FEM] fix network pressure value display in result pipelines
was forgotten in https://github.com/FreeCAD/FreeCAD/commit/2b1bbd5e6c6
2022-03-28 02:25:19 +02:00
Uwe
784d62de10 [FEM] some fixes for the Z88 settings dialog
- separate the solver from the binary settings
- fix tooltips and label names
2022-03-28 01:37:54 +02:00
Uwe
66e4c37a25 fix some occurrences where size() is misused as Boolean
- as suggested by @wwmayer: 4d51d1d0b1 (r69648152)
2022-03-27 21:38:15 +02:00
wmayer
14960411a8 Fem: [skip ci] use the required type for the vtk API 2022-03-27 20:54:26 +02:00
wmayer
c447f5a31d Fem: fix segmentation fault in FemPostDataAlongLineFilter::GetAxisData()
It's possible that pdata becomes a null pointer.
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=18&t=67507
2022-03-27 19:18:33 +02:00
Uwe
2b1bbd5e6c [FEM] fix value display in result pipelines
- as reported here: https://forum.freecadweb.org/viewtopic.php?p=583133#p583133

The point is that the user cannot know that he has to multiply the shown numbers for displacements by 0.001 but for the displayed stresses by 1e6 while the temperature is already correct.

The fix is to be consistent and display in SI units. This commit does this and was tested using unit systems with mm and meter based length.
2022-03-27 18:24:03 +02:00
wmayer
4d51d1d0b1 FEM: [skip ci] fix possible crash in setupFilter() function 2022-03-27 11:32:33 +02:00
wmayer
a07f0b6f68 Fem: [skip ci] fix compiler warnings
* add Python.h to PreCompiled.h to fix warning for MSVC: warning C4005: 'COMPILER': macro redefinition
* add Python.h to FemPostPipelinePyImp.cpp to fix warning for clang: pyconfig.h:1672:9: warning: '_LARGEFILE_SOURCE' macro redefined [-Wmacro-redefined]
2022-03-27 11:21:19 +02:00
Uwe
7676216a7a [FEM] more work on filter activation
- warp, clip filters etc. are perfectly valid over a line filter
- handle activation for line, stress line and point filter
2022-03-27 07:44:35 +02:00
Uwe
708a300b93 [FEM] introduce custom pipeline mode
- in order to benefit from the previous fix when e.g. setting up a clip filter of a clip filter one needs the set inputs untouched. The existing modes however changed all an the addition of a new filter.
Use this new mode as default since it preserves the inputs as the users set them on the filter creation
2022-03-27 07:19:56 +02:00
Uwe
57cb8bd91b [FEM] fix some post filter creation issues
- only one object can be used
- don't forbid to use another filter as input for a new filter
2022-03-27 07:09:36 +02:00
Uwe
2f8343b5c5 [FEM] fix activation logic of post filters
only activate them when sensible/possible
2022-03-27 00:57:41 +01:00
Uwe
1b7b72ea90 [FEM] fix activation of post pipeline
it can only be activated if a result object is selected from which the pipeline can be loaded
2022-03-27 00:22:06 +01:00
Uwe
1d95f7b58d [skip CI] [FEM] improve wording in material settings dialog
- also improve layout settings
2022-03-26 06:13:27 +01:00
Uwe
26e2cdbcb6 [skip CI] [FEM] uniform labeling in a settings dialog
- also improve layout settings
2022-03-26 05:59:44 +01:00
Uwe
f3b7836924 [skip CI] [FEM] fix a typo in a dialog 2022-03-26 05:31:19 +01:00
Uwe
bc7d2b69c8 [skip CI] [FEM] uniform labeling in a dialog 2022-03-26 05:22:29 +01:00
Uwe
afe0cd3fdf [FEM] [Skip CI] improve Gmsh settings UI
- fix spelling of "Gmsh"
- fix layout issue reported by Qt Designer
2022-03-26 05:15:32 +01:00
Uwe
1c666f7837 [FEM] adapt electrostatic examples to changed unit handling
- also a coding improvement
2022-03-26 04:54:36 +01:00
Uwe
2e67e70863 [FEM] fix creation of PostPipeline object
- the object was not created inside the analysis container (while this was correctly done when it is created from a solver run)
- after the creation, the object was only hardly visible for the user
2022-03-26 04:37:17 +01:00
Uwe
3bbbae84d7 [skip CI] [FEM] remove an unused header
- also some code styles improvements
2022-03-26 04:32:17 +01:00
Uwe
30928c0710 [FEM] Elecrostatic: use App::PropertyElectricPotential 2022-03-26 02:29:19 +01:00
Uwe
2e8fc8e477 [FEM] Elmer examples: use better names for constraints
fixes a ToDo and the unit tests work fine nevertheless
2022-03-26 01:46:54 +01:00
Uwe
b6b5159b0c {skip CI] revert unwanted change from previous commit 2022-03-25 23:53:22 +01:00
Uwe
c7577d5b06 [skip CI] [FEM] results dialog: fix layout issued reported by Qt Designer 2022-03-25 23:41:58 +01:00
Uwe
ac59dce291 [FEM] fix missing recompute
as reported here: https://forum.freecadweb.org/viewtopic.php?p=582525#p582525

- also fix potential issue that FemGui is used by the script but not loaded
2022-03-25 21:22:15 +01:00
Uwe
8041f0c032 [FEM] fix missing recompute
after the ccx_dat_file object has been changed, the analysis must be recomputed
2022-03-25 21:05:43 +01:00
Uwe
d6e1d973bf [FEM] remove new framework CCX from toolbar
"new framework" implies especially to new users that this is the CCX of choice. But it is not, since you cannot Since we keep it in the menu and experienced users will find it.
2022-03-25 20:00:39 +01:00
Uwe
865e3ec095 [FEM] fix broken Z88 part 5/5: add missing toolbar icon
- now that it is working, expose Z88 to the toolbar as well
2022-03-25 19:55:32 +01:00
Uwe
cc4578e9ae [FEM] fix broken Z88 part 4: don't hardcode memory for iterative solvers
- we must not hardcode the number of coincidence vector places
The user must have a chance to change this setting for the iterative solvers according to the Z88 docs.
We use as default the number Z88 uses in its distributed example.
2022-03-25 19:28:24 +01:00
Uwe
b4befd14b3 [FEM] update Z88 tests
(I doubt that it is sensible to check if a hardcoded memory value is written. The test will fail if you use a non-default memory setting on your FreeCAD. The CI uses of course the default)
2022-03-25 19:04:21 +01:00
Uwe
7bc69a8cbb [skip CI] [FEM] some style changes by MSVC
- to avoid annoying unnecessary diffs while working on the FEM module
2022-03-25 18:55:33 +01:00
Uwe
ebc0c0ae04 [FEM] fix broken Z88 part 3: don't hardcode memory
- we must not hardcode the number of stiffness matrix places, especially not for the Cholesky solver
The user must have a chance to change this setting in case of a solver error. This is also according to the Z88 docs that says it is a two step process:
- the solver first computed the necessary places
- the user must set the value accordingly in case it is too low

- also some code style fixes
2022-03-25 18:40:12 +01:00
Uwe
c4bd8ee72c [FEM] fix broken Z88 part 2: fix error handling
- when the solver failed, we cannot return a non-existing res_obj
2022-03-25 18:01:12 +01:00
Uwe
d035bbc1ca [FEM] fix broken Z88 part 1: don't hardcode solver
- especially don't hardcode the choly solver that fails quickly for finer meshes
- setting sorcg as default since it shows the best performance with the cantilever tests
2022-03-25 16:49:03 +01:00
wmayer
7734017cd6 Fem: split strings with placeholders to make sure it's still created correctly if translation is broken 2022-03-25 15:48:46 +01:00
Uwe
1baf3f2bfa [FEM] fix Gmsh deletion handling
- fixes the issue that one could accidentally delete a mesh despite it has submeshes

- also a coding style improvement
2022-03-25 05:50:31 +01:00