fix(toolbar): add workbench-level fallback contexts (#230) #235

forbes · 2026-02-15T01:17:23Z

forbes commented

2026-02-15 01:17:23 +00:00

Closes #230

PartDesign, Sketcher, and Assembly toolbars use DefaultVisibility::Unavailable and rely on EditingContextResolver to call ForceAvailable. When switching to these workbenches without a specific editing state (e.g. PartDesign with no Body activated), no context matches between priority 30 and the empty_document fallback at priority 10, so all workbench toolbars stay hidden.

Adds three workbench-level fallback contexts at priority 20 that match based on WorkbenchManager::instance()->activeName():

Context	Workbench	Toolbars
`partdesign.workbench`	PartDesignWorkbench	Part Design Helper Features, Sketcher
`sketcher.workbench`	SketcherWorkbench	Sketcher, Sketcher Tools
`assembly.workbench`	AssemblyWorkbench	Assembly

No additional signal wiring needed — signalActivateWorkbench already triggers refresh().

Closes #230 PartDesign, Sketcher, and Assembly toolbars use `DefaultVisibility::Unavailable` and rely on `EditingContextResolver` to call `ForceAvailable`. When switching to these workbenches without a specific editing state (e.g. PartDesign with no Body activated), no context matches between priority 30 and the `empty_document` fallback at priority 10, so all workbench toolbars stay hidden. Adds three workbench-level fallback contexts at priority 20 that match based on `WorkbenchManager::instance()->activeName()`: | Context | Workbench | Toolbars | |---|---|---| | `partdesign.workbench` | PartDesignWorkbench | Part Design Helper Features, Sketcher | | `sketcher.workbench` | SketcherWorkbench | Sketcher, Sketcher Tools | | `assembly.workbench` | AssemblyWorkbench | Assembly | No additional signal wiring needed — `signalActivateWorkbench` already triggers `refresh()`.

forbes added 1 commit 2026-02-15 01:17:24 +00:00

fix(toolbar): add workbench-level fallback contexts (#230 )

Build and Test / build (pull_request) Has been cancelled

Details

9a566cabf9

PartDesign, Sketcher, and Assembly toolbars use
DefaultVisibility::Unavailable and rely on EditingContextResolver to
show them. When switching to these workbenches without a specific editing
state (e.g. PartDesign with no Body activated), no context matches and
all workbench toolbars stay hidden.

Add workbench-level fallback contexts at priority 20 that match when the
workbench is active regardless of editing state:
- partdesign.workbench: shows Helper Features + Sketcher toolbars
- sketcher.workbench: shows Sketcher + Sketcher Tools
- assembly.workbench: shows Assembly toolbar

These fill the gap between object-specific contexts (priority 30+) and
the empty_document fallback (priority 10).

forbes added 13 commits 2026-02-15 01:23:28 +00:00

feat(silo): update silo submodule — headless runner entry points (#217 )

Build and Test / build (pull_request) Has been cancelled

Details

9da73fe6e7

Adds runner.py with dag_extract, validate, and export entry points
for silorunner compute jobs.

Closes #217

Merge pull request 'feat(silo): headless runner entry points — dag_extract, validate, export (#217 )' (#226 ) from feat/silo-runner into main

Build and Test / build (push) Has been cancelled

Details

a5a1914892

Reviewed-on: #226

feat(silo): update silo submodule — DAG and job SSE events (#218 )

Build and Test / build (pull_request) Successful in 39m3s

Details

7fb3aa4c01

Extends SiloEventListener with signals for dag.updated,
dag.validated, and job lifecycle events (created, claimed,
progress, completed, failed, cancelled).

Closes #218

Merge pull request 'feat(silo): handle DAG and job SSE events (#218 )' (#227 ) from feat/silo-sse-dag-events into main

Build and Test / build (push) Has been cancelled

Details

f5412a58fc

Reviewed-on: #227

feat(silo): update silo submodule — DAG status in Activity panel (#219 )

Build and Test / build (pull_request) Has been cancelled

Details

d7f5393510

Shows DAG sync status, validation results, and job lifecycle
events in the Database Activity dock widget via SSE signals.

Closes #219

Merge pull request 'feat(silo): DAG status display in Activity panel (#219 )' (#228 ) from feat/silo-dag-activity into main

Build and Test / build (push) Has been cancelled

Details

83672c8c05

Reviewed-on: #228

fix(ui): match origin dropdown height to workbench dropdown (#231 )

Build and Test / build (pull_request) Has been cancelled

Details

79501bd5ca

Add min-height: 20px to OriginSelectorWidget in KindredCreate.qss so it
renders at the same visual height as the WorkbenchComboBox. The two
widgets use different Qt base classes (QToolButton vs QComboBox) with
different intrinsic size hints, causing a height mismatch in the toolbar.

fix(prefs): apply KindredCreate defaults after Reset All (#229 )

Build and Test / build (pull_request) Has been cancelled

Details

3804164158

When "Reset All" is used in Preferences, restoreDefaults() clears the
entire User parameter tree via ParameterManager::Clear(). Widgets then
fall back to upstream FreeCAD hardcoded defaults (e.g. light theme,
default units) instead of Kindred Create defaults.

After clearing, apply the KindredCreate preference pack to restore
Create-specific baseline settings (Catppuccin Mocha theme, toolbar
layout, unit preferences, etc.).

Merge branch 'main' into fix/origin-dropdown-height

Build and Test / build (pull_request) Has been cancelled

Details

645e1b4607