kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix(build): fix DlgSettingsGeneral::applyMenuIconSize visibility and namespace #49

Merged
forbes merged 1 commits from fix/build-menu-icon-size into main 2026-02-08 23:05:11 +00:00
Conversation 0 Commits 1 Files Changed 2 +3 -1
forbes commented 2026-02-08 23:04:51 +00:00
Owner
Copy Link

Fixes the build failure from PR #47 merge.

Two issues:

  • applyMenuIconSize was declared private but called from StartupProcess.cpp — moved to public
  • Missing Dialog:: namespace qualifier — StartupProcess.cpp has using namespace Gui but DlgSettingsGeneral is in Gui::Dialog
Fixes the build failure from PR #47 merge. Two issues: - applyMenuIconSize was declared private but called from StartupProcess.cpp — moved to public - Missing Dialog:: namespace qualifier — StartupProcess.cpp has `using namespace Gui` but DlgSettingsGeneral is in `Gui::Dialog`
forbes added 1 commit 2026-02-08 23:04:52 +00:00
fix(build): fix DlgSettingsGeneral::applyMenuIconSize visibility and namespace
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
4bf74cf339 
- Move applyMenuIconSize to public access so StartupProcess can call it
- Add Dialog:: namespace qualifier in StartupProcess.cpp
forbes merged commit cf523f1d87 into main 2026-02-08 23:05:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#49
Delete Branch "fix/build-menu-icon-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?