make lib shared; resolved FullRow method ;fixed spelling errors

CMakeLists.txt

@@ -7,7 +7,7 @@ set(CMAKE_CXX_STANDARD_REQUIRED True)
 
 include(GNUInstallDirs)
 
-add_library(OndselSolver STATIC)
+add_library(OndselSolver SHARED)
 
 set(ONDSELSOLVER_SRC
         OndselSolver/Array.cpp

OndselSolver/CREATE.h

@@ -6,7 +6,7 @@
  *   See LICENSE file for details about copyright.                         *
  ***************************************************************************/
  
-//This header file causes wierd problems in Visual Studio when included in subclasses of std::vector or std::map. Why?
+//This header file causes weird problems in Visual Studio when included in subclasses of std::vector or std::map. Why?
 
 #pragma once
 

OndselSolver/FullRow.cpp

@@ -10,8 +10,8 @@
 #include "FullMatrix.h"
 
 namespace MbD {
-    template<typename T>
-    std::shared_ptr<FullMatrixDouble> FullRow<T>::transposeTimesFullRow(FRowsptr<T> fullRow)
+    template<>
+    std::shared_ptr<FullMatrixDouble> FullRow<double>::transposeTimesFullRow(FRowsptr<double> fullRow)
     {
         //"a*b = a(i)b(j)"
         auto nrow = (int)this->size();

OndselSolver/FullRow.h

@@ -37,7 +37,7 @@ namespace MbD {
 		void atiplusFullRow(int j, FRowsptr<T> fullRow);
 		std::ostream& printOn(std::ostream& s) const override;
 
-        std::shared_ptr<FullMatrixDouble> transposeTimesFullRow(FRowsptr<T> fullRow);
+        std::shared_ptr<FullMatrixDouble> transposeTimesFullRow(FRowsptr<double> fullRow);
         FRowsptr<double> timesTransposeFullMatrix(std::shared_ptr<FullMatrixDouble> fullMat);
         // FRowsptr<std::shared_ptr<FullMatrixDouble>> timesTransposeFullMatrixForFMFMDsptr(std::shared_ptr<FullMatrixFullMatrixDouble> fullMat);
         FRowsptr<double> timesFullMatrix(std::shared_ptr<FullMatrixDouble> fullMat);

OndselSolver/FullVector.h

@@ -178,8 +178,9 @@ namespace MbD {
 	template<typename T>
 	inline void FullVector<T>::conditionSelfWithTol(double tol)
 	{
-		assert(false);
-		return;
+		assert(false && tol != tol);   // clang++ flips out with warnings if you don't use 'tol'
+                                       // but suppressing that warning breaks Visual Studio.
+		return;                        // Visual Studio demands the unused return
 	}
 	template<typename T>
 	inline std::ostream& FullVector<T>::printOn(std::ostream& s) const

OndselSolver/RedundantConstraint.cpp

@@ -105,7 +105,7 @@ void RedundantConstraint::setqsuddotlam(FColDsptr col)
 
 void RedundantConstraint::discontinuityAtaddTypeTo(double t, std::shared_ptr<std::vector<DiscontinuityType>> disconTypes)
 {
-	//"Reactivate all contraints."
+	//"Reactivate all constraints."
 	assert(false);
 	//| newSelf |
 	//newSelf : = self constraint.

OndselSolver/StableBackwardDifference.cpp

@@ -12,7 +12,7 @@ using namespace MbD;
 
 void StableBackwardDifference::formTaylorMatrix()
 {
-	//This form is numerically more stable and is prefered over the full Taylor Matrix.
+	//This form is numerically more stable and is preferred over the full Taylor Matrix.
 	//For method order 3:
 	//| (t1 - t)	(t1 - t) ^ 2 / 2!	(t1 - t) ^ 3 / 3!|	|qd(t)  | = | q(t1) - q(t)	|
 	//|	(t2 - t)	(t2 - t) ^ 2 / 2!	(t2 - t) ^ 3 / 3!|	|qdd(t)	|	|q(t2) - q(t)	|