Commit Graph

93 Commits

Author SHA1 Message Date
Chris Hennes
06a0e1e923 [Arch] Fix LGTM warnings 2021-09-28 10:29:45 -05:00
luz paz
f2b93a7af3 Crowdin: represent whitespace in code instead of in string [skip ci]
Removing possible whitespace from strings lead to more accurate translations
2021-04-19 06:16:09 -04:00
Yorik van Havre
afa40aa049 Merge pull request #4299 from three-ddd/archstairs_connections_flight_landing
[0.20] [Arch] connections between stair flight and landing
2021-03-30 13:17:24 +02:00
Alex Young
79449b8ce9 Arch: removes unused imports
Removes unused imports as reported by LGTM.

There are exceptions: `import Arch_rc` is shown as an alert, but has side effects.  It's not clear what the best thing to do in those cases is, so I've left them for now.
2021-02-14 16:27:06 +00:00
Chris Hennes
8228d64ac4 [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
three_d
de017757c8 Update ArchStairs.py 2021-01-22 19:09:18 +01:00
three_d
f1d95d372d Arch: connections between stair flight and landing
Added some features to allow the user to change the types of connections between the flight of stairs and landing.
This issue is discussed in the forum thread: https://forum.freecadweb.org/viewtopic.php?f=22&t=53018
2021-01-21 18:41:23 +01:00
luz paz
67381e9579 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
luz.paz
8fb5c65736 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
a3e88a399f Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
luz.paz
5c1cae14b9 Arch: use string operator instead of numeric LGTM fix 2019-10-25 10:23:24 -03:00
luz.paz
519bbfe503 Misc. source comment typo and whitespace fixes 2019-05-06 13:42:30 +02:00
Yorik van Havre
624e20e9a2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
paullee0
7a4c0f6e0a Add RiserThickness feature
Mantis
  https://freecadweb.org/tracker/view.php?id=0003816

Discussion
  https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=120#p298162
2019-04-04 11:08:04 -03:00
luz.paz
e7489c079c More misc. typos 2019-03-31 11:42:37 +02:00
paullee0
0c1137f5bd Fix to Build Curve Segment Railing Wire To Follow Curve Landing
Limited by makePipeShell, curvilinear railing still usually has problems to be created

Discussions:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=bfd05589642577079096cd8879b7a88f&start=120#p285656
https://forum.freecadweb.org/viewtopic.php?f=22&t=34081#p285607
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=110#p284683
2019-03-19 14:16:05 -03:00
paullee0
327162dbcc Revert "Build Curve Segment Railing Wire To Fit Landing"
This reverts commit e5989280bb8aeb73b73483c0c74d019bdb1116d6.
2019-03-19 14:16:05 -03:00
paullee0
176c0d4e7a Build Curve Segment Railing Wire To Fit Landing
Limited by makePipeShell, curvilinear railing usually has problems to be created

Discussions:-
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=110#p284683
https://forum.freecadweb.org/viewtopic.php?f=22&t=34081#p285607
2019-03-19 14:16:05 -03:00
paullee
f431226bb8 Fix Right Align Railing Offset Bug 2019-02-06 10:13:37 -02:00
luz.paz
1db71c3c7e Crowdin: Arch/ArchStairs.py missing paranthesis fix 2019-01-30 11:08:03 -02:00
Yorik van Havre
090fc64284 Misc translation fixes from https://forum.freecadweb.org/viewtopic.php?p=281670 2019-01-23 18:20:43 -02:00
luz.paz
506741aee1 [For v0.18] Crowdin fixes
https://crowdin.com/translate/freecad/568/en-en#1172237
https://crowdin.com/translate/freecad/568/en-en#1172239
https://crowdin.com/translate/freecad/568/en-en#195053
https://crowdin.com/translate/freecad/568/en-en#1172247
https://crowdin.com/translate/freecad/568/en-en#1172249
https://crowdin.com/translate/freecad/568/en-en#1172251
https://crowdin.com/translate/freecad/6766/en-en#6511058
https://crowdin.com/translate/freecad/6766/en-en#6511060
https://crowdin.com/translate/freecad/6766/en-en#6502381
+ random typo fixes
2019-01-13 02:24:50 +01:00
paullee
5af993cb1c Curvilinear Landing based on underlying curve edges supported; found sortEdges() 'problem'
Discussion:-
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=100#p277409
2019-01-02 17:26:34 -02:00
paul
a899a970c8 Fix another 2 missing parentheses 2018-12-03 10:30:08 -03:00
Yorik van Havre
ccc5ff53fe Fixed py3 sntax errors 2018-12-03 10:30:08 -03:00
paullee
da7b5199fb Some methods become Static, returnOutlines() become more generic purpose etc. 2018-12-03 10:30:08 -03:00
paullee
51b3b33917 Fix Typo - vbaseFollowLastSement --> vbaseFollowLastSegment 2018-12-03 10:30:08 -03:00
Yorik van Havre
b1d6770ffb Fixed coverity issues
184298 Bad use of null-like value
183849 Bad use of null-like value
183846 Bad use of null-like value
183845 Copy-paste error
183844 Bad use of null-like value
2018-11-19 19:17:56 -02:00
Yorik van Havre
490b76f405 Arch: Fixed py3 errors in IFC export 2018-11-08 17:23:06 -02:00
paullee
3de3ac3994 Tweak makeRailing(None) to (re)-create Railing and insert back to Stairs.Additions
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&p=260767#p260767
2018-10-07 13:48:33 -03:00
paullee
c825cca145 Default Stairs (i.e. without Base Dwire etc.) also have Railings created
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=55d32dc42111afa6c7fdf7b0fc0f3ab7&start=90#p260764
2018-10-07 13:48:33 -03:00
paul
1e23a42068 Merge pull request #1 from luzpaz/ArchStairs_Improvement_9
Typo fix for Archstair_Improvement9
2018-10-07 13:48:33 -03:00
paullee
2cddbe5dab ArchPipe objects named as "Rail"
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&p=259085#p259085
5f63a7764b (diff-fb9ac48ea14ab86d0e964fee1f4e4838)
2018-09-28 13:18:40 -03:00
paullee
56378b5be8 Add Property 'Width of Landing'; set width of different 'edge' of a Landing
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=80#p257963
https://forum.freecadweb.org/viewtopic.php?f=22&t=29709
2018-09-28 13:18:40 -03:00
paullee
fc09738579 ArchStairs: Fix HalfTurnLeft error/bug 2018-09-26 17:10:42 +02:00
Yorik van Havre
2b2b920c80 Arch: python3 fix 2018-08-25 00:11:43 -03:00
paullee
6e83baf1df Fix railing height at starting point etc.
Discussion:

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p247814
2018-08-22 10:17:24 -03:00
paullee
681c71766f Add Railing Height and Offset
Discussion:-

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=70#p247036
2018-08-22 10:17:24 -03:00
paullee
cad83384f3 'Multi-segment' continuos railing update following Stairs' changes
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=60#p246607
2018-08-20 10:52:59 -03:00
paullee
fb388774ea Fix railing on 2 sides; Make continous railing for 'multi-segment' stairs; Group under 'Master Stairs'
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p246607
2018-08-20 10:52:59 -03:00
paullee
6dafd51fa9 Fixing Railing - Left & Right
Discussion:-
(Somewhere here only - Not discussed exactly here, codes not post here)
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p245038
2018-08-20 10:52:59 -03:00
paullee
55fb508346 Fix StraightLanding connecting bit; other TreadDepth RiserHeight issues etc.
Discussion:
(Somewhere here)
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244648
2018-08-19 11:15:58 -03:00
paullee
0c918ba5d0 'Centralise' all cases use MakeStraightStairsWithLanding method; further fix TreadDepth and RiserHeight Enforce
Discussion:-
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244502
2018-08-19 11:15:58 -03:00
paullee
773ca081f1 Add TreadDepth & RiserHeight Enforce properties; Fix MakeStair, MakeStraightLanding functions; Test Right Railing
Discussion:
(Somewhere here)

https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&sid=3d9ba22b6aa2556f61c4ddb035a6163d&start=60#p244502
2018-08-19 11:15:58 -03:00
paullee
dc4628767c Fix MakeStairs, _CommandStairs functions; Testing Railing (One side only)
Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=29358&start=50#p244345
2018-08-19 11:15:58 -03:00
paullee
2221820d79 Various general bugs fixes and _CommandStairs related 2018-08-17 10:35:46 -03:00
paullee
28e8d5e822 Add HalfTurnRight 'basic' feature, Master Stairs to accommodate differnt flight of stairs 2018-08-17 10:35:46 -03:00
paullee
4f3d0149f1 Add basic MultiEdgesLanding method 2018-08-15 10:46:43 -03:00
paullee
69fec24cbb Add AbsTop Property - Absolute Top Level of a segment/flight of stairs; To enable 'multi-segment' stairs. 2018-08-15 10:46:43 -03:00
paullee
adb44fee55 Add LastSegment Property - to enable 'multi-segment' / 'multi-flight' stairs; and fix some LandingDepth related bug. 2018-08-15 10:46:43 -03:00