Commit Graph

42 Commits

Author SHA1 Message Date
Uwe
e29d1d0332 [TD] Gui, A*-C*: remove unused includes
- also sort includes
- also an addition to precompiled header
- TaskCenterLine: remove unused code that interferes with used code with the same name
2022-10-09 03:34:53 +02:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
6677cd4d8f [TD]clazy warnings and duplicate setter/getter
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
2022-08-18 09:34:32 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
e7edda9679 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Uwe
8304a0942e [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Benjamin Bræstrup Sayoc
8c0ab46b4d [TechDraw] Improve readability of commands 2022-07-09 13:07:30 -04:00
Wanderer Fan
9894964eb6 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Wanderer Fan
d36cbb522a [TD]fix ExtendShorten handling of CenterLine 2022-04-23 18:43:27 -04:00
Wanderer Fan
abd8e3a46e [TD]fix ExtendLine changes CenterLine
- extendShortenLine converts CenterLines to CosmeticEdges
2022-04-23 18:43:27 -04:00
wmayer
fd8719c85c TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
68171bd20c TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
2439a9d90e [TD]use <br> in ToolTipText vs \n 2022-03-03 09:31:01 -05:00
Wanderer Fan
7546c03509 [TD]fix area scale and make unit aware 2022-03-03 09:31:01 -05:00
wmayer
420fbb3d28 TD: further security checks in CmdTechDrawExtensionPositionSectionView::activated 2022-02-28 19:09:31 +01:00
wmayer
13e7d47154 TD: improve handlings with casts 2022-02-28 18:56:28 +01:00
andrea reale
90659c131c Fix uninitialized variable 2022-02-28 18:53:09 +01:00
luz paz
6953a7cea8 Fix some typos and whitespace 2022-02-12 19:33:28 +01:00
edi271
af82959b02 New tool circle through 3 points 2022-02-02 08:35:34 -05:00
edi271
a26933bf4c [TD] Include Intersection method into DrawUtil class 2022-01-29 14:49:44 -05:00
edi271
cd4da51e60 [TD] Insert new tool Area Annotation 2022-01-29 14:49:44 -05:00
Roy-043
9fba28c1b6 Update CommandExtensionPack.cpp
Added the missing bracket!
2022-01-26 08:48:42 -05:00
Roy-043
b03dd9b6da Update CommandExtensionPack.cpp
Delta Distance was added to the dialog box.
2022-01-26 08:48:42 -05:00
Roy-043
9c00c3ffea Update CommandExtensionPack.cpp
Modifications as suggested by Edi.
2022-01-26 08:48:42 -05:00
Roy
5476af8f8f TechDraw: Ext. Tools: Improve menu texts and tooltips 2022-01-26 08:48:42 -05:00
edi271
242dcd7e44 [TD] Variable line stretching distance 2022-01-21 11:22:40 -05:00
edi271
c46a4f776b [TD] Move Circulation method to DrawUtil 2022-01-21 11:22:40 -05:00
Roy
adf084bb45 TechDraw: Rename TechDraw_ExtensionArc command to TechDraw_ExtensionDrawCosmArc 2022-01-10 11:22:18 -05:00
Uwe
2f0c4d055a [TD] coding style fixes for new extensions
all done by MSVC

I do this since on one hand the readability is in this case really improved and because whenever I made a change, MSVC tries to fix the style and then the diffs are unnecessarily large. Also the MSVC style is almost what we use as the "standard" coding style.
2022-01-07 21:35:46 +01:00
Uwe
6cab015fdd [TD] fix another compiler warning about double to float truncation 2022-01-07 21:28:27 +01:00
Wanderer Fan
e58d30d55e [TD]use smart pointers in Extensions 2022-01-07 13:34:20 -05:00
Wanderer Fan
e91cc8e329 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wandererfan
f2d624cede [TD]combine @wmayer and edi271 changes re command extensions 2022-01-07 08:58:10 -05:00
edi271
de1ab433e5 using getCircleCenter from Part WB 2022-01-07 08:58:10 -05:00
edi271
bfe2184251 using enums to define line attributes 2022-01-07 08:58:10 -05:00
edi271
5e44722a18 Changes caused by PR5231 2022-01-07 08:58:10 -05:00
edi271
93ea3ba19f Inserted undo/redo commands 2022-01-07 08:58:10 -05:00
edi271
380386851e Next31TechDrawTools 2022-01-07 08:58:10 -05:00
wmayer
fbdb4e29d8 TD: [skip ci] fix warning about trunction from double to float 2021-10-11 16:47:27 +02:00
Roy-043
0dd4119369 TechDraw: typo in menu extension pack
Typo: "center line(s)" should be "centerline(s)". Same as in the name of the submenu: "Extensions: centerlines and threading".
2021-09-27 14:25:24 +02:00
edi271
3454ca381a renamed to CommandExtensionPack 2021-09-06 18:32:45 +02:00