kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
30,553 Commits 41 Branches 6 Tags
60e3084d424c35c50c857de4a17da25fd0ee5900
Commit Graph

2340 Commits

Author SHA1 Message Date
0penBrain
26aaf0af45 Sketcher : optimize code that was present for Qt4 compatibility 
Was introduced by 634e47f31, new code only supported by Qt5
 2022-10-03 11:12:35 -07:00
Chris Hennes
ef62fc3530 Sketcher: Remove Snell's Law from toolbar 
Leave menu item intact so it is still accessible, but does not use up toolbar space.
 2022-10-03 09:25:42 -05:00
Uwe
f982d776fb [skip CI] [Sketcher] ViewProviderSketch.cpp: Clang formatting 
- to please the CI (too long lines etc.)
 2022-10-02 20:34:12 +02:00
wmayer
e2a552a9c6 Sketcher: [skip ci] remove unused includes 2022-09-25 11:09:29 +02:00
Uwe
2ef4b7a06b [Gui] fix some CI warnings 
- narrowing conversion from 'unsigned long' to signed type 'int' is implementation-defined
- floating point literal has suffix 'f', which is not uppercase
- narrowing conversion from 'double' to 'float'
- Slots named on_foo_bar are error prone
- also tome Clang style fixes

(see here for the reports: https://github.com/FreeCAD/FreeCAD/pull/7522/commits/d9c2efcc)
 2022-09-24 19:58:11 +02:00
0penBrain
5cd2160bf5 Sketcher/constraints: improve command opening management 
TODO : do same in CmdSketcherConstrainTangent::substituteConstraintCombinations
 2022-09-24 16:05:23 +02:00
0penBrain
e4916d8057 Sketcher: fix misleading indentation 2022-09-24 16:05:23 +02:00
0penBrain
189875b769 [Bugfix]Sketcher/Point-on-object: do not substitute constraint if conditions are not OK 2022-09-24 16:05:23 +02:00
Adrian Insaurralde Avalos
af198507f5 [Sketcher] adjust some icons to better follow art style guide [skip-ci] 2022-09-23 14:40:24 +02:00
Chris Hennes
73c586ba52 Sketcher: Remove unnecessary translations 
Several of the strings in TaskSketcherSolverAdvanced.ui should not be translated as they are later replaced in code.
 2022-09-19 22:32:02 -05:00
marioalexis
734dfc47c6 Sketcher: Replace C cast 2022-09-18 11:06:51 -05:00
Uwe
d6afbb5718 [Sketcher] rename a variable to please spellchecker 
- also some code style improvements
 2022-09-14 09:54:07 +02:00
Ajinkya Dahale
655e8b6504 [Sketcher] Fix Typo in comment 
threated -> treated
 2022-09-14 00:34:57 -05:00
0penBrain
b76da40885 [Bugfix]Sketcher: prevent dangling state of Shift key if key released out of Quarter 2022-09-13 22:20:15 -05:00
0penBrain
3d7fa720e6 [Bugfix]Sketcher: some user colors aren't taken into account 2022-09-11 22:04:38 +02:00
0penBrain
968fb5be34 Sketcher/BackEdit: makes clip plane switch side according to view side 2022-09-09 16:09:42 +02:00
0penBrain
7928a8c3a0 Sketcher: makes TempoVis properties read only 
as they are not intended to be manually modified
 2022-09-09 16:09:42 +02:00
0penBrain
3f220f1dd8 Sketcher/BackEdit: makes sketch elements render on -Z if sketch viewed from back side 2022-09-09 16:09:42 +02:00
0penBrain
a6a8f27125 Sketcher/BackEdit: makes EditModeGeometryCoinConverter class VP & attorneys aware 2022-09-09 16:09:42 +02:00
0penBrain
7d1e4186cc Sketcher/BackEdit: makes EditModeInformationOverlayCoinConverter class VP & attorneys aware 2022-09-09 16:09:42 +02:00
0penBrain
b40d800550 Sketcher/BackEdit: makes view orientation factor accessible to coin managers 2022-09-09 16:09:42 +02:00
0penBrain
36fccfdd08 Sketcher/BackEdit: Add camera sensor to VP that detects side and redraw if side changed 2022-09-09 16:09:42 +02:00
0penBrain
b687e2ce0c [Bugfix]Gui: ensure message boxes appear and stay on top of main window 2022-09-05 11:09:41 +02:00
wmayer
af18a9ea3b Sketch: fix build failure 2022-09-01 17:07:53 +02:00
wandererfan
dd14b42829 [Sketcher]make cursor coord display unit aware 2022-08-31 16:31:27 -04:00
wmayer
a7bf7869ae Sketcher: modernize C++: replace 'typedef' with 'using' 2022-08-29 23:13:16 +02:00
berniev
6953310116 Mod: Single arg ctors must be explicit 2022-08-24 16:55:20 +02:00
Jonas Bähr
a1776d3e74 Fix build on MacOS-X 10.14: missing Xerces include dir 
This undoes most of the Xerces related part of the commits listed below.
The issue resolved here is that the Xerces include dir *is* set in the
CMakeLists.txt of src/Base, but it got removed from various App and Gui
dirs in src/Mod. If those now include a header from src/Base, which
itself includes xercesc, the build fails using Apple clang version 11.0.0
(clang-1100.0.33.17) on Mojave, configured using cmake 3.22.1, with
errors like the following:

In file included from .../src/Mod/Part/App/FeaturePartBoolean.cpp:34:
In file included from .../src/App/Application.h:33:
.../src/Base/Parameter.h:54:10: fatal error: 'xercesc/util/XercesDefs.hpp' file not found
 #include <xercesc/util/XercesDefs.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Finally, a full list of the commits that introduced this spurious include
dir optimization for reference:
- Drawing: commit 96ad045b91
- Image: commit dde71a21d5
- Import: commit c9d28b542f
- Inspection: commit d41f55f382
- Mesh: commit 19072b0538
- Part: commit fe213a48f0
- PartDesign: commit b037d8e240
- Path: commit f23fa31f42
- Points: commit bec723ba17
- Raytracing: commit 08d4ac63a3
- ReverseEnginering: commit 5ca787cb0e
- Robot: commit bad4809a1c
- Sketcher: commit 3c96daf105
- Spreadsheet: commit 66e8a2bef3
- Start: commit c9dee5e70a
- Surface: commit 6b04215be6
- TechDraw: commit 5e6699e48d
- Test: commit ea5b45b92c
- Web: commit ee6d631531
 2022-08-24 07:40:04 +02:00
luz paz
ded17b7543 Follow-up typo fixes 2022-08-23 18:49:47 +02:00
luz paz
1a7ddfdc24 Fix typos and whitespace 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
 2022-08-23 18:49:47 +02:00
Chris Hennes
a72bf218f9 Sketcher: Tweak tip language for ConstrainRadiam 
Based on a question in CrowdIn.
 2022-08-20 18:11:11 -05:00
wmayer
2062f9ce87 clang: fix warnings [-Winconsistent-missing-override] 2022-08-09 17:36:25 +02:00
berniev
ddafb98813 Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
915369d8a2 Mod: Redundant_string_initialization 2022-08-08 16:52:42 +02:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Roy-043
2e646c9147 Sketcher: Fix sWhatsThis for Sketcher_CompConstrainRadDia (#7324) 2022-08-08 02:11:06 +02:00
berniev
b796a0d376 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
2d4c5a4cfb Mod: use emplace_back 2022-08-05 10:36:16 +02:00
Uwe
d4c60abf70 [Sketcher] fix icon name 
- fix a FIXME, Sketcher_CreateEllipse depicts already the right thing, it just has to be renamed
 2022-07-29 01:26:00 +02:00
Uwe
03041f0aff [Sketcher] [skip CI] CommandCreateGeo: code style fix 
- the MSVC IDE had problems with this, thus apply our .clang style
 2022-07-27 16:05:39 +02:00
0penBrain
dbe8f47d93 [BUGFIX] Sketcher: fix icon normal/construction toggling when commands used in custom toolbar 
Fixes #7064
 2022-07-27 14:28:54 +02:00
wmayer
d344ccc4eb Sketcher: [skip ci] Fix several clazy issues: 
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Unused QString [-Wclazy-unused-non-trivial-variable]
* Missing emit keyword on signal call [-Wclazy-incorrect-emit]
* Don't call QList::operator[]() on temporary [-Wclazy-detaching-temporary]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Maybe you meant to call ViewProvider2DObjectGrid::onChanged() instead [-Wclazy-skipped-base-method]
 2022-07-25 12:56:09 +02:00
Uwe
003757176c Mod: remove some more superfluous Boolean checks 2022-07-19 02:40:59 +02:00
Uwe
88a06f8f10 Mod: remove some unnecessary nullptr checks 2022-07-18 12:58:12 +02:00
Uwe
16c86a6d08 [Sketch] remove superfluous nullptr checks 2022-07-18 02:51:49 +02:00
wmayer
b48f7229a3 Sketch: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 12:41:53 +02:00
wmayer
732e6d9cee Sketch: [skip ci] fix -Wsign-compare 2022-07-11 11:08:52 +02:00
Ajinkya Dahale
1f4e6ad899 [Sketcher] Do regular drag for small B-splines 
Here, "small" means that the number of poles of the spline is so low that moving
any piece of the curve without changing shape would require moving all the
poles. In that case the rest of the algorithm in `initBSplinePieceMove()` only
complicates the matter.
 2022-07-07 08:17:20 +02:00
Ajinkya Dahale
a88f69a9f0 [Sketcher] Only move one piece of B-spline when dragging 2022-07-02 07:35:30 +02:00
Abdullah Tahiri
19a69df0fc Sketcher: Bug fix 
https://forum.freecadweb.org/viewtopic.php?p=606581&sid=70cfe557d7d1985e45ea1b298282c759#p606581
 2022-07-01 13:56:16 +02:00