Commit Graph

22815 Commits

Author SHA1 Message Date
vocx-fc
b81ea41ae5 Sketcher: add five tools to the Sketcher toolbar and reorder code
Add template specification for `SketcherAddWorkspaceSketchExtra`
for type `Gui::ToolBarItem` so that the following commands
are added to the toolbar as well as the Sketcher menu:
`ReorientSketch`, `ValidateSketch`, `MergeSketch`, `MirrorSketch`,
`StopOperation`.

Reorganize the order of the function declarations
so that they are in this order: Sketch actions (general),
geometries, constraints, tools, B-splines, and virtual space.

Add separators to the list of tools commands in the menu
so that it looks clearer.

Correct the header guard `#ifndef SKETCHER_WORKBENCH_H`.
Previously, it was using a guard `IMAGE_WORKBENCH_H`
seemingly copied from the Image Workbench.
2020-10-22 14:53:52 +02:00
Neinei0k
ef067e9f5f Sketcher: Merged constraint selection fix.
When the sketch is not in XY plane, individual constraints from the merged constraint icon can't be selected. Constraint icon coordinates are given in sketcher coordinates. The function getCoordsOnSketchPlane projects vector in global coordinates to the sketch plane. So, it makes no sense to use sketcher coordinates with it. If the sketch is in the XY plane, then the global coordinates are the same as sketcher coordinates. The solution is to get global coordinates of the icon from the sketcher coordinates and use it to project icon to the screen.
2020-10-22 13:52:31 +02:00
donovaly
896a1bcb45 [PD] more holes fixes
- initialization: thread direction only sensible if there is a thread
- initialization: hole diameter can only be changed if there is no profile
- initialization: only enable allowed hole cut parameters
- also for the ISO profiles it is allowed to countersink/bore deeper/less deep
- UI file: add some tooltips (the other changes were done automatically by Qt's designer)
2020-10-22 13:01:57 +02:00
wmayer
9d36253539 Part: [skip ci] use the correct icon for helix and sprial view providers 2020-10-22 12:43:39 +02:00
0penBrain
537089b346 [Sketcher] Allow selection of 2 vertices for horizontal/vertical constraint in continuous mode
Fixes #4444
2020-10-21 17:22:53 +02:00
bitacovir
ccd8980398 Add SVG icons for two Std commands
Two Std commands do not have icons for the FreeCAD UI (Menu Edit): Std DuplicateSelection, Std_Alignment.
2020-10-21 16:26:27 +02:00
luz paz
33caa1ec30 Fix various typos
Found via `codespell v2.0.dev`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-10-21 16:20:08 +02:00
jreinhardt
72eb41b24f Fix macro code processing
I believe this code is currently incorrect, as it makes references to code outside the "if code" block, where it can not be ensured that code is a string. Moving the code processing into this block avoids this issue.

I experienced a stuck Addon Manager, which was caused by an exception

```
  File "/usr/share/freecad/Mod/AddonManager/addonmanager_macro.py", line ..., in fill_details_from_wiki
    FreeCAD.Console.PrintWarning(translate("AddonsInstaller", "Unable to clean macro code: ") + code + '\n')
TypeError: can only concatenate str (not "list") to str
```
which is fixed by these changes.

OS: Ubuntu 20.04.1 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.4.
Build type: Release
Python version: 3.8.2
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.3.0
Locale: English/United States (en_US)
2020-10-20 19:01:12 +02:00
donovaly
783f8dc784 [PD] fix thread UI bugs
- initialization: if a threaded, the fit must not be enabled
- when changing the profile type setReadOnly for the fit and class according to if threaded or not
- when changing if threaded or not, setReadOnly accordingly for the fit and class
2020-10-20 15:47:52 +02:00
Yorik van Havre
2bf4448e09 TechDraw: Better tooltip for scale property 2020-10-20 14:50:23 +02:00
Yorik van Havre
0d511d0551 Arch: Added SectionColor property to Arch Materials 2020-10-20 14:43:33 +02:00
Yorik van Havre
1a2b75ab03 Draft: allow to scale imageplanes 2020-10-20 13:31:40 +02:00
Yorik van Havre
87eae7c58c Arch: Enabled ellipse-based walls - fixes #3859 2020-10-20 13:13:54 +02:00
Yorik van Havre
eee68a314b Start: Allow to display more than one custom folder on the start page 2020-10-20 12:03:27 +02:00
sliptonic
b5dc3887db Merge pull request #3975 from J-Dunn/master
[Path] Add files via upload
2020-10-19 09:53:54 -05:00
donovaly
ec46265bc3 [PD] initialize hole dialog properly
as described in https://forum.freecadweb.org/viewtopic.php?f=3&t=50611, the task dialog should just read out the parameters on initialization and not invoke automatically change actions.

This PR also fixes a bug that opening a document with a cheesehead hole leads to an error about an invalid index. The reason is that we access the hole cut type before we set its enums. Thus initialize the cut type with all possible enums since, if necessary, the reduced enum set will be set later on parsing the file.
2020-10-19 16:48:49 +02:00
wmayer
a29d834bd3 App: [skip ci] fix PropertyEnumeration::setEnums to avoid to produce index values out of range 2020-10-19 16:09:57 +02:00
wmayer
6e6f2c8a0a PartDesign: [skip ci] some improvements in TaskHoleParameters
+ do not rely on translated strings but set user data for the items of the combo box
+ do not use tr() to convert the C strings to QString of the hole feature, use QString::fromLatin1
+ do not use findText() twice for the same search but store the result
2020-10-19 16:08:26 +02:00
donovaly
99dd4460c5 [PD] keep hole size when changing type
as mentioned in https://forum.freecadweb.org/viewtopic.php?f=13&t=47584&start=10#p433116
a typical use case is that one changes the hole type from e.g. ISO normal to ISO fine. The size should however be the same.

This PR enables this and also takes care for the thread class and cut type, see the attached screencast.
2020-10-19 14:44:08 +02:00
wmayer
c0b2188ada PartDesign: [skip ci] make the hole feature more forgiving in case of inconsistent configuration 2020-10-19 14:42:32 +02:00
vocx-fc
39744ce987 Draft: split svg.get_svg into subfunctions (2)
Define a subfunction to process Draft "Dimension" (v0.18)
or "LinearDimension" (v0.19) objects.
2020-10-19 13:23:04 +02:00
vocx-fc
8187cbee19 Draft: split svg.get_svg into subfunctions
Define a subfunction to process `Part.Shape` objects.
2020-10-19 13:23:04 +02:00
vocx-fc
f136ee844d Draft: move svg subfunctions to svgshapes.py module 2020-10-19 13:23:04 +02:00
vocx-fc
ebc50e03ed Draft: move svg subfunctions to svgtext.py module 2020-10-19 13:23:04 +02:00
Zheng, Lei
4d3ea2d850 Draft: support object without shape in DraftLink 2020-10-19 13:22:20 +02:00
Chrismettal
4234e66796 [Stylesheet] Add border to tiled subwindows to allow resizing 2020-10-19 13:21:26 +02:00
vocx-fc
b51c952e4b Surface, MeshPart: update CurveOnMesh command tooltip and task panel
* Add new icon `MeshPart_CurveOnMesh`, which is the same as
the `Surface_CurveOnMesh` icon but in green color.
The surface icon is used in the Surface Workbench, while the MeshPart
version is currently not used.
* Make the tooltip of the command shorter; the longer instructions
are added in the `TaskCurveOnMesh` task panel.
2020-10-19 13:18:12 +02:00
vocx-fc
becd393aff Surface: updated task panel for Surface_Filling
`Fill Surface` becomes `Boundaries`. A label is added
explaining that it is possible to reorder the items
in the list of boundary edges.
2020-10-19 13:18:12 +02:00
vocx-fc
3304e1b44b Surface: update tooltip of Filling 2020-10-19 13:18:12 +02:00
marioalexis
aa88f3ded0 Improve make_sketch and geometric related functions 2020-10-19 13:15:14 +02:00
wmayer
675fdd7c39 travis: disable TechDraw for macOS build
The travis builds for macOS always stop at around 82% and this is a test to see if the build runs out of memory
2020-10-19 10:47:13 +02:00
sliptonic
16ec7c3612 Merge pull request #3976 from sliptonic/master
fix build problem with path
2020-10-18 16:37:43 -05:00
sliptonic
272972559f fix build problem with path 2020-10-18 16:36:47 -05:00
J-Dunn
950269834d Add files via upload
Path: grbl_post G83 expansion , G1 on initial move to retract_Z height to allow retraction height to remain inside hole. This can be useful to avoid widening hole entrance with multiple drill re-entries.moves
2020-10-18 21:07:21 +01:00
sliptonic
3764b404f1 Merge pull request #3966 from sliptonic/feature/RtoIJarcs
[PATH] Add RtoIJ function to PathUtils.  fixes #2606
2020-10-18 14:28:12 -05:00
sliptonic
c6a7f28db9 Merge pull request #3939 from plaes/minor-build-nitpicks
[build / PATH]: Minor build nitpicks
2020-10-18 14:26:47 -05:00
sliptonic
b00acc78be Merge pull request #3962 from sliptonic/feature/boundaryenforcecontrol
PATH: add boundary enforcement to the task panel
2020-10-18 14:26:17 -05:00
sliptonic
adbe6969ba Merge pull request #3956 from sliptonic/bug/pathsanity
Path: handle missing target directory in Path-Sanity
2020-10-18 14:25:45 -05:00
wmayer
1f0b7793e6 Revert "PartDesign: [skip ci] fixes #0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration""
This reverts commit fe3f1b51b7.
2020-10-18 17:08:18 +02:00
Priit Laes
cf5ab312bb Part: Enable test for issue 4456
Now that issue 4456 is fixed, we don't need to skip this test anymore.
2020-10-18 16:26:18 +02:00
wmayer
54e29ac2b8 macOS: suppress some warnings 2020-10-18 16:18:34 +02:00
wmayer
38fcf770ab Qt5: fix build failure with Qt 5.15 2020-10-18 16:17:48 +02:00
wmayer
a96f6619a7 Fem: Python header must be included before vtk headers to avoid re-definition of macro _LARGEFILE_SOURCE 2020-10-18 14:45:31 +02:00
wmayer
8ffbabb605 Py3: suppress warnings about un-initialized/deprecated tp_print slot 2020-10-18 14:45:31 +02:00
wmayer
4e68025d9d Part: remove deprecated type LinePyOld 2020-10-18 14:45:31 +02:00
wmayer
571ab1b6e6 Qt5: make StatusWidget derive from QDialog instead of QWidget to avoid code duplication and using deprecated API functions 2020-10-18 14:45:31 +02:00
wmayer
2057e151d8 Qt5: fix deprecation warnings for Qt 5.15
+ QByteArray::append is deprecated
+ QPixmap* QLabel::pixmap() is deprecated
+ overloaded version of QString::split is deprecated
+ QSysInfo::windowsVersion()/QSysInfo::MacVersion() is deprecated
2020-10-18 14:45:31 +02:00
wmayer
34f4b712d8 Qt5: fix deprecation warnings of QWheelEvent in Qt 5.15 2020-10-18 14:45:31 +02:00
sgrogan
f3bdaaa55a fix import, OpenSCAD isn't namespace workbench 2020-10-17 23:54:26 +02:00
wmayer
01af171a31 macOS: [skip ci] suppress some more Py3.8 warnings, suppress warnings about deprecated OpenGL API 2020-10-17 23:53:47 +02:00