Commit Graph

26960 Commits

Author SHA1 Message Date
Abdullah Tahiri
d76f3b3c0c Sketcher: ViewProvider parameter color subscription
===================================================

Bug:

Subscription/Unsubscription of outside of edit mode parameters was missing.

So changing the edge color from settings required to restart FreeCAD.

Fix:

Subscribe/Unsubscribe from the relevant parameter group
2022-01-07 10:19:22 +01:00
Ajinkya Dahale
c558fc7195 [FEM] Use modal add/remove for more constraints (8/??)
Use the previously added superclass `TaskConstraintOnBoundary` for more
constraints where it's usable.

Currently done:
TaskFemConstraintDisplacement
TaskFemConstraintForce
TaskFemConstraintSpring
TaskFemConstraintFluidBoundary
TaskFemConstraintHeatflux
TaskFemConstraintFixed
TaskFemConstraintTemperature
TaskFemConstraintPressure

Too different:
TaskFemConstraintTransform (single selection)
TaskFemConstraintContact (single selection, two fields)
TaskFemConstraintPlaneRotation (single selection)
(Other constraint tasks, which do not use `addToSelection`)
2022-01-07 05:33:42 +01:00
Ajinkya Dahale
0aeed0e53b [FEM] Add modal add/remove for dispacement constraint
With this, add/remove buttons for displacement constraint will put the user in a
selection mode if pressed when nothing is selected.

Superclass `TaskFemConstraintOnBoundary` Allows code reuse for other
constraints. We do not need this in `TaskFemConstraints` because it is only used
in a subset of constraints, particularly that applies on only some of the
boundary entities.

TODO: Confirm Undo/Redo works appropriately.
TODO: Optimize `onSelectionChanged()`.
2022-01-07 05:33:42 +01:00
Chris Hennes
ecc6dee175 Addon Manager: Clean up copied macros on uninstall 2022-01-06 20:34:48 -06:00
Chris Hennes
7ea0394e97 Addon Manager: Handle symlinking failure 2022-01-06 19:22:00 -06:00
sliptonic
13817448b2 Merge pull request #5097 from Russ4262/fix/waterline
[Path] Fix Waterline error due to invalid arguments in `getOffsetArea()` calls
2022-01-06 18:30:06 -06:00
Ajinkya Dahale
8a59607517 [FEM] Use OpenMP for FemMesh::{getNodesByEdge, getNodesByVertex} 2022-01-07 01:23:01 +01:00
Ajinkya Dahale
147f2a0b07 [FEM] Possibly fix race conditions
Race conditions introduced after using OpenMP in `FemMesh::getNodesByFace` and
`FemMesh::getNodesBySolid` because of which nodes were randomly added or removed
from sets. Solved by replacing `SMDS_MeshNode::X()` etc., which are not thread
safe, with the thread-safe `SMDS_MeshNode::GetXYZ()`.
2022-01-07 01:23:01 +01:00
Philipp Knechtges
8087b34840 [FEM] OpenMP-parallelize FemMesh::{getNodesBySolid,getNodesByFace}
Projecting nodes onto TopoDS_Shapes is a costly task, which can
potentially take a lot of time, so let's parallelize it.
2022-01-07 01:23:01 +01:00
Philipp Knechtges
2336ea1b59 [FEM] speed up get_femelement_sets in meshtools.py
The previous implementation was quite slow in filling up the remaining_femelements list.
The new implementation fixes this by using numpy for the heavy work.
2022-01-07 01:23:01 +01:00
sliptonic
5052809d2b Merge pull request #5228 from P-C-R/RRF-PP-for-Path
Path | RRF (RepRapFirmware | Duet Boards) PP
2022-01-06 18:18:02 -06:00
sliptonic
ba580fc315 Merge pull request #5290 from Russ4262/fix/3D_Surface_Optimize
[Path] Fix 3D Surface OptimizeStepOverTransitions property error
2022-01-06 18:15:36 -06:00
luz paz
b699096721 Plot: remove superfluous whitespace 2022-01-07 00:57:36 +01:00
luz paz
7375b3aa82 Plot: Expose src/Mod/Plot strings to translation
Closes https://github.com/FreeCAD/FreeCAD-translations/issues/60
2022-01-07 00:57:36 +01:00
Uwe
ccc45659b0 [PD] correct copyright
these files were added by Werner in 2020
2022-01-06 21:56:53 +01:00
luz paz
4f886b2b8c Fix various typos and refinements 2022-01-06 20:22:34 +01:00
Roy-043
38534bd33d Draft: improve get_group_contents function in groups.py
For consistency the get_group_contents function should use is_group to identify groups. The code dedicated to Site objects and Drawing pages was removed.
2022-01-06 17:40:11 +01:00
Roy-043
e71c860985 Draft: fix scale.py copy_scaled_edge
The `copy_scaled_edge` function should return a wire, not an edge. The `join_wires` function, called in `copy_scaled_edges`, can only handle wires.
2022-01-06 17:38:41 +01:00
Roy-043
de9007ba92 Draft: Fix importSVG.py: wrong position for certain ellipses (#5297)
Ellipses and elliptical arcs with a y radius larger than their x radius would end up in the wrong position.
2022-01-06 17:02:41 +01:00
Roy-043
f6754eddfc Draft: make Draft_Snap_Angle work in 3D
Draft_Snap_Angle only worked for circular edges on a plane parallel to the XY plane of the global coordinate system.
2022-01-06 16:57:55 +01:00
sliptonic
d5870a87e8 Merge pull request #5319 from jimzim111/PathArray_RandomSeed
Path: Path array jitter random seed
2022-01-06 09:56:12 -06:00
Uwe
a6b01fa1f0 [PD] Hole: some coding style fixes
all done by MSVC
2022-01-06 16:18:25 +01:00
Uwe
7afcc93062 [PD] remove wrong comment
was accidentally introduced by ma previous commit
2022-01-06 16:15:39 +01:00
Uwe
d232f17e23 [PD] Hole: don't call onChanged on restoration
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=10&t=65035
2022-01-06 15:51:03 +01:00
Uwe
8df64b7426 [PD] add missing hole constraint
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
2022-01-06 15:39:13 +01:00
Uwe
f2b0333c75 [PD] Hole: coding style fixes
all by MSVC
2022-01-06 03:51:13 +01:00
Uwe
76c611ae2a [PD] remove unnecessary Unicode characters
they cause problems: https://forum.freecadweb.org/viewtopic.php?p=559077#p559077
2022-01-06 02:57:53 +01:00
wmayer
0c0239571b Sketcher: avoid attaching to/detaching from the same parameter group twice 2022-01-06 00:35:36 +01:00
jim
7ab27ff2e2 merge with formatting and translation changes 2022-01-05 15:01:43 -08:00
wmayer
6aec424aa5 Gui: override QuantitySpinBox::setExpression and validate expression to update internal representation 2022-01-05 20:15:03 +01:00
wmayer
00d6f4f2df Gui: refactor code to reduce code duplication 2022-01-05 20:13:09 +01:00
wmayer
cc4597503f App: include FCGlobal.h for export macro 2022-01-05 20:11:16 +01:00
sliptonic
aa56ce4799 Merge pull request #5336 from jimzim111/Path_Post_MachineCommands
Path: Grbl_post: Allow controller-specific/non-standard gcode commands
2022-01-05 11:53:57 -06:00
Mariwan
122deb98fb Draft: change static to non-static declared variables (#5292)
* Draft: change static to non-static declared variables

* Change variable name and add some comment
2022-01-05 16:39:28 +01:00
mwganson
c93c0e6aaf [Part::CheckGeometry] pass object to buildShapeContent() rather than string as docname.objname 2022-01-05 15:06:49 +01:00
wmayer
ddbf8e0e2d Sketcher: avoid attaching to/detaching from the same parameter group twice 2022-01-05 14:05:05 +01:00
luz paz
4e2c1158c6 Tools: update _TEMPLATE to 2022 2022-01-05 13:20:48 +01:00
luz paz
7f27c81119 Update 'About' info to reflect new year 2022 2022-01-05 13:20:48 +01:00
Uwe
64b2677ac0 [PD] get rid of a CI compiler warning (#5335)
* [PD] get rid of a CI compiler warning

The CI compiler outputs this warning:
FeaturePad.cpp:101:20: warning: variable 'obj' set but not used [-Wunused-but-set-variable]

Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
2022-01-05 12:26:48 +01:00
Mark Ganson TheMarkster
8d6ff3c07b [Spreadsheet] Use DontUseNativeColorDialog parameter when using QtCol… (#5326)
* [Spreadsheet] Use DontUseNativeColorDialog parameter when using QtColorDialog::getColor()
2022-01-05 12:23:14 +01:00
jim
c461af19c3 check for gcode comments that contain controller-specific commands to include 2022-01-04 22:23:15 -08:00
Uwe
dfa62af40f [PD] avoid a single-letter variable
(single letter variables make it hard to read and understand code quickly and are error-prone for typos)
2022-01-05 03:16:00 +01:00
David Osterberg
a0746a0c02 PD: Fix bug in FeatureTransformed
It is important to not include the original in the pattern because the original might not be at the tip of the feature tree. Including the original
will interfere with changes that occur further down in the feature tree

This fixes the bug identified in
https://forum.freecadweb.org/viewtopic.php?f=3&t=64900
2022-01-05 02:27:53 +01:00
luz paz
dc288a7ade Fix more typos + whitespace fix and added 'TODO'
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2022-01-04 18:57:56 -06:00
luz paz
3292475613 Fix various typos 2022-01-04 18:57:56 -06:00
mwganson
977b602469 [PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command 2022-01-05 01:40:10 +01:00
sliptonic
dd651d5dc3 Merge pull request #5330 from sliptonic/bug/translation-post
[Path] Bug/translation post
2022-01-04 17:34:29 -06:00
sliptonic
12a5774ab7 newline characters 2022-01-04 17:34:09 -06:00
sliptonic
bab226a051 Merge pull request #5331 from sliptonic/bug/translation-setupsheet
[PATH] Bug/translation setupsheet
2022-01-04 17:32:10 -06:00
sliptonic
0a44fab03c Merge pull request #5324 from sliptonic/bug/translation3
Path Translation cleanup part 2 [PATH]
2022-01-04 17:31:41 -06:00