Commit Graph

41670 Commits

Author SHA1 Message Date
Chris Hennes
da239c6c69 Gui: Manually specify correct QVariant conversion
There are multiple possible conversion paths for a QPixmap to QVariant,
which results in a compiler warning. Explicitly specify the path we
intend to silence the warning.
2025-05-12 18:17:48 +02:00
Chris Hennes
f0e183b20b Gui: Make variable more local
Eliminate a compiler warning about an unused variable by making the
variable more local to the point-of-use.
2025-05-12 18:16:56 +02:00
Chris Hennes
dce5d9ce82 Gui: Remove default init of shared_ptr
`std::shared_ptr` default-initializes to `nullptr`, so there is no need
to do it manually, and in the current code the initialization is in the
wrong order (so generates a compiler warning).
2025-05-12 18:16:32 +02:00
Chris Hennes
d7433466a0 TD: Fix hatch size constraint
Commit 1155f0d7 changed `UnitsApi::getDecimals()` from `int` to
`size_t`, which changes the meaning of the negation since it is now
unsigned. Cast it to an integer before the negation to restore the old
behavior.
2025-05-12 18:11:15 +02:00
FEA-eng
c9174a25e8 FEM: Update DlgSettingsFemCcx.ui 2025-05-12 11:09:59 -05:00
sliptonic
396c1cef61 Merge pull request #21193 from davidgilkaufman/adaptive_helix_fixes
[CAM] Adaptive helix fixes
2025-05-12 11:09:16 -05:00
saso badovinac
72a173e36d Update sub_weeklyBuild.yml (#21249)
Run harden-runner first
2025-05-12 11:03:39 -05:00
tetektoza
b0599f0cde BIM: Update tooltip for Activate button 2025-05-12 18:00:52 +02:00
tetektoza
464e7d5144 BIM: Introduce Activate for BIM Views
Currently there's no option for selecting active working plane other
than selecting `DoubleClickActivates` property on a BIM Level.

So, this patch adds an additional button for the submenu that BIM Views
provides - to activate working plane of the selected item.
2025-05-12 18:00:52 +02:00
tetektoza
bda260336c BIM: Fix missing IFC attributes for certain BIM objects
Some of the objects, like Column, or Beam do not contain `IFC
Attributes` if they are initially created.

As it turns out, they are not being created as we are checking for
`onDocRestoredDone` attribute, which is assigned in `onDocumentRestored`
function. Since users can usually just not restore a document, but just
play on a newly created document, this attribute won't be available,
thus we won't be going through whole `onChanged` logic which populates
`IFC Attributes`.

To preserve current functionality of this additional parameter and not
cause the previous errors to happen, this patch just changes from the
custom flag to globally available `Restoring` flag which tracks document
being restored more reliably.
2025-05-12 17:50:11 +02:00
Roy-043
ca0630aa50 BIM: close BIM_Library task panel on doc close
Fixes #21179.

This PR uses the built-in solution to close the task panel.

I was not aware of this feature before. My 2 previous PRs related to the closing of task panels, #20719 and #21073, will (largely) have to be reverted/redone in favor of this solution.
2025-05-12 17:48:39 +02:00
Roy-043
b451193a49 Draft: aux.fake_function should not overwrite functions
The `aux.fake_function` is used in the Draft unit tests as a substitute for functions that, in most cases, do not yet exist. But in test_modification.py it would overwrite Draft.extrude leading to issues with BIM unit tests.

See:
https://github.com/FreeCAD/FreeCAD/pull/21134#issuecomment-2869178563
2025-05-12 10:45:45 -05:00
mosfet80
7f3398f320 [Mod] Drawing remove (#20419)
* [Mod] Draw remove

removed deprecated drawing module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-12 17:43:25 +02:00
sliptonic
3f6805a380 Merge pull request #20873 from tarman3/startpoint
CAM: Fixes PickStartPoint
2025-05-12 10:40:57 -05:00
marcuspollio
67f1b41bc2 BIM: fix some imports and cleanup miscellaneous (#20914) 2025-05-12 17:40:12 +02:00
Chris Hennes
f5806841b6 Merge pull request #19907 from benj5378/getAttribute
Base: make getAttribute template
2025-05-12 10:39:55 -05:00
Furgo
3502b60c73 BIM: set DoubleClickActivates property true by default 2025-05-12 17:36:29 +02:00
sliptonic
59483c8001 Merge pull request #21265 from LarryWoestman/refactor
CAM:  updated opensbp post to work with current Processor.py
2025-05-12 09:32:43 -05:00
sliptonic
fbe94b352e Merge pull request #20828 from tarman3/DressupPathBoundary-KeepToolDown
CAM: Keep tool down in DressupPathBoundary
2025-05-12 09:07:44 -05:00
tarman3
b7ba562288 CAM: PickStartPoint fixes 2025-05-12 16:57:32 +03:00
tarman3
f75d79860b CAM: Simulator - Decrease speed button (#21222)
* CAM: Simulator - Decrease speed button

* CAM: Simulator - Move slider upper

* CAM: Simulator - Changed speed icons
2025-05-12 08:57:30 -05:00
Kacper Donat
f71e84cad9 Gui: Fix handling - character in OVP 2025-05-12 08:55:09 -05:00
sliptonic
43d94f1575 Merge pull request #21177 from dbtayl/fix_adaptive_repeated_cuts
CAM: Fix adaptive repeating cuts excessively at various depths
2025-05-12 08:15:55 -05:00
sliptonic
fd4e504b13 Merge pull request #21128 from jffmichi/fix_array_dressup
CAM: bring Array dressup in line with existing dressups
2025-05-12 08:10:31 -05:00
Jacob Oursland
32debd36e8 CI: use the weekly build tag in title bar of main window. 2025-05-12 11:22:14 +02:00
Jacob Oursland
2380f9153d CI: use the exact same source for weekly builds. 2025-05-12 11:21:12 +02:00
tarman3
a00c402d7a CAM: Simulator - Add document name to title 2025-05-12 08:22:44 +02:00
Lawrence Woestman
07e78f5631 CAM: updated opensbp post to work with current Processor.py 2025-05-11 15:39:49 -07:00
tarman3
43b2a0e301 Macro: Button to open folder with macros 2025-05-11 21:54:07 +02:00
dependabot[bot]
ce368cb7a0 Bump actions/dependency-review-action
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 67d4f4bd7a9b17a0db54d2a7519187c65e339de8 to 8805179dc9a63c54224914839d370dd93bd37b2e.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](67d4f4bd7a...8805179dc9)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: 8805179dc9a63c54224914839d370dd93bd37b2e
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-09 14:27:21 -05:00
dependabot[bot]
187d615c37 Bump github/issue-metrics from 3.19.0 to 3.20.0
Bumps [github/issue-metrics](https://github.com/github/issue-metrics) from 3.19.0 to 3.20.0.
- [Release notes](https://github.com/github/issue-metrics/releases)
- [Commits](0bac475850...6a0f49b4e1)

---
updated-dependencies:
- dependency-name: github/issue-metrics
  dependency-version: 3.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-09 14:26:12 -05:00
saso badovinac
f90f102efe Update sub_weeklyBuild.yml
Pin Actions to a full length commit SHA
2025-05-09 14:25:57 -05:00
saso badovinac
1ca01d80bd Update sub_lint.yml
Pin Actions to a full length commit SHA
2025-05-09 14:25:42 -05:00
Benjamin Bræstrup Sayoc
6786af6ef9 Everywhere: clean up getAttribute conversions 2025-05-09 15:54:57 +02:00
Benjamin Bræstrup Sayoc
492b8312b3 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
pre-commit-ci[bot]
2683d41cc7 CAM: clean up code 2025-05-09 09:53:34 -04:00
David Kaufman
fad13fb300 CAM: add spiral-out to full radius at the bottom of the cone helix 2025-05-09 09:53:34 -04:00
David Kaufman
7629312717 CAM: delete dedicated cone helix implementation, merge into standard implementation 2025-05-09 09:53:34 -04:00
David Kaufman
9d64f5fb0f CAM: Allow helix angles between 0 and 1 degree 2025-05-09 09:53:27 -04:00
tarman3
9577d108e3 CAM: Simulator window title 2025-05-09 12:50:32 +02:00
Pieter Hijma
895bf8db8b Doc: Fix small doc warnings in ExtensionContainer 2025-05-08 17:52:33 -05:00
Pieter Hijma
57d2d51c9b Doc: Improve App::Extension documentation 2025-05-08 17:52:33 -05:00
Rayno Jiang
2032a9d844 Sketcher: Scaling of a sketch containing BSplines doesn't work (#20943)
* [FreeCAD-20111] Sketcher: Scaling of a sketch containing BSplines doesn't work
When we executing Scale cmd we don't will lose knots information from shape geometry and it cause the scaled spline build with issue knots and it lead solver gets compute issue.
1. Add string format function PythonConverter::makeArryString(const std::stringstream& ss) for processing the control pnts string, mults string and knots string.
2. Add mults and knots information for python obj to make BSplineCurvePy::buildFromPolesMultsKnots(Args...) initialized Geom_BSplineCurve correctly.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. fix typo
2. Add wights info to keep spline shape after convert from python object

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. remove static function makeArrayString() from PythonConverter
1. Add template function makeSplineInfoArrayString() to generate string for cleaner code.
2. change python string format as review suggestion

* use fmt format

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fixes #20111

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-09 00:02:33 +02:00
xtemp09
54fdd62fc7 Gui: Add switching to the document when closing FreeCAD (#21135)
* Add switching to the document when closing FreeCAD

Closes #20997

* Some update of language

* camelCase every variable name used
2025-05-08 23:59:11 +02:00
Syres916
340cfc6feb [App] find Pyside and Shiboken versions whether it be Qt5 or Qt6 2025-05-08 23:39:51 +02:00
Stefan Tröger
4a78446e84 FEM: Fix test if VTK or VTK python is not available (#21168)
* FEM: Fix test if VTK or VTK python is not available
* FEM: Make test work if vtk python not installed
2025-05-08 15:55:45 -05:00
FilippoR
ff4740d082 Tests: Add FREECAD_USE_EXTERNAL_GTEST cmake option (#21190)
Add FREECAD_USE_EXTERNAL_GTEST cmake option and fix build with external libraries
2025-05-08 15:41:48 -05:00
Chris Hennes
3d18203403 TD: Fix capitalization of Console calls 2025-05-08 21:08:45 +02:00
theo-vt
e56979e76e PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030)
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
2025-05-08 16:47:26 +00:00
WandererFan
9938818d82 [TD]Allow non-shape views to have children (#20768) (#21099)
* [TD]Allow non-shape views to have children (#20768)

* Update src/Mod/TechDraw/App/DrawView.cpp

Review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/App/DrawView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-08 09:18:09 -05:00