Commit Graph

806 Commits

Author SHA1 Message Date
wmayer
2de84d64e8 fix warning: lambda capture 'this' is not used [-Wunused-lambda-capture] 2018-02-10 12:42:41 +01:00
wmayer
e40b2c7470 disable tip handling in PD view providers when start or finish editing 2018-02-10 00:46:30 +01:00
wmayer
3f9dda9263 proper handling of setting and reverting preview mode in PD view provider 2018-02-10 00:42:10 +01:00
wmayer
8101f35f22 avoid superfluous transaction on PD primitive creation 2018-02-09 23:10:40 +01:00
wmayer
c5ae798026 in ViewProviderBody::updateData make sure a view provider exists 2018-02-09 22:14:44 +01:00
Abdullah Tahiri
5681acf937 Part Design: Avoid feature modification during initialization
=============================================================

The values for the primitives are set after the connections to the slots "onchange" are connected.

This causes a river of onChanges at feature level which set the properties and modify the feature (to the same values).

Moving the connections at the end of the function just solves this issue.
2018-02-09 16:01:19 +01:00
luz.paz
12c04d6c4e Crowdin: fix case for 'partdesign'
ref: https://crowdin.com/translate/freecad/564/en-fr#6500374
also through in a random typo fix
2018-02-07 09:45:34 +01:00
luz.paz
1d5799e5b3 Misc. typos
Inspired by @normandc per https://gitter.im/FreeCAD/FreeCAD?at=5a729c6ece68c3bc742df205
2018-02-07 09:40:03 +01:00
wmayer
f139966868 make green for tip a bit darker 2018-02-01 19:30:25 +01:00
Abdullah Tahiri
3ea4debaf3 PartDesign: Highlight body tip
==============================

It generates a small green icon on the treeview for those features being the tip of the body.
2018-02-01 19:15:48 +01:00
wmayer
28c2baefbf fixes #0002559: Body becomes visible upon changing DisplayModeBody 2018-01-30 15:58:32 +01:00
Abdullah Tahiri
2ad1653a3f PartDesign: OnDelete basefeature fixing and visualization
=========================================================

fixes #3084
fixes #3061 (at least what it is understood in the analysis as being a bug, the visualization left).

Basically when deleting a feature, if it is the base feature (feature with which it will merge or cutout), the dependent objects'
base feature is made to be the base feature of the object being deleted. This code pre-existed at body level, but was not being called (see below).

Additionally, if the visible object is not the one being deleted, we leave that one visible. If the visible object is the one
being deleted, we make the previous object visible.

Deletion from the tree of a feature is handled by Document.removeObject, which has no clue about what a body is. Therefore, Bodies, although an
'activable' container, know nothing about what happens at Document level with the features they contain.

The Deletion command StdCmdDelete::activated, however does notify the viewprovider corresponding to the feature (not body) of the imminent deletion
(before actually doing it). Consequently, the only way of notifying a body of the imminent deletion of one of its features so as to do the clean up
required (moving basefeature references, tip management) is from the viewprovider of the feature being deleted.
2018-01-22 22:03:18 +01:00
Abdullah Tahiri
fd7d75b309 PartDesign: Extension of Pocket Feature to have two dimensions
fixes #2915
2018-01-20 16:15:38 +01:00
wmayer
2b5765eb66 add option to compute vertex normals from the triangulation instead of the u,v nodes
This is a workaround for issue #0003180: Wrong normal of part object
2018-01-14 15:55:01 +01:00
luz.paz
831bf31817 Misc. typos
+ stepcode typo submitted upsream https://github.com/stepcode/stepcode/pull/372
2018-01-07 18:41:29 -02:00
wmayer
e68021029d improve UpToFace option of pad/pocket for datum planes 2018-01-06 17:36:14 +01:00
wmayer
595f77050e allow to move PD objects via drag and drop to a body 2018-01-04 00:11:28 +01:00
wmayer
57732f7441 add option to getBodyFor to suppress dialog to set workflow style to modern 2018-01-03 21:35:03 +01:00
wmayer
2bf2449e48 +fixes #0003095: Manual migration from 0.16 models to 0.17 models not possible 2018-01-03 19:43:17 +01:00
wmayer
eafabcddc8 fix typo 2018-01-03 18:51:32 +01:00
wmayer
a8f486663e fix crash in ViewProviderBody::setVisualBodyMode due to missing view provider 2018-01-03 17:59:45 +01:00
wmayer
43c31a1f12 fix typo and improve whitespaces 2018-01-03 17:52:32 +01:00
wmayer
e88848bc0b fix function assertActivePart by creating the part container 2018-01-03 15:27:35 +01:00
luzpaz
0bafb04924 PartDesign: typos 2017-12-25 11:04:43 +01:00
Yorik van Havre
796e5a148a Fixed gradient in last commit 2017-12-07 18:54:47 -02:00
Yorik van Havre
31db5c5b77 Bitacovir's new clone icon 2017-12-07 18:50:22 -02:00
Unknown
3d914beb88 SVG Cleanup: tweaked <dc:description> tags for changed clone icons
Follow-up to changes made in 7797850ee833b9cfdfe6ba9b801dbc46ab536366
+ remove agryson from the 2 icon properties
2017-12-02 14:02:14 +01:00
luzpaz
8200c97ed2 Fix Techdraw UI typo found via crowdin + misc. typos
Ref: https://crowdin.com/translate/freecad/27911/en-eu#6503377
2017-11-26 15:48:20 +01:00
wmayer
f1f2a90190 fix coverity issues 2017-11-18 18:07:00 +01:00
luzpaz
fa0f8cd9a7 PartDesign: Fix previous commit + more typos 2017-11-18 12:50:26 +01:00
wmayer
d591ec7b07 fix German translation 2017-11-12 16:37:06 +01:00
wmayer
d9cc4a621b fix German translation 2017-11-11 22:47:12 +01:00
Yorik van Havre
9b93e15612 Less copyright-harmful clone icons for Draft and PartDesign 2017-11-06 19:38:36 -02:00
Peter Lama
033334474c Rename superPlacement property to AttachmentOffset
The name Attachment Offset gives a better picture of what the
property does.
2017-11-05 16:41:25 +01:00
wmayer
3923438307 add 2d features to body for drag and drop 2017-11-05 12:37:46 +01:00
wmayer
2f2ba28156 remove pointless Section option from boolean operation in PD 2017-11-04 13:46:42 +01:00
Yorik van Havre
05a5e9965e Updated translations from crowdin 2017-10-23 18:32:02 -02:00
Markus Lampert
a61ee41695 Fixed whitespace inconsistency. 2017-10-22 11:24:58 -07:00
wmayer
9bb1454ef4 allow the user to proceed if default settings for revolution/groove raises an exception 2017-10-18 12:52:04 +02:00
wmayer
1d26a2d930 various fixes:
+ fix invalid cast
+ some minor optimizations
+ improve exception handling
2017-10-18 12:33:41 +02:00
Unknown
31a32b9931 Doxygen Typos
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
Unknown
8d9bd319bd Misc. Typos 2017-10-09 19:59:33 +02:00
wmayer
16e32c0020 automatically set the tip after creating transform features to avoid messing up the history 2017-10-06 10:20:26 +02:00
luzpaz
f3bf8fe919 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
wmayer
3da1e03593 fixes #0002862: Check for shape type before using selection as base feature 2017-10-02 00:56:47 +02:00
wmayer
3d82c86b62 handle editing of view provider of base feature 2017-10-01 19:32:11 +02:00
wmayer
5d9c1d0434 implement clone command for part design 2017-10-01 18:25:55 +02:00
wmayer
6f6ff3bab1 harmonize creation of linear pattern inside a multi transform to direction creation of linear pattern 2017-09-29 23:57:31 +02:00
wmayer
3b1c433daa fix crashes when aborting linear pattern panel due access of null pointers 2017-09-29 21:22:48 +02:00
wmayer
9beb6f2029 fixes #0003179: PDN + AdditiveBox + MultiTransform (with LinearPattern) 2017-09-29 19:55:42 +02:00