isConvergedToNumericalLimit() compared dxNorms->at(iterNo) to itself
instead of comparing current vs previous iteration. This prevented
the solver from detecting convergence improvement, causing it to
exhaust its iteration limit on assemblies with many constraints.
Fix: read dxNorms->at(iterNo - 1) for the previous iteration's norm.
* Check rackpin and gear for zero radii
* rebase zero-radii-check (#69)
* contributing
* Update push-freecad.yml
updated actions/checkout to v4
* dragging log for debugging
* fix calcdxNorm crash
* setDebug and remove MBDyn*
* Update cmakelists.txt
* fix includes for gcc-14
gcc-14 is more disciplined about not including <algorithm> transitively.
* fix runDragStep
* backhoe files (#65)
* Mark unused variables to silence compiler warnings. (#64)
* Backhoe issues (#67)
* backhoe issues
* runDragStep edit
* backhoe issues
* runDragStep edit
* Reduce large drag step progressively until convergence.
* Switch to using built-in M_PI, even on MSVC (#68)
---------
Co-authored-by: Brad Collette <bradcollette@pop-os.localdomain>
Co-authored-by: mosfet80 <realeandrea@yahoo.it>
Co-authored-by: PaddleStroke <pierrelouis.boyer@gmail.com>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: sliptonic <shopinthewoods@gmail.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
* in progress
* Gtest added
* With changes from Assembly
* WinMerge main and this branch
* Add flag for GTest
* Flag to suppress OndselSolverMain
* rebase zero-radii-check (#69)
* contributing
* Update push-freecad.yml
updated actions/checkout to v4
* dragging log for debugging
* fix calcdxNorm crash
* setDebug and remove MBDyn*
* Update cmakelists.txt
* fix includes for gcc-14
gcc-14 is more disciplined about not including <algorithm> transitively.
* fix runDragStep
* backhoe files (#65)
* Mark unused variables to silence compiler warnings. (#64)
* Backhoe issues (#67)
* backhoe issues
* runDragStep edit
* backhoe issues
* runDragStep edit
* Reduce large drag step progressively until convergence.
* Switch to using built-in M_PI, even on MSVC (#68)
---------
Co-authored-by: Brad Collette <bradcollette@pop-os.localdomain>
Co-authored-by: mosfet80 <realeandrea@yahoo.it>
Co-authored-by: PaddleStroke <pierrelouis.boyer@gmail.com>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: sliptonic <shopinthewoods@gmail.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
* in progress
* Gtest added
* With changes from Assembly
* Add flag for GTest
* Flag to suppress OndselSolverMain
---------
Co-authored-by: Brad Collette <bradcollette@pop-os.localdomain>
Co-authored-by: mosfet80 <realeandrea@yahoo.it>
Co-authored-by: PaddleStroke <pierrelouis.boyer@gmail.com>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: sliptonic <shopinthewoods@gmail.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
* first fix to start branch PR
* explicit conversion from sizet to int
* Array.h and DiagonalMatrix.h
* many sizet to int conversions
* removed some unused variables and added expl overrides
* removed many unused parameters
* more typing
* even more
* last of the easy changes
